💬 Rob1Ham commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3067310302)
> Looks like `p2p_ibd_txrelay.py ` test needs updating.

Dropped in a PR [here](https://github.com/RobinLinus/bitcoin/pull/1) to add testing so this passes.

💬 fjahr commented on pull request "index: Fix coinstats overflow":
(https://github.com/bitcoin/bitcoin/pull/30469#discussion_r2203533119)
Done

💬 fjahr commented on pull request "index: Fix coinstats overflow":
(https://github.com/bitcoin/bitcoin/pull/30469#discussion_r2203537800)
Fixed, and thanks for the ping, I missed the failed CI initially.

💬 fjahr commented on pull request "index: Fix coinstats overflow":
(https://github.com/bitcoin/bitcoin/pull/30469#issuecomment-3067328764)
Addressed @mzumsande 's comments and added a release note.

📝 stutxo opened a pull request: "fix spelling in tor.md docs and wycheproof description"
(https://github.com/bitcoin/bitcoin/pull/32961)
This PR is to fix some spelling mistakes i found of the word occurrences! there are two occurrences of this mistake.

thanks!

💬 stutxo commented on pull request "fix spelling in tor.md docs and wycheproof description":
(https://github.com/bitcoin/bitcoin/pull/32961#discussion_r2203544532)
it has come to my attention that i cant change this file, so i can remove this one if thats a problem

💬 stutxo commented on pull request "fix spelling in tor.md docs":
(https://github.com/bitcoin/bitcoin/pull/32961#discussion_r2203554978)
I removed the occurrence of the spelling mistake in this commit https://github.com/bitcoin/bitcoin/commit/84ef5524d5abaf07cc9970f42e74ee15bd381e3d

💬 dooglus commented on issue "SegFault in QSortFilterProxyModelPrivate::build_source_to_proxy_mapping":
(https://github.com/bitcoin/bitcoin/issues/32957#issuecomment-3067354549)
I just had the same crash happen again. This time very shortly after starting bitcoin-qt, while it was still loading the mempool from disk. I ran the 'loadwallet' loop again, and it crashed on the 2nd wallet in the loop. There's one wallet loaded from `bitcoin.conf` where it says "wallet=wallet1". I waited for that to finish loading before starting the "bitcoin-cli loadwallet $w" loop.

Here's the debug.log:

2025-07-13T22:25:10Z Leaving InitialBlockDownload (latching to false)
2025-07-1
...

💬 l0rinc commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3067466185)
Every commit needs to pass CI independently, and instead of merge commits, we usually add [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line).
Could you please squash the commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits?

And could you please explain how you got to the 10x reduction, did
...

💬 anhilde commented on issue "Bitcoin Core v29.0 incorrectly enters IBD mode when only ~600 blocks behind, preventing normal sync":
(https://github.com/bitcoin/bitcoin/issues/32955#issuecomment-3067487975)
It goes into Initial Block download mode although it has completed that before. So after restart I would expect it syncs up to the latest block, but it does not do so. It does not sync at all although it has peers and good connection. Only employing the steps described above makes it sync up to the latest block and then continue processing blocks.

💬 sipa commented on issue "Bitcoin Core v29.0 incorrectly enters IBD mode when only ~600 blocks behind, preventing normal sync":
(https://github.com/bitcoin/bitcoin/issues/32955#issuecomment-3067492592)
What does the `getchaintips` RPC report when it's stuck?

I think the IBD you observe is a red herring; Bitcoin Core should *always* sync with the chain, whether it's in IBD or not. IBD just modifies a few heuristics to favor bulk processing.

💬 anhilde commented on issue "Bitcoin Core v29.0 incorrectly enters IBD mode when only ~600 blocks behind, preventing normal sync":
(https://github.com/bitcoin/bitcoin/issues/32955#issuecomment-3067588151)
That makes sense, I will check it, when it gets stuck again. It may take some time until that happens. I have had it happen about twice in 2 months.

💬 1440000bytes commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3067601788)
Concept NACK

I don't see any need to change default `minrelaytxfee`. It is configurable and users can change it for their node. Full RBF and OP_RETURN changes were done for different reasons. However, this is now getting into DoS territory.

Only fee estimation should be changed to work with lower fee rates: https://github.com/bitcoin/bitcoin/pull/13990

It's good that bitcoin price in terms of USD is higher and the cost for an attacker to use p2p as broadcast system has increased over th
...

💬 1440000bytes commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3067602407)
<img width="3200" height="1800" alt="image" src="https://github.com/user-attachments/assets/8c579f7d-6749-4c3b-b234-dcb454ce5ceb" />

📝 Sameera1994 opened a pull request: "minor updates"
(https://github.com/bitcoin/bitcoin/pull/32962)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 w0xlt commented on pull request "wallet: Remove `upgradewallet` RPC":
(https://github.com/bitcoin/bitcoin/pull/32944#discussion_r2203825769)
If we simply delete these functions, there will be issues with the `getwalletinfo` and `migratewallet` RPCs, as they call `CanSupportFeature`, which calls `IsFeatureSupported`, which checks the `CWallet::nWalletVersion` attribute.

Those functions can potentially be removed, but the following code snippets need to be addressed first:: https://github.com/bitcoin/bitcoin/blob/6a13a6106e3c1ebe95ba6430184d6260a7b942bd/src/wallet/rpc/wallet.cpp#L92-L94 and https://github.com/bitcoin/bitcoin/blob/6a
...

🤔 delta1 reviewed a pull request: "fix spelling in tor.md docs"
(https://github.com/bitcoin/bitcoin/pull/32961#pullrequestreview-3014742758)
ACK 84ef5524d5abaf07cc9970f42e74ee15bd381e3d

just a typo fix in a markdown file

💬 w0xlt commented on pull request "wallet: Remove `upgradewallet` RPC":
(https://github.com/bitcoin/bitcoin/pull/32944#issuecomment-3067948494)
Release note added

💬 maflcko commented on pull request "fix spelling in tor.md docs":
(https://github.com/bitcoin/bitcoin/pull/32961#issuecomment-3067976145)
lgtm ACK 84ef5524d5abaf07cc9970f42e74ee15bd381e3d

✅ maflcko closed a pull request: "minor updates"
(https://github.com/bitcoin/bitcoin/pull/32962)