💬 Sammie05 commented on pull request "test: add valid tx test with minimum-sized ECDSA signature (8 bytes DER-encoded)":
(https://github.com/bitcoin/bitcoin/pull/32924#issuecomment-3066510113)
Thanks for adding coverage for this very specific edge case.

Using a real testnet transaction is a solid way to ensure the test reflects actual chain data.
Also appreciate the clear comments explaining why this minimal 8-byte DER signature can appear and why it matters.

📝 Sammie05 opened a pull request: "doc: clarify note about backup after migratewallet"
(https://github.com/bitcoin/bitcoin/pull/32956)
Added a clarifying note that after migration, the original legacy wallet file remains unchanged on disk as a backup. This helps users understand that migration is non-destructive.

💬 zaidmstrr commented on pull request "rpc: Handle -named argument parsing where '=' character is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2203147913)
Thank you for the detailed review!

I think you're right, my current approach regarding named parameter handling is too verbose/complex, and I looked at your implementation, and I really liked the way you're handling named parameters in the RPCConvertNamedValues function. I will implement that approach in my next update commit. Besides that, I also looked at the json parsing issue you're mentioning, and it's easily reproducible. I experimented with both the approaches, the one you provided and
...

💬 Sjors commented on issue "Guix build fails on M4 macOS host with Ubuntu in UTM":
(https://github.com/bitcoin/bitcoin/issues/32759#issuecomment-3066701981)
So far I found:

- `python-scikit-build-core` builds fine
- `python-pydantic-2` fails
- `python-pydantic-core` fails

My current suspicion is that `Python-2.7.18` / `python2-minimal` is the culprit, based on what was being built around the time it fails.

However I'm unable to produce the failure if I just insert `python-2.7` somewhere in the manifest. Part of the problem is that I don't really understand how these manifest files work.

But if my suspicion is current, then it might be a matter o
...

💬 soosho commented on issue "Bitcoin Core v29.0 incorrectly enters IBD mode when only ~600 blocks behind, preventing normal sync":
(https://github.com/bitcoin/bitcoin/issues/32955#issuecomment-3066998502)
uo

💬 pinheadmz commented on issue "Bitcoin Core v29.0 incorrectly enters IBD mode when only ~600 blocks behind, preventing normal sync":
(https://github.com/bitcoin/bitcoin/issues/32955#issuecomment-3066999923)
What's the issue here? What do you consider "IBD" and "normal sync"?

💬 kiss1111kiss commented on issue "Error unlocking wallet: some keys decrypt but not all. your wallet file may be corrupt. ":
(https://github.com/bitcoin/bitcoin/issues/29789#issuecomment-3067049412)
你好你得问题解决了吗 我也目前也是这样得情况

💬 kiss1111kiss commented on issue "Error unlocking wallet: some keys decrypt but not all. your wallet file may be corrupt. ":
(https://github.com/bitcoin/bitcoin/issues/29789#issuecomment-3067049539)
Hey, my litecoin wallet is saying its corrupted when I’m trying to send funds. I do have passphrase on it and I get this error while trying to send out litecoin. Also, when trying to change my passphrase litecoin core will close when i try and change my passphrase. Any help with this would be great and I appreciate your time. thanks Reward 10ltc

<img width="705" height="248" alt="Image" src="https://github.com/user-attachments/assets/0ab36f99-e6f3-4ee5-ba66-002a6ff4001f" />

💬 kiss1111kiss commented on issue "Error unlocking wallet: some keys decrypt but not all. your wallet file may be corrupt. ":
(https://github.com/bitcoin/bitcoin/issues/29789#issuecomment-3067050259)
Hey, my litecoin wallet is saying its corrupted when I’m trying to send funds. I do have passphrase on it and I get this error while trying to send out litecoin. Also, when trying to change my passphrase litecoin core will close when i try and change my passphrase. Any help with this would be great and I appreciate your time. thanks Reward 10ltc

<img width="705" height="248" alt="Image" src="https://github.com/user-attachments/assets/d9a1ee7f-206b-45ea-8afa-a06160409637" />

⚠️ dooglus opened an issue: "SegFault in QSortFilterProxyModelPrivate::build_source_to_proxy_mapping"
(https://github.com/bitcoin/bitcoin/issues/32957)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

I was loading a bunch of old wallets sequentially using "bitcoin-cli loadwallet" in a loop. bitcoin-qt crashed shortly after finishing loading one wallet and starting to load the next.

The debug log shows this at the end:

2025-07-13T13:06:26Z init message: Rescanning…
2025-07-13T13:06:26Z [wallet23] Rescanning last 3130 blocks (from block 902235)...
2025-07-13T13:06:26Z [wall
...

📝 kevkevinpal opened a pull request: "wallet/refactor: change PSBTError to PSBTResult and remove std::optional<common::PSBTResult> and return common::PSBTResult"
(https://github.com/bitcoin/bitcoin/pull/32958)
### Description
This is a follow-up to https://github.com/bitcoin/bitcoin/pull/31622#discussion_r2092030045 and https://github.com/bitcoin/bitcoin/pull/31622#discussion_r2092035407

### What this changes
- Updates `PSBTError` to `PSBTResult`
because we now have `PSBTResult::OK`

- Updates `PSBTErrorString` to `PSBTResultString`

- Updates `RPCErrorFromPSBTError` to `RPCErrorFromPSBTResult`

- Removes `std::optional<common::PSBTResult>` and instead returns just `common::PSBTResult`
re
...

📝 RobinLinus opened a pull request: "Reduce minrelaytxfee to 100 sats/kvB"
(https://github.com/bitcoin/bitcoin/pull/32959)
**Motivation**
The default relay-fee (-minrelaytxfee) was set to 1000 sat/kvB about [10 years ago](https://github.com/bitcoin/bitcoin/commit/536766c903c8dc84e6709e4bd387aad5acf8e433). Over that period the USD price of BTC has risen by roughly 2-3 orders of magnitude, making the economic cost of relaying small transactions disproportionately high.

**Proposed change**
Lower the default to 100 sat/kvB—a 10× reduction—bringing the effective USD cost back in line. This maintains DoS resistance
...

💬 Christewart commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#issuecomment-3067229504)
ACK 2c2acb37ecdeed1582b9835f9075d44e313d787c

For anyone else interested, i cherry-picked 2c2acb37ecdeed1582b9835f9075d44e313d787c onto master and ran the test to make sure it fails as expected on this branch: https://github.com/Christewart/bitcoin/tree/2025-07-13-sigop-limit-no-policy-modification

💬 lifofifoX commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3067236399)
`DEFAULT_INCREMENTAL_RELAY_FEE` should be decreased along with this as well.

💬 jlopp commented on pull request "Reduce minrelaytxfee to 100 sats/kvB":
(https://github.com/bitcoin/bitcoin/pull/32959#issuecomment-3067242689)
Looks like `p2p_ibd_txrelay.py ` test needs updating.

🤔 stringintech reviewed a pull request: "kernel: Introduce initial C header API"
(https://github.com/bitcoin/bitcoin/pull/30595#pullrequestreview-3014202096)
Left a number of documentation-related comments.

💬 stringintech commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#discussion_r2203431643)
Could we check and return zero if `transaction_undo_index` is out of bounds here as well? (and then update the documentation in the header file that zero return value is indicative of out of bounds error)

💬 stringintech commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#discussion_r2203432158)
Might be good to include that returning zero could also be indicative of an error.

💬 stringintech commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#discussion_r2203435973)
In the corresponding [commit](https://github.com/bitcoin/bitcoin/commit/d031c5871e47112a93b25a0612123a5b3eaf2a33) description it is included that _the returned `kernel_TransactionOutput` is entirely owned by the user
and ..._ . It would be nice to also include the explanation here.

💬 stringintech commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#discussion_r2203475130)
nit
```suggestion
* @return The block index of the current tip, or null if no active chain exists.
```