🚀 fanquake merged a pull request: "log: Properly log warnings with warn loglevel in addrdb"
(https://github.com/bitcoin/bitcoin/pull/32933)
(https://github.com/bitcoin/bitcoin/pull/32933)
✅ fanquake closed an issue: "qt: translation related warnings"
(https://github.com/bitcoin/bitcoin/issues/32710)
(https://github.com/bitcoin/bitcoin/issues/32710)
🚀 fanquake merged a pull request: "cmake: Use newer signature of `qt6_add_lrelease` when available"
(https://github.com/bitcoin/bitcoin/pull/32940)
(https://github.com/bitcoin/bitcoin/pull/32940)
💬 Sjors commented on pull request "Enable `-Werror=dev` in CI & Guix":
(https://github.com/bitcoin/bitcoin/pull/32937#issuecomment-3062371486)
re-ACK 8f766f39df3e312f79f461b2accc2f9c90fa6338
Guix build on x86_64:
```
f73822833d8c3ff2b2dda2ddc5e16cb1794aa4eb299b1f468fa8dbadfd6b2310 guix-build-8f766f39df3e/output/aarch64-linux-gnu/SHA256SUMS.part
35783f79defa8b4032b78443a28e88a9c11314470fc177afa9e21d0e613bd937 guix-build-8f766f39df3e/output/aarch64-linux-gnu/bitcoin-8f766f39df3e-aarch64-linux-gnu-debug.tar.gz
b0345a28e82514d51cb363d798d950e44e630ba357a5e522537e1a7b4a37a151 guix-build-8f766f39df3e/output/aarch64-linux-gnu/bitc
...
(https://github.com/bitcoin/bitcoin/pull/32937#issuecomment-3062371486)
re-ACK 8f766f39df3e312f79f461b2accc2f9c90fa6338
Guix build on x86_64:
```
f73822833d8c3ff2b2dda2ddc5e16cb1794aa4eb299b1f468fa8dbadfd6b2310 guix-build-8f766f39df3e/output/aarch64-linux-gnu/SHA256SUMS.part
35783f79defa8b4032b78443a28e88a9c11314470fc177afa9e21d0e613bd937 guix-build-8f766f39df3e/output/aarch64-linux-gnu/bitcoin-8f766f39df3e-aarch64-linux-gnu-debug.tar.gz
b0345a28e82514d51cb363d798d950e44e630ba357a5e522537e1a7b4a37a151 guix-build-8f766f39df3e/output/aarch64-linux-gnu/bitc
...
💬 Sjors commented on issue "Guix build fails on M4 macOS host with Ubuntu in UTM":
(https://github.com/bitcoin/bitcoin/issues/32759#issuecomment-3062401151)
I created a branch to debug this: https://github.com/Sjors/bitcoin/commits/2025/07/guix-aarch64-debug/
It starts from https://github.com/bitcoin/bitcoin/commit/c8abd972818f83d90bf50b250131f338034460ef. First it drops `python-tomli` and `lief` and disables the security checks. I run `HOSTS="arm64-apple-darwin" contrib/guix/guix-build` and make it succeeds.
Next I add `python-scikit-build-core` and pretend its needed for `signapple`. Depending on whether that succeeds, I'll add `python-pydantic-
...
(https://github.com/bitcoin/bitcoin/issues/32759#issuecomment-3062401151)
I created a branch to debug this: https://github.com/Sjors/bitcoin/commits/2025/07/guix-aarch64-debug/
It starts from https://github.com/bitcoin/bitcoin/commit/c8abd972818f83d90bf50b250131f338034460ef. First it drops `python-tomli` and `lief` and disables the security checks. I run `HOSTS="arm64-apple-darwin" contrib/guix/guix-build` and make it succeeds.
Next I add `python-scikit-build-core` and pretend its needed for `signapple`. Depending on whether that succeeds, I'll add `python-pydantic-
...
💬 maflcko commented on pull request "test: Add and use ElapseTime helper":
(https://github.com/bitcoin/bitcoin/pull/32430#issuecomment-3062402918)
rebased to drop merged commits and included some minimal fixups
(https://github.com/bitcoin/bitcoin/pull/32430#issuecomment-3062402918)
rebased to drop merged commits and included some minimal fixups
📝 duduta opened a pull request: "contrib: Check build options for gen-manpages"
(https://github.com/bitcoin/bitcoin/pull/32949)
This fixes #17506. Let me know what you think.
(https://github.com/bitcoin/bitcoin/pull/32949)
This fixes #17506. Let me know what you think.
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2200811745)
reworded to make it more clear
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2200811745)
reworded to make it more clear
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2200811851)
added
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2200811851)
added
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2200811973)
taken
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2200811973)
taken
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2200818206)
I've edited the number and the comment. I divide the max block weight by an approximate input weight (I chose 200) and make 1 huge transaction. The test has 20k inputs, but I think typical blocks have single digit thousands?
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2200818206)
I've edited the number and the comment. I divide the max block weight by an approximate input weight (I chose 200) and make 1 huge transaction. The test has 20k inputs, but I think typical blocks have single digit thousands?
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2200818690)
reworded, took this as well
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2200818690)
reworded, took this as well
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#issuecomment-3062452789)
> we should probably be calling LimitOrphans after/during AddAnnouncer()
Yes 👍 done.
(https://github.com/bitcoin/bitcoin/pull/31829#issuecomment-3062452789)
> we should probably be calling LimitOrphans after/during AddAnnouncer()
Yes 👍 done.
💬 maflcko commented on pull request "contrib: Check build options for gen-manpages":
(https://github.com/bitcoin/bitcoin/pull/32949#issuecomment-3062458206)
> This fixes #17506. Let me know what you think.
Have you read the issue? It mentions `HAVE_SYSTEM` and others, but they are not checked here.
Is this llm generated?
(https://github.com/bitcoin/bitcoin/pull/32949#issuecomment-3062458206)
> This fixes #17506. Let me know what you think.
Have you read the issue? It mentions `HAVE_SYSTEM` and others, but they are not checked here.
Is this llm generated?
💬 pablomartin4btc commented on pull request "rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs":
(https://github.com/bitcoin/bitcoin/pull/32845#issuecomment-3062460743)
- Fixed functional test `test_no_args_passed()` to avoid CI failure (`multiprocess, i686, DEBUG`) adapting the code to when `CLI` option call is used (`--usecli`).
(https://github.com/bitcoin/bitcoin/pull/32845#issuecomment-3062460743)
- Fixed functional test `test_no_args_passed()` to avoid CI failure (`multiprocess, i686, DEBUG`) adapting the code to when `CLI` option call is used (`--usecli`).
📝 duduta converted_to_draft a pull request: "contrib: Check build options for gen-manpages"
(https://github.com/bitcoin/bitcoin/pull/32949)
This fixes #17506. Let me know what you think.
(https://github.com/bitcoin/bitcoin/pull/32949)
This fixes #17506. Let me know what you think.
💬 hebasto commented on pull request "ci, iwyu: Treat warnings as errors for specific directories":
(https://github.com/bitcoin/bitcoin/pull/31308#issuecomment-3062529488)
Rebased.
@maflcko
Thank you for the review! Your feedback has been addressed.
(https://github.com/bitcoin/bitcoin/pull/31308#issuecomment-3062529488)
Rebased.
@maflcko
Thank you for the review! Your feedback has been addressed.
💬 hebasto commented on pull request "ci, iwyu: Treat warnings as errors for specific directories":
(https://github.com/bitcoin/bitcoin/pull/31308#discussion_r2200869238)
Sure. [Reworked](https://github.com/bitcoin/bitcoin/pull/31308#issuecomment-3062529488).
(https://github.com/bitcoin/bitcoin/pull/31308#discussion_r2200869238)
Sure. [Reworked](https://github.com/bitcoin/bitcoin/pull/31308#issuecomment-3062529488).
💬 hebasto commented on pull request "ci, iwyu: Treat warnings as errors for specific directories":
(https://github.com/bitcoin/bitcoin/pull/31308#discussion_r2200869809)
Thanks! [Updated](https://github.com/bitcoin/bitcoin/pull/31308#issuecomment-3062529488).
(https://github.com/bitcoin/bitcoin/pull/31308#discussion_r2200869809)
Thanks! [Updated](https://github.com/bitcoin/bitcoin/pull/31308#issuecomment-3062529488).
💬 hebasto commented on pull request "ci, iwyu: Treat warnings as errors for specific directories":
(https://github.com/bitcoin/bitcoin/pull/31308#discussion_r2200870356)
Thanks! [Updated](https://github.com/bitcoin/bitcoin/pull/31308#issuecomment-3062529488).
(https://github.com/bitcoin/bitcoin/pull/31308#discussion_r2200870356)
Thanks! [Updated](https://github.com/bitcoin/bitcoin/pull/31308#issuecomment-3062529488).