💬 TheCharlatan commented on pull request "(RFC) kernel: Replace leveldb-based BlockTreeDB with flat-file based store":
(https://github.com/bitcoin/bitcoin/pull/32427#issuecomment-3052676701)
Rebased 98a34dd55ac32f323b297bb6d77eefe096f27074 -> 254d0a75b50b0eaf91003ea8a0534981ec740090 ([blocktreestore_1](https://github.com/TheCharlatan/bitcoin/tree/blocktreestore_1) -> [blocktreestore_2](https://github.com/TheCharlatan/bitcoin/tree/blocktreestore_2), [compare](https://github.com/TheCharlatan/bitcoin/compare/blocktreestore_1..blocktreestore_2))

* Fixed conflict with #32835

💬 maflcko commented on pull request "log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError":
(https://github.com/bitcoin/bitcoin/pull/32604#issuecomment-3052678805)
Looks like the release notes were changed a bit. No other changes.

re-ACK 4c772cbd83e502a1339e8993d192ea6416ecd45c 🕚

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU
...

💬 andrewtoth commented on pull request "coins: remove logic for spent-and-FRESH cache entries and writing non-DIRTY entries":
(https://github.com/bitcoin/bitcoin/pull/30673#discussion_r2195046660)
Done.

💬 andrewtoth commented on pull request "coins: remove logic for spent-and-FRESH cache entries and writing non-DIRTY entries":
(https://github.com/bitcoin/bitcoin/pull/30673#discussion_r2195046932)
Done.

💬 andrewtoth commented on pull request "coins: remove logic for spent-and-FRESH cache entries and writing non-DIRTY entries":
(https://github.com/bitcoin/bitcoin/pull/30673#discussion_r2195047148)
Done.

💬 andrewtoth commented on pull request "coins: remove logic for spent-and-FRESH cache entries and writing non-DIRTY entries":
(https://github.com/bitcoin/bitcoin/pull/30673#discussion_r2195047383)
Done.

💬 andrewtoth commented on pull request "coins: remove logic for spent-and-FRESH cache entries and writing non-DIRTY entries":
(https://github.com/bitcoin/bitcoin/pull/30673#discussion_r2195047659)
Fixed.

💬 andrewtoth commented on pull request "coins: remove logic for spent-and-FRESH cache entries and writing non-DIRTY entries":
(https://github.com/bitcoin/bitcoin/pull/30673#discussion_r2195047855)
Done.

💬 andrewtoth commented on pull request "coins: remove logic for spent-and-FRESH cache entries and writing non-DIRTY entries":
(https://github.com/bitcoin/bitcoin/pull/30673#discussion_r2195053293)
I merged it with https://github.com/bitcoin/bitcoin/pull/30673/commits/aaef2d6c0d801dc48798e9a7d0911c234870412e instead.

💬 andrewtoth commented on pull request "coins: remove logic for spent-and-FRESH cache entries and writing non-DIRTY entries":
(https://github.com/bitcoin/bitcoin/pull/30673#discussion_r2195055066)
That's being done in https://github.com/bitcoin/bitcoin/pull/32602.

💬 TheCharlatan commented on pull request "kernel: Separate UTXO set access from validation functions":
(https://github.com/bitcoin/bitcoin/pull/32317#issuecomment-3052710445)
Rebased 6e90a0eb605b5477b4e91128e08ed1cc5501a939 -> 1f96d1cefc721b579b7aa3b05c2e65df62c0c5cf ([spendblock_7](https://github.com/TheCharlatan/bitcoin/tree/spendblock_7) -> [spendblock_8](https://github.com/TheCharlatan/bitcoin/tree/spendblock_8), [compare](https://github.com/TheCharlatan/bitcoin/compare/spendblock_7..spendblock_8))

* Fixed silent merge conflict with #32850

💬 andrewtoth commented on pull request "coins: remove logic for spent-and-FRESH cache entries and writing non-DIRTY entries":
(https://github.com/bitcoin/bitcoin/pull/30673#issuecomment-3052710531)
@l0rinc rebased. Thank you for your reviews! I have tried to address all your comments. There are some older comments that I'm unsure are still relevant. Please let me know if there is still anything outstanding that needs to be addressed.

💬 Crypt-iQ commented on pull request "log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError":
(https://github.com/bitcoin/bitcoin/pull/32604#discussion_r2195085089)
Will address in follow-up

💬 Crypt-iQ commented on pull request "log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError":
(https://github.com/bitcoin/bitcoin/pull/32604#discussion_r2195085647)
Will address in follow-up to remove `\n` and use `Warning`

💬 Crypt-iQ commented on pull request "log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError":
(https://github.com/bitcoin/bitcoin/pull/32604#discussion_r2195086835)
Will address in follow-up, the comment is confusing as pointed out by @l0rinc

💬 Crypt-iQ commented on pull request "log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError":
(https://github.com/bitcoin/bitcoin/pull/32604#discussion_r2195087287)
Will address in follow-up

💬 TheCharlatan commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-3052764983)
> Made a Java wrapper library for the Java folks out there! https://github.com/yuvicc/java-bitcoinkernel

Cool!

> While playing with the API I also wrote a [benchmarking test](https://github.com/yuvicc/bitcoin/tree/2025-06-kernel_benchmarking) for the script validation using the API vs the internal code just to see the performane overhead

It looks like your benchmark includes serialization in its hot loop, which is not the case for our internal `VerifyScriptBench`. I'd be surprised if th
...

💬 maflcko commented on pull request "mempool: Avoid needless vtx iteration during IBD":
(https://github.com/bitcoin/bitcoin/pull/32827#issuecomment-3052786718)
lgtm ACK 54f9cb85c4be2c30be0eb89f29b76a4cbf6f1c50 🌌

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: lgtm ACK 54f9cb85c4be2c30
...

💬 darosior commented on issue "Enable PCP by default?":
(https://github.com/bitcoin/bitcoin/issues/31663#issuecomment-3052905168)
> A user has reported their router is (probably) incompatible: https://bitcointalk.org/index.php?topic=5538256.msg65285896#msg65285896

I'm not even sure what to record it as on the table. MT-PON-AT-4?

📝 Sjors opened a pull request: "test: add logging to mock signers"
(https://github.com/bitcoin/bitcoin/pull/32928)
This will hopefully aid in debugging #32855.

Because `stdout` and `stderr` are consumed by the node, the mock external signers can't use them for logging.

Instead have them print directly into `test_framework.log`, which can then be be retrieved via `combine_logs.py`.

In preparation (and addtion) this PR starts with a few refactors:

- move `mock_signer_path` helpers to `util` and reuse them between `rpc_signer.py` and `wallet_signer.py`
- move the mocks from `test/functional/mocks`
...