💬 luke-jr commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#discussion_r2193383756)
The null wtxid is already added at the top outside the loop.

💬 luke-jr commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#discussion_r2193403333)
Yes, that's what I forgot.

🤔 glozow reviewed a pull request: "log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError"
(https://github.com/bitcoin/bitcoin/pull/32604#pullrequestreview-2999048711)
lightly reviewed ACK f47e2ea9137c3a832e07d6dd845c55d35d533fa9

💬 glozow commented on pull request "log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError":
(https://github.com/bitcoin/bitcoin/pull/32604#discussion_r2193405519)
Maybe worth adding that "All logs will be prefixed with [*] if there is at least one source location that is currently being suppressed." Somebody who sees a [*] may wonder what that means, and hopefully find that in the release notes.

💬 achow101 commented on pull request "wallet: Prepare for future upgrades by recording versions of last client to open and decrypt":
(https://github.com/bitcoin/bitcoin/pull/32895#issuecomment-3050272556)
I've updated the PR to do a combination of @maflcko's and @ryanofsky's suggestions.

The new approach decouples `version` from CLIENT_VERSION. It also writes out a set of client specific feature flags into two new records: `lastopenedfeatures` and `lastdecryptedfeatures`. However, these feature flags are separate from the existing wallet feature flags.

I believe this preserves the behavior of detecting downgrades down to v24.0, while also giving us the flexibility of a new field and feature
...

💬 luke-jr commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#discussion_r2193445862)
Sorry, mixed that up with `have_witness_proof`.

This is to explicitly specify that the proof is proving the generation tx itself, not just using it to prove the witness root.

💬 pablomartin4btc commented on pull request "rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs":
(https://github.com/bitcoin/bitcoin/pull/32845#issuecomment-3050401651)
<ins>_Updates_</ins>
- Addressed @maflcko's feedback:
- [dropped](https://github.com/bitcoin/bitcoin/pull/32845#discussion_r2191837500) `MaybeArg` extension commit, since a pointer already can hold the null state needed in the validations within the `GetWalletNameFromJSONRPCRequest` overload;
- removed previously added `AreParamsNullOrEmpty` and replaced it with std::ranges::all_of in the `getdescriptoractivity` RPC fix instead, as [suggested](https://github.com/bitcoin/bitcoin/pull/32845
...

💬 mzumsande commented on pull request "index: Fix coinstats overflow":
(https://github.com/bitcoin/bitcoin/pull/30469#discussion_r2193512334)
FYI test fails because of some windows path-printing isues.

🤔 mzumsande reviewed a pull request: "index: Fix coinstats overflow"
(https://github.com/bitcoin/bitcoin/pull/30469#pullrequestreview-2998999955)
nit: cummulative -> cumulative in PR description

Looks good to me besides the nits.

This will also need a release note, warning users that existing indexes will be resynced, which will probably take a few days for mainnet.

💬 mzumsande commented on pull request "index: Fix coinstats overflow":
(https://github.com/bitcoin/bitcoin/pull/30469#discussion_r2193373429)
it's commented out, but could also update line 131 above.
Also, `doc/files.md` should be updated.

🤔 furszy reviewed a pull request: "rpc, test: Fix JSON parsing errors in unloadwallet and getdescriptoractivity RPCs"
(https://github.com/bitcoin/bitcoin/pull/32845#pullrequestreview-2999282057)
utACK 529d2ce24570aae426ce19e87cb22f124dd09470

📝 marbcGH opened a pull request: "feature:automatically include the elapsed time in logging"
(https://github.com/bitcoin/bitcoin/pull/32925)
Simple, minimal change to improve logging by including the elapsed time in the "completed" log message even when `msg_on_completion` is set to true. Motivation is to contribute, and improve Bitcoin Core user experience & Bitcoin Core developer experience with a simple log modification.

Current log outputs:
```
LoadBlockIndex completed
```
---

After modification log output:
```
LoadBlockIndex: LoadBlockIndex completed (452.87ms)
```

Current state doesn't include how long the oper
...

📝 Mhwd9-9 opened a pull request: "Create main.yml"
(https://github.com/bitcoin/bitcoin/pull/32926)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 Mhwd9-9 commented on pull request "Create main.yml":
(https://github.com/bitcoin/bitcoin/pull/32926#issuecomment-3050994860)
از ccefe54ccd79f690192cb918ad28359b8ed574f6 دوشنبه ۱۷ سپتامبر ۲۰۰۱ ساعت ۰۰:۰۰:۰۰
از: Mhwd9-9 <152965735+Mhwd9-9@users.noreply.github.com>
تاریخ: چهارشنبه، ۹ ژوئیه ۲۰۲۵ ۰۷:۰۳:۲۱ +۰۳۳۰
موضوع: [PATCH] ایجاد main.yml

---
‎.github/workflows/main.yml | ۱ +
۱ فایل تغییر کرد، ۱ درج انجام شد(+)
ایجاد حالت ۱۰۰۶۴۴ .github/workflows/main.yml

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
حالت فایل جدید ۱۰۰۶۴۴
فهرست ۰۰۰۰۰۰۰۰۰۰۰۰۰..۹۷۵fbec۸۲۵۶d۳
--- /dev/null
++b/.gith
...

💬 Mhwd9-9 commented on pull request "Create main.yml":
(https://github.com/bitcoin/bitcoin/pull/32926#issuecomment-3050995207)
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
حالت فایل جدید ۱۰۰۶۴۴
فهرست ۰۰۰۰۰۰۰۰۰۰۰۰۰..۹۷۵fbec۸۲۵۶d۳
--- /dev/null
++b/.github/workflows/main.yml
@@ -0,0 +1 @@
+ی

💬 luke-jr commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#discussion_r2193944030)
Renamed to `gentx` (the coinbase is the input only)

👋 luke-jr's pull request is ready for review: "RPC/txoutproof: Support including (and verifying) proofs of wtxid"
(https://github.com/bitcoin/bitcoin/pull/32844)

💬 luke-jr commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#issuecomment-3051020524)
Reworked this to cover @SomberNight 's requirements and address feedback. Test is now passing.

💬 Mhwd9-9 commented on pull request "Create main.yml":
(https://github.com/bitcoin/bitcoin/pull/32926#issuecomment-3051026881)
من

On چهارشنبه ۹ ژوئیه ۲۰۲۵، ۷:۰۴ DrahtBot ***@***.***> wrote:

> *DrahtBot* left a comment (bitcoin/bitcoin#32926)
> <https://github.com/bitcoin/bitcoin/pull/32926#issuecomment-3050994217>
>
> The following sections might be updated with supplementary metadata
> relevant to reviewers and maintainers.
> Code Coverage & Benchmarks
>
> For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32926.
> Reviews
>
> See the guideline
> <https://github.com/bitcoin/bitcoin/blob/maste
...

✅ maflcko closed a pull request: "feature:automatically include the elapsed time in logging"
(https://github.com/bitcoin/bitcoin/pull/32925)