💬 luke-jr commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#discussion_r2190896199)
This is just a move, so seems out of scope
(https://github.com/bitcoin/bitcoin/pull/32844#discussion_r2190896199)
This is just a move, so seems out of scope
💬 luke-jr commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#discussion_r2190899759)
An attempt to have a somewhat optional extension, but given the need to prove wtxid for non-witness txs, maybe not the best approach.
(https://github.com/bitcoin/bitcoin/pull/32844#discussion_r2190899759)
An attempt to have a somewhat optional extension, but given the need to prove wtxid for non-witness txs, maybe not the best approach.
📝 achow101 opened a pull request: "wallet: Prepare for future upgrades by recording versions of last client to open and decrypt"
(https://github.com/bitcoin/bitcoin/pull/32895)
When a wallet is automatically upgraded, we always do so in a way that allows the user to load their wallet in an older version. When the user loads their wallet into an upgraded version again, the wallet may not perform the automatic upgrade and end up with upgraded and non-upgraded material in the wallet.
If we write the version of the last client to open the wallet, we would be able to detect these upgrade-downgrade-upgrade situations and perform another upgrade if so. However, in order fo
...
(https://github.com/bitcoin/bitcoin/pull/32895)
When a wallet is automatically upgraded, we always do so in a way that allows the user to load their wallet in an older version. When the user loads their wallet into an upgraded version again, the wallet may not perform the automatic upgrade and end up with upgraded and non-upgraded material in the wallet.
If we write the version of the last client to open the wallet, we would be able to detect these upgrade-downgrade-upgrade situations and perform another upgrade if so. However, in order fo
...
📝 ishaanam opened a pull request: "wallet, rpc: add v3 transaction creation and wallet support"
(https://github.com/bitcoin/bitcoin/pull/32896)
This PR Implements the following:
- If creating a v3 transaction, `AvailableCoins` doesn't return unconfirmed v2 utxos (and vice versa)
- `AvailableCoins` doesn't return an unconfirmed v3 utxo if its transaction already has a child
- If a v3 transaction is kicked out of the mempool by a sibling, mark the sibling as a mempool conflict
- Throw an error if pre-selected inputs are of the wrong transaction version
- Allow setting version to 3 manually in `createrawtransaction` (uses commits from
...
(https://github.com/bitcoin/bitcoin/pull/32896)
This PR Implements the following:
- If creating a v3 transaction, `AvailableCoins` doesn't return unconfirmed v2 utxos (and vice versa)
- `AvailableCoins` doesn't return an unconfirmed v3 utxo if its transaction already has a child
- If a v3 transaction is kicked out of the mempool by a sibling, mark the sibling as a mempool conflict
- Throw an error if pre-selected inputs are of the wrong transaction version
- Allow setting version to 3 manually in `createrawtransaction` (uses commits from
...
🚀 glozow merged a pull request: "cluster mempool: add TxGraph reorg functionality"
(https://github.com/bitcoin/bitcoin/pull/31553)
(https://github.com/bitcoin/bitcoin/pull/31553)
⚠️ davidtaubmann opened an issue: "Bitcoin Px (Fork focused on Persons, remove institutions)"
(https://github.com/bitcoin/bitcoin/issues/32897)
### Please describe the feature you'd like to see added.
In this new fork, only one wallet could be created for each physical persona, probably using a proof like the national identity number "[NIN](https://en.wikipedia.org/wiki/National_identification_number)" (e.g.: US+SSN, MX+CURP, etc.), and getting sure it's a living person (not yet registered as death).
To be able to carry out transactions with institutions, this could be done, through decentralized exchanges (DEXs).
To perform the for
...
(https://github.com/bitcoin/bitcoin/issues/32897)
### Please describe the feature you'd like to see added.
In this new fork, only one wallet could be created for each physical persona, probably using a proof like the national identity number "[NIN](https://en.wikipedia.org/wiki/National_identification_number)" (e.g.: US+SSN, MX+CURP, etc.), and getting sure it's a living person (not yet registered as death).
To be able to carry out transactions with institutions, this could be done, through decentralized exchanges (DEXs).
To perform the for
...
✅ pinheadmz closed an issue: "Bitcoin Px (Fork focused on Persons, remove institutions)"
(https://github.com/bitcoin/bitcoin/issues/32897)
(https://github.com/bitcoin/bitcoin/issues/32897)
💬 pinheadmz commented on issue "Bitcoin Px (Fork focused on Persons, remove institutions)":
(https://github.com/bitcoin/bitcoin/issues/32897#issuecomment-3046418540)
This belongs on the Bitcoin dev mailing list or maybe delving Bitcoin, not the issue tracker for this software project.
(https://github.com/bitcoin/bitcoin/issues/32897#issuecomment-3046418540)
This belongs on the Bitcoin dev mailing list or maybe delving Bitcoin, not the issue tracker for this software project.
💬 glozow commented on pull request "rpc: use anti-fee-sniping in send, sendall and walletcreatefundedpsbt":
(https://github.com/bitcoin/bitcoin/pull/32892#issuecomment-3046428650)
Any chance this is a duplicate of #28944?
(https://github.com/bitcoin/bitcoin/pull/32892#issuecomment-3046428650)
Any chance this is a duplicate of #28944?
🚀 glozow merged a pull request: "wallet: Remove ISMINE_WATCHONLY and watchonly from RPCs"
(https://github.com/bitcoin/bitcoin/pull/32618)
(https://github.com/bitcoin/bitcoin/pull/32618)
💬 luke-jr commented on pull request "cmake: Use `AUTHOR_WARNING` for warnings":
(https://github.com/bitcoin/bitcoin/pull/32865#issuecomment-3046447987)
Concept NACK: These warnings don't appear to be just for developers, but also relevant to builders.
(https://github.com/bitcoin/bitcoin/pull/32865#issuecomment-3046447987)
Concept NACK: These warnings don't appear to be just for developers, but also relevant to builders.
🚀 glozow merged a pull request: "test: refactor out same-txid-diff-wtxid tx to reuse in other tests"
(https://github.com/bitcoin/bitcoin/pull/32385)
(https://github.com/bitcoin/bitcoin/pull/32385)
💬 luke-jr commented on pull request "ci: Catch tests corrupting the source directory":
(https://github.com/bitcoin/bitcoin/pull/32874#issuecomment-3046462509)
Better not to trust CI to do a security audit for you...
One benefit of CMake is that you can build as another user without write access to the source dir (or indeed, in an isolated container).
(https://github.com/bitcoin/bitcoin/pull/32874#issuecomment-3046462509)
Better not to trust CI to do a security audit for you...
One benefit of CMake is that you can build as another user without write access to the source dir (or indeed, in an isolated container).
📝 ryanofsky opened a pull request: "POC: IPC tracing interface"
(https://github.com/bitcoin/bitcoin/pull/32898)
This a is proof-of-concept adding an IPC interface for tracing as discussed in https://github.com/bitcoin-core/libmultiprocess/issues/185. As mentioned there, this is a naive implementation that would need to be optimized to have good performance, but it does show an end-to-end demo of how tracing could work using IPC.
The can be tested by building with `-DENABLE_IPC=ON` and running:
```bash
build/bin/bitcoin-node -regtest -ipcbind=unix # Start node listening on IPC socket
build/bin/bit
...
(https://github.com/bitcoin/bitcoin/pull/32898)
This a is proof-of-concept adding an IPC interface for tracing as discussed in https://github.com/bitcoin-core/libmultiprocess/issues/185. As mentioned there, this is a naive implementation that would need to be optimized to have good performance, but it does show an end-to-end demo of how tracing could work using IPC.
The can be tested by building with `-DENABLE_IPC=ON` and running:
```bash
build/bin/bitcoin-node -regtest -ipcbind=unix # Start node listening on IPC socket
build/bin/bit
...
💬 fanquake commented on pull request "cmake: Use `AUTHOR_WARNING` for warnings":
(https://github.com/bitcoin/bitcoin/pull/32865#issuecomment-3046485662)
> Concept NACK: These warnings don't appear to be just for developers, but also relevant to builders.
Not sure I understand your NACK. The warnings will still be shown to builders; using `AUTHOR_WARNING` just gives us a proper mechanism to turn warnings into errors.
(https://github.com/bitcoin/bitcoin/pull/32865#issuecomment-3046485662)
> Concept NACK: These warnings don't appear to be just for developers, but also relevant to builders.
Not sure I understand your NACK. The warnings will still be shown to builders; using `AUTHOR_WARNING` just gives us a proper mechanism to turn warnings into errors.
📝 ryanofsky converted_to_draft a pull request: "POC: IPC tracing interface"
(https://github.com/bitcoin/bitcoin/pull/32898)
This a is proof-of-concept adding an IPC interface for tracing as discussed in https://github.com/bitcoin-core/libmultiprocess/issues/185. As mentioned there, this is a naive implementation that would need to be optimized to have good performance, but it does show an end-to-end demo of how tracing could work using IPC.
The can be tested by building with `-DENABLE_IPC=ON` and running:
```bash
build/bin/bitcoin-node -regtest -ipcbind=unix # Start node listening on IPC socket
build/bin/bit
...
(https://github.com/bitcoin/bitcoin/pull/32898)
This a is proof-of-concept adding an IPC interface for tracing as discussed in https://github.com/bitcoin-core/libmultiprocess/issues/185. As mentioned there, this is a naive implementation that would need to be optimized to have good performance, but it does show an end-to-end demo of how tracing could work using IPC.
The can be tested by building with `-DENABLE_IPC=ON` and running:
```bash
build/bin/bitcoin-node -regtest -ipcbind=unix # Start node listening on IPC socket
build/bin/bit
...
💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#issuecomment-3046495307)
Each transaction now counts as `1 + num_inputs / 10` announcements, accounting for the additional time it takes to do `m_outpoint_to_orphan_it` operations (benchmarks suggest it's roughly 1/10th of the time to do `m_orphans` operations). We round down so that the first 9 inputs are "free" and most normal transactions don't get a "penalty". This means a 9-input transaction has the highest computation time / latency score, which is why the benchmarks use them.
A few pushes ago I changed the lim
...
(https://github.com/bitcoin/bitcoin/pull/31829#issuecomment-3046495307)
Each transaction now counts as `1 + num_inputs / 10` announcements, accounting for the additional time it takes to do `m_outpoint_to_orphan_it` operations (benchmarks suggest it's roughly 1/10th of the time to do `m_orphans` operations). We round down so that the first 9 inputs are "free" and most normal transactions don't get a "penalty". This means a 9-input transaction has the highest computation time / latency score, which is why the benchmarks use them.
A few pushes ago I changed the lim
...
💬 murchandamus commented on pull request "[WIP] wallet: tx creation, don't select outputs from txes that are being replaced":
(https://github.com/bitcoin/bitcoin/pull/26732#issuecomment-3046495601)
@furszy: #27286 was merged, in case this is still relevant.
(https://github.com/bitcoin/bitcoin/pull/26732#issuecomment-3046495601)
@furszy: #27286 was merged, in case this is still relevant.
💬 luke-jr commented on pull request "index: Fix missing case in the comment in NextSyncBlock()":
(https://github.com/bitcoin/bitcoin/pull/32875#issuecomment-3046501091)
```c++
CBlockIndex* NextInclRewind(const CBlockIndex* pindex) const
{
if (!Contains(Assert(pindex))) {
pindex = Assert(FindFork(pindex));
}
return (*this)[pindex->nHeight + 1];
}
```
(https://github.com/bitcoin/bitcoin/pull/32875#issuecomment-3046501091)
```c++
CBlockIndex* NextInclRewind(const CBlockIndex* pindex) const
{
if (!Contains(Assert(pindex))) {
pindex = Assert(FindFork(pindex));
}
return (*this)[pindex->nHeight + 1];
}
```
💬 luke-jr commented on pull request "index: fix wrong assert of current_tip == m_best_block_index":
(https://github.com/bitcoin/bitcoin/pull/32878#issuecomment-3046511372)
The test should probably be added to the PR after the commit fixing it
(https://github.com/bitcoin/bitcoin/pull/32878#issuecomment-3046511372)
The test should probably be added to the PR after the commit fixing it