📝 MarcoFalke opened a pull request: "test: Disable legacy wallet for mempool_packages.py"
(https://github.com/bitcoin/bitcoin/pull/27735)
This fixes a bug.

On master:

```
$ ./test/functional/mempool_packages.py --legacy-wallet
File "./test/functional/mempool_packages.py", line 52, in run_test
self.nodes[0].importaddress(self.wallet.get_address())
test_framework.authproxy.JSONRPCException: Bech32m addresses cannot be imported into legacy wallets (-5)
```

On this pull:

```
$ ./test/functional/mempool_packages.py --legacy-wallet
usage: mempool_packages.py [options]
mempool_packages.py: error: unrecognize
...

💬 MarcoFalke commented on pull request "test: Disable legacy wallet for mempool_packages.py":
(https://github.com/bitcoin/bitcoin/pull/27735#issuecomment-1560544086)
(An alternative to test this would be to compile with bdb only)

💬 MarcoFalke commented on issue "Intermittent failures in interface_usdt_mempool.py":
(https://github.com/bitcoin/bitcoin/issues/27380#issuecomment-1560583591)
https://cirrus-ci.com/task/6382990889058304?logs=ci#L3266

💬 fjahr commented on pull request "init: Improve file descriptor limit handling":
(https://github.com/bitcoin/bitcoin/pull/27730#issuecomment-1560647386)
> Duplicate of #27539?

Ugh, mostly yeah.

✅ fjahr closed a pull request: "init: Improve file descriptor limit handling"
(https://github.com/bitcoin/bitcoin/pull/27730)

🤔 fjahr reviewed a pull request: "init: Fixes for file descriptor accounting"
(https://github.com/bitcoin/bitcoin/pull/27539#pullrequestreview-1441209058)
Concept ACK

I think it would be very helpful to add comments to explain what is going on. See my accidentally duplicate PR for some suggestions: #27730.

💬 fjahr commented on pull request "init: Fixes for file descriptor accounting":
(https://github.com/bitcoin/bitcoin/pull/27539#discussion_r1203666492)
Needs an explanation of why it is ok to take `FD_SETSIZE` completely out of the equation in the commit description.

🚀 fanquake merged a pull request: "Parallel compact block downloads, take 3"
(https://github.com/bitcoin/bitcoin/pull/27626)

✅ fanquake closed an issue: "Parallel compact block download"
(https://github.com/bitcoin/bitcoin/issues/25258)

💬 MarcoFalke commented on issue "index: ThreadSanitizer: data race on vptr ":
(https://github.com/bitcoin/bitcoin/issues/27355#issuecomment-1560737121)
> Not really a fix if there is something else going on but.. could use [furszy@8495c85](https://github.com/furszy/bitcoin-core/commit/8495c852ebe199a96a4e205937861b76f54227eb) (quick and dirty) to remove the active-wait timeout error.

Mind opening a pull so that it can be reviewed and tested?

Review note: I don't think you need to embed the exception into the promise. A thread (re-)throwing into void will lead to immediate abort anyway. It should be sufficient to replace `[this] { ThreadSy
...

💬 MarcoFalke commented on issue "index: ThreadSanitizer: data race on vptr ":
(https://github.com/bitcoin/bitcoin/issues/27355#issuecomment-1560738959)
To reproduce locally, one can try to build with tsan, then run the functional tests in the background to eat all available CPU, then run the failing test case in the foreground in a loop until it fails.

💬 fanquake commented on issue "Notes on Block-In-Flight Handling":
(https://github.com/bitcoin/bitcoin/issues/16172#issuecomment-1560740198)
cc @instagibbs

⚠️ ismaelsadeeq opened an issue: "25.0 RC Testing Guide Feedback"
(https://github.com/bitcoin/bitcoin/issues/27736)
This issue is to discuss the [25.0 Release Candidate Testing Guide](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/25.0-Release-Candidate-Testing-Guide). If you have any issues with or feedback on the document, please leave a comment here.

Note: this is for feedback on the document, not on Bitcoin Core or on the 23.0 changes. Please see the [#27621](https://github.com/bitcoin/bitcoin/issues/27621) for instructions on how to report bug/results.

Thank you for your feedback

💬 ismaelsadeeq commented on issue "v25.0 testing":
(https://github.com/bitcoin/bitcoin/issues/27621#issuecomment-1560749074)
@chippsmith Thanks for your testing effort.
@schjonhaug Thank You for your feedback, I will update the document.
For all feedback on the testing guide document please drop it here [#27736](https://github.com/bitcoin/bitcoin/issues/27736)

💬 Sjors commented on pull request "Improve display address handling for external signer":
(https://github.com/bitcoin/bitcoin/pull/24313#discussion_r1203781715)
Done

💬 fanquake commented on pull request "ci: standardize custom libc++ usage in MSAN jobs":
(https://github.com/bitcoin/bitcoin/pull/27485#issuecomment-1560813759)
Going to open a new PR with more extensive changes.

✅ fanquake closed a pull request: "ci: standardize custom libc++ usage in MSAN jobs"
(https://github.com/bitcoin/bitcoin/pull/27485)

💬 willcl-ark commented on pull request "Prevent file descriptor exhaustion from too many RPC calls":
(https://github.com/bitcoin/bitcoin/pull/27731#discussion_r1203840774)
I am not sure this actually limits us within the file descriptor limit. For example if you run:

```bash
$ ulimit -n 175
$ src/bitcoind
Warning: Reducing -maxconnections from 125 to 15, because of system limitations.
Bitcoin Core starting
```

I think (but have not tested) that if I then recieve 15 inbound connections I would could still run out of file descriptors for the http server?

Perhaps if we also modify this line:

https://github.com/bitcoin/bitcoin/blob/51c050787fd6bcd0169
...

🤔 theStack reviewed a pull request: "25.0 Final Changes"
(https://github.com/bitcoin/bitcoin/pull/27686#pullrequestreview-1441464565)
Release notes for the new `scanblocks` RPC (https://github.com/bitcoin/bitcoin/pull/23549) are currently missing, could take what @kouloumos prepared in the wiki: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/scanblocks-RPC-release-notes (https://github.com/bitcoin/bitcoin/pull/23549#issuecomment-1277753723).

📝 fanquake opened a pull request: "ci: compile Clang and compiler-rt in msan jobs"
(https://github.com/bitcoin/bitcoin/pull/27737)
This reworks the MSAN CIs, to first compile Clang and compiler-rt (using GCC 12), and then, compile an MSAN instrumented libc++ using the just-built Clang 16. This fixes the `native_fuzz_with_msan` job, working around https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1005341, by not using the Debian provided Clang/LLVM.

Also included are changes to streamline how we use our "custom libc++", according to upstream: https://releases.llvm.org/16.0.0/projects/libcxx/docs/UsingLibcxx.html#using-a-c
...