💬 fanquake commented on pull request "bench: reduces unnecessary big vector definition":
(https://github.com/bitcoin/bitcoin/pull/32787#issuecomment-3027858492)
Going to close this for now. Someone could open a new PR, adding an explanatory comment to the code here.

✅ hebasto closed a pull request: "cmake, qt: Process `*.qrc` files manually"
(https://github.com/bitcoin/bitcoin/pull/32648)

💬 fanquake commented on pull request "rpc: distinguish between vsize and sigop-adjusted mempool vsize":
(https://github.com/bitcoin/bitcoin/pull/27591#issuecomment-3027867903)
This was picked up in #32800.

💬 fanquake commented on pull request "descriptors: Allow `H` as a hardened indicator":
(https://github.com/bitcoin/bitcoin/pull/32788#issuecomment-3027872200)
Moved this to draft for now, given https://github.com/bitcoin/bips/pull/1888.

📝 fanquake converted_to_draft a pull request: "descriptors: Allow `H` as a hardened indicator"
(https://github.com/bitcoin/bitcoin/pull/32788)
BIP 380 states that `H` is a valid hardened indicator.

💬 maflcko commented on pull request "doc: Add note for building on macOS (Intel) with CMake ≥ 4.0":
(https://github.com/bitcoin/bitcoin/pull/32289#issuecomment-3027873189)
apple will support intel machines for another three years, but this is just a warning, so should be fine to leave as-is?

💬 luke-jr commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2180035747)
That's not what's in the current BIP, nor what is implemented here...

💬 instagibbs commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2180069882)
when the script is executed*?

📝 fanquake converted_to_draft a pull request: "Musig2 tests"
(https://github.com/bitcoin/bitcoin/pull/32724)
Built on https://github.com/bitcoin/bitcoin/pull/31244

This PR adds explicit tests for Bitcoin Core's MuSig2 interface.

Any issues in musig2.{cpp,h} will likely also be caught by the descriptor tests, but having more detailed tests for the MuSig2 class itself improves test reporting/coverage.

It uses BIP 328 test vectors.

💬 GregTonoski commented on issue "bitcoind shouldn't fail to progress with synchronization: endless [leveldb] Generated table ... logs":
(https://github.com/bitcoin/bitcoin/issues/31882#issuecomment-3027906134)
> To answer your question, I...

Is there the answer?


> So far I don't see an obvious performance issue as the inital block downloads typically finishes within 70 minutes with **debug=0**, which matches your original expectation.

I disagree, because my expectation was not shorter IBD (better performance) on much faster hardware.

We can have a debug session together and I can help reproducing the issue, profiling or debugging on your environment.

💬 fanquake commented on pull request "ci: update pwsh to use custom shell that fails-fast":
(https://github.com/bitcoin/bitcoin/pull/32672#issuecomment-3027913283)
cc @hebasto @hodlinator @davidgumberg for Concept ACK / NACK.

✅ hebasto closed a pull request: "doc: Add note for building on macOS (Intel) with CMake ≥ 4.0"
(https://github.com/bitcoin/bitcoin/pull/32289)

💬 hebasto commented on pull request "doc: Add note for building on macOS (Intel) with CMake ≥ 4.0":
(https://github.com/bitcoin/bitcoin/pull/32289#issuecomment-3027918074)
The issue has been [fixed](https://cmake.org/cmake/help/latest/release/4.0.html#id2) in CMake 4.0.2.

Closing.

✅ hebasto closed a pull request: "refactor: Drop unused `#include <boost/operators.hpp>`"
(https://github.com/bitcoin/bitcoin/pull/32668)

💬 bigshiny90 commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#issuecomment-3027932624)
@SomberNight @luke-jr

I'm redoing this comment showing the proposed code changes, which are based on @SomberNight's comments. I'm not sure IF these are all the fixes needed, just making the changes based on the comments so far. Let me know if anyone wants this branch pushed for the PR.

## Changes:

### 1. Fixed witness commitment verification in `src/rpc/txoutproof.cpp`

```cpp
// In verifytxoutproof RPC, around line 220
const auto wtxids = [&]() -> std::unordered_map<unsigned int, uint256> {
...

📝 fanquake converted_to_draft a pull request: "fee estimate test: fix #31944 by handling a legitimate scenario that …"
(https://github.com/bitcoin/bitcoin/pull/32615)
Fix a legitimate scenario that feerate is not always available, due to the randomly generated fees that causes current percentage to be smaller than success break point, in TxConfirmStats::EstimateMedianVal (in src/policy/fees.cpp). The solution is to hard code a list of fees that guarantee to pass the check of fees and smart fees.

To reproduce/validate the issue, run the test with a specific randomseed: 2986529890161488286

build/test/functional/test_runner.py test/functional/feature_fee_
...

💬 fanquake commented on pull request "fee estimate test: fix #31944 by handling a legitimate scenario that …":
(https://github.com/bitcoin/bitcoin/pull/32615#issuecomment-3027935606)
@tnndbtc I've moved this to draft, as we aren't going to merge this with the current approach, using the generated `global_fee_list`.

💬 darosior commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2180101377)
Yeah it's just a typo when/where:
```suggestion
// Unlike the existing block wide sigop limit, BIP54 counts sigops where they are actually executed.
```

💬 darosior commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2180103816)
Done, thanks for spotting the typo.

💬 hodlinator commented on pull request "ci: update pwsh to use custom shell that fails-fast":
(https://github.com/bitcoin/bitcoin/pull/32672#issuecomment-3027942199)
Concept ACK (but my PowerShell skill is 0).

@fanquake you are currently registered as a N-A-C-K.