💬 achow101 commented on pull request "doc: Add fetching single PRs from upstream to productivity.md":
(https://github.com/bitcoin/bitcoin/pull/32783#issuecomment-3021366309)
ACK 45b1d39757668939b03b27401c324a938ef0cd8d

🚀 achow101 merged a pull request: "doc: Add fetching single PRs from upstream to productivity.md"
(https://github.com/bitcoin/bitcoin/pull/32783)

💬 bigshiny90 commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#issuecomment-3021534956)
> @SomberNight hmm.. like this?
>
> Here's the fix needed in `src/rpc/txoutproof.cpp` in the `verifytxoutproof` function after line 220:
>
> ```c++
> const auto wtxid_root = merkleBlock.m_wtxid_tree.ExtractMatches(wtxid_matches, wtxid_indexes);
>
> // Extract witness nonce from coinbase input
> if (merkleBlock.m_gentx->vin.empty() || merkleBlock.m_gentx->vin[0].scriptWitness.stack.empty()) {
> return {};
> }
> const auto& witness_nonce = merkleBlock.m_gentx->vin[0].scriptWitnes
...

💬 bigshiny90 commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#discussion_r2176303594)
@SomberNight hmm.. like this?

Here's the fix needed in `src/rpc/txoutproof.cpp` in the `verifytxoutproof` function after line 220:

```cpp
const auto wtxid_root = merkleBlock.m_wtxid_tree.ExtractMatches(wtxid_matches, wtxid_indexes);

// Extract witness nonce from coinbase input
if (merkleBlock.m_gentx->vin.empty() || merkleBlock.m_gentx->vin[0].scriptWitness.stack.empty()) {
return {};
}
const auto& witness_nonce = merkleBlock.m_gentx->vin[0].scriptWitness.stack[0];
if (witness
...

🤔 ryanofsky reviewed a pull request: "ipc: Handle unclean shutdowns better"
(https://github.com/bitcoin/bitcoin/pull/32345#pullrequestreview-2973346180)
Rebased 3ed3f7f979fb8e4cf3023deb64acf9b0a545057a -> 5024f552924b214fa8a092c1daf9acf92a4c40f0 ([`pr/ipc-stop.11`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-stop.11) -> [`pr/ipc-stop.12`](https://github.com/ryanofsky/bitcoin/commits/pr/ipc-stop.12), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/ipc-stop.11-rebase..pr/ipc-stop.12)) with update to fix tidy errors and try to incorporate https://github.com/bitcoin-core/libmultiprocess/pull/186

Will mark as a draft since this n
...

💬 ryanofsky commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2176329943)
re: https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2171026682

> CI on [Sjors#90 (comment)](https://github.com/Sjors/bitcoin/pull/90#issuecomment-3011857912) complains of an unused result. Which is odd because the `(void)` cast should prevent such a warning. This seems to be a gcc thing: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425

Thanks! I tried to work around this by adding a `!` though reading gcc issue maybe that will not be sufficient.

💬 ryanofsky commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2176327196)
re: https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2171082503

> `<csignal>`

Thanks, fixed

📝 ryanofsky converted_to_draft a pull request: "ipc: Handle unclean shutdowns better"
(https://github.com/bitcoin/bitcoin/pull/32345)
This PR fixes various problems when IPC connections are broken or hang which were reported in https://github.com/bitcoin-core/libmultiprocess/issues/123, https://github.com/bitcoin-core/libmultiprocess/issues/176, and https://github.com/bitcoin-core/libmultiprocess/pull/182. The different fixes are described in commit messages.

---

The first two commits of this PR update the libmultiprocess subtree including the following PRs:

- https://github.com/bitcoin-core/libmultiprocess/pull/181

...

💬 bigshiny90 commented on pull request "RPC/txoutproof: Support including (and verifying) proofs of wtxid":
(https://github.com/bitcoin/bitcoin/pull/32844#issuecomment-3021687570)
@SomberNight

Compilation of potential fixes for PR #32844:

## 1. Witness nonce issue
The witness commitment wasn't being calculated correctly. Added in `src/rpc/txoutproof.cpp`:

First, add required includes at the top:
```cpp
#include <hash.h>
#include <logging.h>
```

Then after line 220:

```cpp
const auto wtxid_root = merkleBlock.m_wtxid_tree.ExtractMatches(wtxid_matches, wtxid_indexes);

// Extract witness nonce from coinbase input
if (merkleBlock.m_gentx->vin.empty() || merkleBlock.m_ge
...

🤔 yuvicc reviewed a pull request: "test: Fix wait_for_getheaders() call in test_outbound_eviction_blocks_relay_only()"
(https://github.com/bitcoin/bitcoin/pull/32823#pullrequestreview-2973475932)
ACK ec004cdb86e6471915e1033f390c76ee0428e415

- some comments has been updated to maintain readability
- update `wait_for_getheader` to use `rehash()` for robust testing

💬 maflcko commented on pull request "doc: add `/spenttxouts` to REST-interface.md":
(https://github.com/bitcoin/bitcoin/pull/32842#issuecomment-3021867622)
lgtm ACK dd99cedc0bfe7d7eee0f543bb27dab005c426c66

💬 maflcko commented on pull request "mempool: Avoid needless vtx iteration during IBD":
(https://github.com/bitcoin/bitcoin/pull/32827#discussion_r2176475573)
Yeah, not sure. It would be good to see some flamegraphs or IBD speedup, to see what matters?

💬 davidgumberg commented on pull request "wallet: Fix relative path backup during migration.":
(https://github.com/bitcoin/bitcoin/pull/32273#issuecomment-3022237757)
> Won't this turn `/home/user/arbitrarywalletname.db` into `/home/user/user_%d.legacy.bak` ? Seems incorrect?

> This PR currently breaks that. Although `test_direct_file` doesn't currently fail, adding a check for the wallet's name in the backup path does make it fail, e.g.
>
> [...]

@luke-jr @achow101
Thanks for catching this, I've added the test case @achow101 suggested for this in 5cd3e2794d78848e7040e.

----

@ryanofsky
> Following would seem to be a good fix:
>
> [...]

...

📝 bigspider opened a pull request: "doc: clarify that the "-j N" goes after the "--build build" part"
(https://github.com/bitcoin/bitcoin/pull/32846)
I was surprised that something like `cmake -j 4 --build build` doesn't work, so this might help others to not make the same mistake.

💬 Sjors commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2176634257)
Maybe comment that the `!` is for gcc

💬 maflcko commented on pull request "doc: clarify that the "-j N" goes after the "--build build" part":
(https://github.com/bitcoin/bitcoin/pull/32846#issuecomment-3022289027)
lgtm ACK 69f3b2039147558f5c9b452016ab980930e85222

💬 Sjors commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2176648523)
Ok, we'll find out, if CI passes in the latest https://github.com/Sjors/bitcoin/pull/90

🤔 BrandonOdiwuor reviewed a pull request: "wallet: Remove ISMINE_WATCHONLY and watchonly from RPCs"
(https://github.com/bitcoin/bitcoin/pull/32618#pullrequestreview-2974133938)
Tested ACK 003a3cdb29dcc1e3e1a53f8227de73389071fbd1

Confirmed that all watch-only related functionality has been removed from the wallet and relevant RPCs, in line with the deprecation of legacy wallets.

- Verified that watch only has been removed from balances and `getbalance` RPC.
- Tested that `include_watchonly` option and `iswatchonly` flag was removed from all RPCs including `getaddressinfo`, `fundrawtransaction`, `send`, `sendall`, `walletcreatefundedpsbt`, `listreceivedbyaddress`
...

🚀 fanquake merged a pull request: "doc: add `/spenttxouts` to REST-interface.md"
(https://github.com/bitcoin/bitcoin/pull/32842)

🚀 fanquake merged a pull request: "contrib: correct variable name in p2p_monitor.py"
(https://github.com/bitcoin/bitcoin/pull/32816)