💬 instagibbs commented on pull request "[WIP] Cluster mempool implementation":
(https://github.com/bitcoin/bitcoin/pull/28676#issuecomment-3019599266)
@dergoegge awesome coverage and functional test!

Seems this is the issue, we are `visit`ing children erroneously disallowing their removal later when parent is `visit`ed for immaturity:
```
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
index 5c90bc43dd..3c278f6aad 100644
--- a/src/txmempool.cpp
+++ b/src/txmempool.cpp
@@ -362,5 +362,5 @@ void CTxMemPool::removeForReorg(CChain& chain, std::function<bool(txiter)> check
WITH_FRESH_EPOCH(m_epoch);
for (indexed_trans
...

💬 instagibbs commented on pull request "cluster mempool: add TxGraph reorg functionality":
(https://github.com/bitcoin/bitcoin/pull/31553#issuecomment-3019618093)
@sipa linked here, added to follow-up potentially?

💬 furszy commented on pull request "test: fix feature_init.py intermittencies":
(https://github.com/bitcoin/bitcoin/pull/32835#discussion_r2175362595)
> any reason to start the node again? Can't this wait_until be done in check_clean_start?

Just because `check_clean_start()` is also called inside the deletion rounds and didn't want to start all indexes there on each cycle round. But that seems easily solvable.. one minute..

💬 furszy commented on pull request "test: fix feature_init.py intermittencies":
(https://github.com/bitcoin/bitcoin/pull/32835#discussion_r2175376795)
Done.

💬 maflcko commented on pull request "test: fix feature_init.py intermittencies":
(https://github.com/bitcoin/bitcoin/pull/32835#discussion_r2175386203)
this fails lint and `getindexinfo` is already a no-op when no args are provided, so no need to conditionally run it?

💬 furszy commented on pull request "test: fix feature_init.py intermittencies":
(https://github.com/bitcoin/bitcoin/pull/32835#discussion_r2175411102)
> this fails lint and `getindexinfo` is already a no-op when no args are provided, so no need to conditionally run it? could just inline it?

Saw it late, pushed.

💬 romanz commented on pull request "rest: rename `strURIPart` to `uri_part`":
(https://github.com/bitcoin/bitcoin/pull/32825#issuecomment-3019771653)
Thanks!

💬 Sjors commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#issuecomment-3019784087)
From inline discussion: https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2174917931

> I think it's good to keep the [`CCoinsCaching`] benchmark but its results should not be over interpreted. It is focused on a tiny portion of the total work performed when processing a transaction. I locally have benchmarks of `ProcessTransaction` which i may share in the future. To give you an idea, they suggest (as can be expected from just reading the code) that total work in processing a transact
...

💬 l0rinc commented on pull request "log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError":
(https://github.com/bitcoin/bitcoin/pull/32604#discussion_r2175440506)
Sweet, I'm planning on reviewing it this week!

💬 luke-jr commented on pull request "fs: use `ftruncate` in `AllocateFileRange` on OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/32645#discussion_r2175472130)
OTOH, `ftruncate` doesn't actually guarantee allocation... does OpenBSD provide such a guarantee?

💬 TheCharlatan commented on pull request "policy: make pathological transactions packed with legacy sigops non-standard":
(https://github.com/bitcoin/bitcoin/pull/32521#discussion_r2175476610)
Right, I wrote a little kernel application to count the sigops per transactions here: https://github.com/TheCharlatan/bitcoin/tree/sigop_stats . Just ran it, but I'm currently away from home and only have access to a pruned node. Still, did not find any offending transactions the last two days.

📝 fanquake opened a pull request: "depends: fix libevent `_WIN32_WINNT` usage"
(https://github.com/bitcoin/bitcoin/pull/32837)
Imports a commit from usptream ([a14ff91254f40cf36e0fee199e26fb11260fab49](https://github.com/libevent/libevent/commit/a14ff91254f40cf36e0fee199e26fb11260fab49)).

Fixes #32707.

💬 hebasto commented on pull request "depends: fix libevent `_WIN32_WINNT` usage":
(https://github.com/bitcoin/bitcoin/pull/32837#issuecomment-3019985717)
> Imports a commit from usptream ([a14ff91254f40cf36e0fee199e26fb11260fab49](https://github.com/libevent/libevent/commit/a14ff91254f40cf36e0fee199e26fb11260fab49)).
>
> Fixes #32707.

Any idea why the issue manifests only with mingw-w64 13.x?

⚠️ instagibbs opened an issue: "Shallow invalid forks + ActivateBestChainStep result in overly aggressive mempool filtering"
(https://github.com/bitcoin/bitcoin/issues/32838)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

Upon reorgs, the mempool has its transactions filtered near the end of every call of `ActivateBestChainStep` via `MaybeUpdateMempoolForReorg` : https://github.com/bitcoin/bitcoin/blob/a763497b1d6661bc5a7b8943d8f04a4459fd6827/src/validation.cpp#L3403

If the fork being activated is actually invalid this can happen:

1. Chain at height `T`, with transaction in mempool which relies on height
...

💬 instagibbs commented on issue "Shallow invalid forks + ActivateBestChainStep result in overly aggressive mempool filtering":
(https://github.com/bitcoin/bitcoin/issues/32838#issuecomment-3020041895)
cc @dergoegge

🚀 glozow merged a pull request: "p2p: Add witness mutation check inside FillBlock"
(https://github.com/bitcoin/bitcoin/pull/32646)

🤔 glozow reviewed a pull request: "p2p: add more bad ports"
(https://github.com/bitcoin/bitcoin/pull/32826#pullrequestreview-2972078289)
ACK 6967e8e8abbc35ac98e8e3745a8bbed56e77526f

💬 cmdruid commented on pull request "[WIP] rpc: add `clearmempool` command for regtest mode":
(https://github.com/bitcoin/bitcoin/pull/32418#issuecomment-3020093029)
Unfortunately I don't have the time to push this through. I will close this for now.

✅ cmdruid closed a pull request: "[WIP] rpc: add `clearmempool` command for regtest mode"
(https://github.com/bitcoin/bitcoin/pull/32418)

🚀 glozow merged a pull request: "p2p: add more bad ports"
(https://github.com/bitcoin/bitcoin/pull/32826)