💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2172851169)
Removed

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2172851273)
Made it >> 1

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2172851365)
done

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2172851409)
done

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2172851511)
done

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2172851580)
fixed

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2172851840)
done

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2172852325)
done

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2172852584)
Yes! Removed, thanks

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2172852782)
reworded

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#issuecomment-3014362470)
> See https://github.com/sipa/bitcoin/commits/pr31829

Thanks! I've incorporated this branch (squashed a couple of the changes directly into the main commit). Also addressed some comments. Still working on the bench and having `TxOrphanage` do its own limiting.

💬 achow101 commented on pull request "rpc: combinerawtransaction now rejects unmergeable transactions":
(https://github.com/bitcoin/bitcoin/pull/31298#discussion_r2172880709)
This comment is incorrect, it's not doing anything related to PSBT. You can just say that the scriptSigs and scriptWitnesses are being stripped in order to do a txid comparison.

💬 l0rinc commented on pull request "miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up)":
(https://github.com/bitcoin/bitcoin/pull/31713#discussion_r2172893233)
... and you also changed to do/while since there's always at least one value in the queue 👍

💬 achow101 commented on pull request "rest: fetch spent transaction outputs by blockhash":
(https://github.com/bitcoin/bitcoin/pull/32540#discussion_r2172902737)
In d4e212e8a69ea118acb6caa1a7efe64a77bdfdd2 "rest: fetch spent transaction outputs by blockhash"

nit: New code should use `snake_case`

```suggestion
static bool rest_spent_txouts(const std::any& context, HTTPRequest* req, const std::string& uri_part)
```

🤔 achow101 reviewed a pull request: "rest: fetch spent transaction outputs by blockhash"
(https://github.com/bitcoin/bitcoin/pull/32540#pullrequestreview-2968023538)
ACK c48846ec4169f749d28da05de849c43a488c3a70

🚀 achow101 merged a pull request: "rest: fetch spent transaction outputs by blockhash"
(https://github.com/bitcoin/bitcoin/pull/32540)

💬 adamandrews1 commented on pull request "rpc: combinerawtransaction now rejects unmergeable transactions":
(https://github.com/bitcoin/bitcoin/pull/31298#discussion_r2172923841)
Thanks, I will update this comment

💬 tnndbtc commented on issue "bitcoind shouldn't fail to progress with synchronization: endless [leveldb] Generated table ... logs":
(https://github.com/bitcoin/bitcoin/issues/31882#issuecomment-3014488356)
@GregTonoski If it's hard to profile the bitcoind process, and if you can still reproduce the issue, could you take several pstacks, each with 1 minute apart, and see which function appears multiple times? Then those are the potential ones being stuck. You can upload the pstacks so I can help take a look.

💬 murchandamus commented on pull request "wallet: Keep track of the wallet's own transaction outputs in memory":
(https://github.com/bitcoin/bitcoin/pull/27286#discussion_r2172976692)
I was just rereading the commit "wallet: Change balance calculation to use m_txos" (dde7cbe105ba6daaa636466d0fa3a83d15609417) and I’m aware that this is not a behavior change, but I am wondering about how the balances are calculated.

As seen, this distinguishes three groups of TXOs:

- "immature"
`if (wallet.IsTxImmatureCoinBase(wtx) && wtx.isConfirmed()) {`
- "trusted"
`} else if (is_trusted && tx_depth >= min_depth) {`
- "untrusted_pending"
`} else if (!is_trusted && wtx.InMemp
...

🤔 murchandamus reviewed a pull request: "wallet: Keep track of the wallet's own transaction outputs in memory"
(https://github.com/bitcoin/bitcoin/pull/27286#pullrequestreview-2968182392)
ACK 215e5999e20