💬 Sjors commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2171026682)
CI on https://github.com/Sjors/bitcoin/pull/90#issuecomment-3011857912 complains of an unused result.

💬 Sjors commented on pull request "ipc: Handle unclean shutdowns better":
(https://github.com/bitcoin/bitcoin/pull/32345#discussion_r2171082503)
<csignal>

💬 PeterWrighten commented on pull request "Add read-only mode to sqlite db and use in `bitcoin-wallet`":
(https://github.com/bitcoin/bitcoin/pull/32818#discussion_r2171326181)
In this code, you should add more seeds number of platform to pass CI.

💬 PeterWrighten commented on pull request "Add read-only mode to sqlite db and use in `bitcoin-wallet`":
(https://github.com/bitcoin/bitcoin/pull/32818#issuecomment-3012286236)
> > How does this compare with #32685?
>
>
>
> Ah, I didn't know (or had perhaps forgotten) about that PR. I came via #15608 and did not check what was open. Shame on me :(
>
>
>
> I will mark this as draft and take a look over that PR.

Never mind. Your implementation is also great. But seems there is lack of some tests for walletdb and db...

💬 naiyoma commented on pull request "wallet: have external signer use PSBT error code EXTERNAL_SIGNER_NOT_FOUND":
(https://github.com/bitcoin/bitcoin/pull/32682#issuecomment-3012316854)
Post Merge TAck 9dfc61d
I tested this by setting up HWI and using Trezor as my external signer
I noticed while reviewing this that some tests have been commented out —> https://github.com/bitcoin/bitcoin/blob/master/test/functional/wallet_signer.py#L81 and also
https://github.com/bitcoin/bitcoin/blob/master/test/functional/wallet_signer.py#L171
Perhaps a good follow-up would be to work on as well, ?

💬 l0rinc commented on pull request "clang-format: modernize and realign clang-format configuration":
(https://github.com/bitcoin/bitcoin/pull/32813#discussion_r2171408367)
Thanks, managed to install an older version and redid the changes for maximal compatibility.

💬 Sjors commented on issue "`dumptxoutset` rollback feature does not take forks into account":
(https://github.com/bitcoin/bitcoin/issues/32817#issuecomment-3012406102)
This goes back to the discussion in #29565 that we probably shouldn't be using block invalidation as a hack to make the chain state manager roll back. Instead we should actually roll back (though no need for a new RPC).

💬 pinheadmz commented on pull request "Add read-only mode to sqlite db and use in `bitcoin-wallet`":
(https://github.com/bitcoin/bitcoin/pull/32818#discussion_r2171485551)
🤔

🤔 fanquake reviewed a pull request: "Add release note for #32530"
(https://github.com/bitcoin/bitcoin/pull/32819#pullrequestreview-2966053187)
ACK 558f0880a8f374ab7a06bd829635a5e188bd8419

🚀 fanquake merged a pull request: "Add release note for #32530"
(https://github.com/bitcoin/bitcoin/pull/32819)

💬 rkrux commented on pull request "rpc, doc: clarify the response of listtransactions RPC":
(https://github.com/bitcoin/bitcoin/pull/32737#discussion_r2171711817)
Good point, I have reworded to remove the word "output". I do want to let an example be present because this behaviour was not apparent to me when I first started using this RPC.

💬 rkrux commented on pull request "rpc, doc: clarify the response of listtransactions RPC":
(https://github.com/bitcoin/bitcoin/pull/32737#discussion_r2171715691)
I have not used the term "logical/financial" to describe these transactions yet but I can add it if people believe that would be a valuable addition.

💬 ismaelsadeeq commented on pull request "test: fix an incorrect `feature_fee_estimation.py` subtest":
(https://github.com/bitcoin/bitcoin/pull/32463#discussion_r2171735436)
I think just linking the PR without some explanation will not be that enough, so I instead link the issue comment with the comprehensive explanation, it will be easy to dig in up to that PR after clicking the current link in https://github.com/bitcoin/bitcoin/commit/9b75cfda4d62a0a3bde402503244dd57e1621a12.

💬 rkrux commented on pull request "rpc, doc: clarify watch-only wallets balances in RPCHelp":
(https://github.com/bitcoin/bitcoin/pull/32761#issuecomment-3012715211)
> I don't get it. Watch-only wallets are treated the same as non-watch-only, aren't they?

In a way, they are.

> The available balance is what the wallet considers currently spendable

The current language^ in the RPC help made me curious regarding the balance shown for watch-only wallets because the watch-only wallets can't technically spend them. I checked that the balance shown in the RPC response is correct for such wallets, and this prompted me to add a note specifically for these wa
...

📝 zaidmstrr opened a pull request: "rpc: Handle -named argument parsing where Base64 encoding is used"
(https://github.com/bitcoin/bitcoin/pull/32821)
Addresses [comment](https://github.com/bitcoin/bitcoin/pull/31375#discussion_r2091886628) and [this](https://github.com/bitcoin/bitcoin/pull/31375#discussion_r2092039999).

The [PR #31375](https://github.com/bitcoin/bitcoin/pull/31375) got merged and enables `-named` by default in the `bitcoin rpc` interface; `bitcoin rpc` corresponds to `bitcoin-cli -named` as it's just a wrapper. Now, the problem arises when we try to parse the positional paramater which might contain "=" as a Base64 charac
...

💬 luke-jr commented on pull request "util: detect and warn when using exFAT on MacOS":
(https://github.com/bitcoin/bitcoin/pull/31453#discussion_r2171708556)
Does macOS not allow mounting subdirectories? (Maybe a bind mount) eg, maybe datadir isn't exFAT, but blocks is?

💬 luke-jr commented on pull request "util: detect and warn when using exFAT on MacOS":
(https://github.com/bitcoin/bitcoin/pull/31453#discussion_r2171706368)
What if it's datadir/blocks-alternative-name or something?

💬 maflcko commented on pull request "rpc: Handle -named argument parsing where Base64 encoding is used":
(https://github.com/bitcoin/bitcoin/pull/32821#discussion_r2171811426)
not sure about limiting this to base64. There are many other args that can hold values with an `=` in them. For example, labels.

💬 Sjors commented on pull request "rpc: Handle -named argument parsing where Base64 encoding is used":
(https://github.com/bitcoin/bitcoin/pull/32821#issuecomment-3012778370)
I ran into this issue in #32784 while editing the multisig tutorial.

🤔 hodlinator reviewed a pull request: "rpc: Distinguish between vsize and sigop adjusted mempool vsize"
(https://github.com/bitcoin/bitcoin/pull/32800#pullrequestreview-2965833344)
Concept ACK be75fa48fa77c417b9ebdd3be4d1ddb212ab16b3

Might be good to add release notes for this PR as it is adding to the user-facing RPC interface, similarly to: https://github.com/bitcoin/bitcoin/blob/be75fa48fa77c417b9ebdd3be4d1ddb212ab16b3/doc/release-notes-27826.md