💬 pablomartin4btc commented on pull request "doc: Add fetching single PRs from upstream to productivity.md":
(https://github.com/bitcoin/bitcoin/pull/32783#issuecomment-3005968667)
re-ACK 45b1d39

🤔 glozow reviewed a pull request: "doc: add release notes for #32425"
(https://github.com/bitcoin/bitcoin/pull/32727#pullrequestreview-2959472194)
ACK b9a2e8ee965daffe2bc618f58b21f0ddebadeb23, thanks for taking suggestions!

🚀 glozow merged a pull request: "doc: add release notes for #32425"
(https://github.com/bitcoin/bitcoin/pull/32727)

🚀 glozow merged a pull request: "wallet: Remove `CWalletTx::fTimeReceivedIsTxTime`"
(https://github.com/bitcoin/bitcoin/pull/32768)

🚀 glozow merged a pull request: "wallet: Always set descriptor cache upgraded flag for new wallets"
(https://github.com/bitcoin/bitcoin/pull/32597)

💬 m3dwards commented on pull request "test: enabling wallet migration functional test on windows":
(https://github.com/bitcoin/bitcoin/pull/32219#discussion_r2167557225)
It was `--target-dir`. Applied suggestion.

💬 m3dwards commented on pull request "test: enabling wallet migration functional test on windows":
(https://github.com/bitcoin/bitcoin/pull/32219#discussion_r2167557715)
Done.

💬 m3dwards commented on pull request "test: enabling wallet migration functional test on windows":
(https://github.com/bitcoin/bitcoin/pull/32219#discussion_r2167558515)
Sure, done.

💬 m3dwards commented on pull request "test: enabling wallet migration functional test on windows":
(https://github.com/bitcoin/bitcoin/pull/32219#discussion_r2167558872)
Done.

💬 m3dwards commented on pull request "test: enabling wallet migration functional test on windows":
(https://github.com/bitcoin/bitcoin/pull/32219#discussion_r2167559798)
Changed to `--target-dir`.

💬 fjahr commented on pull request "rpc: use CScheduler for HTTPRPCTimer":
(https://github.com/bitcoin/bitcoin/pull/32796#issuecomment-3006057356)
Code review ACK d06942c6731d5db7326bc565655b33a379a5d9b0

💬 glozow commented on pull request "wallet, rpc: Remove deprecated balances from getwalletinfo and getunconfirmedbalance":
(https://github.com/bitcoin/bitcoin/pull/32721#issuecomment-3006074516)
Not required, but I think it would be nice to write a release note mentioning "these fields from `getwalletinfo` which were deprecated in 0.19 are now unavailable. Here are the equivalent fields from `getbalances`: etc etc etc"

💬 hodlinator commented on pull request "headerssync: Preempt unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2167578566)
Renumbered in the "Improve comments"-commit.

💬 hodlinator commented on pull request "headerssync: Preempt unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2167580914)
Broke out `bool buffer_exceeded`, let me know if you think it's an improvement.

💬 hodlinator commented on pull request "headerssync: Preempt unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2167525791)
No, rebase mishap. Thanks for catching!

💬 hodlinator commented on pull request "headerssync: Preempt unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2167506799)
Slightly more confusing error, but like that it's more terse. Taken.

💬 hodlinator commented on pull request "headerssync: Preempt unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2167541369)
Agree. New attempt:
```C++
//! Only start outputting headers once this many headers have been received
//! and validated against commitments.
```

🚀 glozow merged a pull request: "wallet, rpc: Remove deprecated balances from getwalletinfo and getunconfirmedbalance"
(https://github.com/bitcoin/bitcoin/pull/32721)

👍 hodlinator approved a pull request: "test: enabling wallet migration functional test on windows"
(https://github.com/bitcoin/bitcoin/pull/32219#pullrequestreview-2959616863)
re-ACK 941b8f54c0d35d3243bb6083f3b52681d1b9a555

Fixed some nits (https://github.com/bitcoin/bitcoin/pull/32219#pullrequestreview-2959123050) since my first ACK (https://github.com/bitcoin/bitcoin/pull/32219#pullrequestreview-2921071060).
Passed linter locally.

💬 l0rinc commented on pull request "merkle: pre‑reserve leaves to prevent reallocs with odd vtx count":
(https://github.com/bitcoin/bitcoin/pull/32497#issuecomment-3006209711)
I've rebased the changed and adjusted the benchmark to be more similar to the other production usages in the first commit, rounded to even in the second (optimization) commit, so that we can realistically measure the speed difference before and after:

% build/bin/bench_bitcoin -filter='MerkleRoot' --min-time=1000

Before 7f620cffebee593e48434cf182cc2fd64a6d76be:

| ns/leaf | leaf/s | err% | total | benchmark
|--------------------:|--------------------:|---
...