🤔 janb84 reviewed a pull request: "doc: Add fetching single PRs from upstream to productivity.md"
(https://github.com/bitcoin/bitcoin/pull/32783#pullrequestreview-2959405149)
re ACK 45b1d39757668939b03b27401c324a938ef0cd8d

Changes sinds last ACK:
- Small textual changes / fixed typo's

💬 luke-jr commented on pull request "rpc, doc: clarify the response of listtransactions RPC":
(https://github.com/bitcoin/bitcoin/pull/32737#discussion_r2167466882)
"output" is kind of a low-level detail, while this is a high-level RPC. It's better to think of entries as logical/financial transactions, as opposed to blockchain transactions.

💬 stringintech commented on pull request "test: headers sync timeout":
(https://github.com/bitcoin/bitcoin/pull/32677#discussion_r2167480268)
I tried this and it seems that doing this instead of restarting the node does not reset the peer indexes, and I can no longer count on the peer indexes in the debug logs.
For example, for the `test_normal_peer_timeout` subset:
```
Timeout downloading headers, disconnecting peer=0
```
becomes
```
Timeout downloading headers, disconnecting peer=3
```
Although still having `peer=0` for the `test_noban_peer_timeout` subtest since we need a restart for that. But it shouldn't matter if you t
...

💬 pablomartin4btc commented on pull request "doc: Add fetching single PRs from upstream to productivity.md":
(https://github.com/bitcoin/bitcoin/pull/32783#issuecomment-3005968667)
re-ACK 45b1d39

🤔 glozow reviewed a pull request: "doc: add release notes for #32425"
(https://github.com/bitcoin/bitcoin/pull/32727#pullrequestreview-2959472194)
ACK b9a2e8ee965daffe2bc618f58b21f0ddebadeb23, thanks for taking suggestions!

🚀 glozow merged a pull request: "doc: add release notes for #32425"
(https://github.com/bitcoin/bitcoin/pull/32727)

🚀 glozow merged a pull request: "wallet: Remove `CWalletTx::fTimeReceivedIsTxTime`"
(https://github.com/bitcoin/bitcoin/pull/32768)

🚀 glozow merged a pull request: "wallet: Always set descriptor cache upgraded flag for new wallets"
(https://github.com/bitcoin/bitcoin/pull/32597)

💬 m3dwards commented on pull request "test: enabling wallet migration functional test on windows":
(https://github.com/bitcoin/bitcoin/pull/32219#discussion_r2167557225)
It was `--target-dir`. Applied suggestion.

💬 m3dwards commented on pull request "test: enabling wallet migration functional test on windows":
(https://github.com/bitcoin/bitcoin/pull/32219#discussion_r2167557715)
Done.

💬 m3dwards commented on pull request "test: enabling wallet migration functional test on windows":
(https://github.com/bitcoin/bitcoin/pull/32219#discussion_r2167558515)
Sure, done.

💬 m3dwards commented on pull request "test: enabling wallet migration functional test on windows":
(https://github.com/bitcoin/bitcoin/pull/32219#discussion_r2167558872)
Done.

💬 m3dwards commented on pull request "test: enabling wallet migration functional test on windows":
(https://github.com/bitcoin/bitcoin/pull/32219#discussion_r2167559798)
Changed to `--target-dir`.

💬 fjahr commented on pull request "rpc: use CScheduler for HTTPRPCTimer":
(https://github.com/bitcoin/bitcoin/pull/32796#issuecomment-3006057356)
Code review ACK d06942c6731d5db7326bc565655b33a379a5d9b0

💬 glozow commented on pull request "wallet, rpc: Remove deprecated balances from getwalletinfo and getunconfirmedbalance":
(https://github.com/bitcoin/bitcoin/pull/32721#issuecomment-3006074516)
Not required, but I think it would be nice to write a release note mentioning "these fields from `getwalletinfo` which were deprecated in 0.19 are now unavailable. Here are the equivalent fields from `getbalances`: etc etc etc"

💬 hodlinator commented on pull request "headerssync: Preempt unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2167578566)
Renumbered in the "Improve comments"-commit.

💬 hodlinator commented on pull request "headerssync: Preempt unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2167580914)
Broke out `bool buffer_exceeded`, let me know if you think it's an improvement.

💬 hodlinator commented on pull request "headerssync: Preempt unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2167525791)
No, rebase mishap. Thanks for catching!

💬 hodlinator commented on pull request "headerssync: Preempt unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2167506799)
Slightly more confusing error, but like that it's more terse. Taken.

💬 hodlinator commented on pull request "headerssync: Preempt unrealistic unit test behavior":
(https://github.com/bitcoin/bitcoin/pull/32579#discussion_r2167541369)
Agree. New attempt:
```C++
//! Only start outputting headers once this many headers have been received
//! and validated against commitments.
```