💬 de-served commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1556850708)
Ping

💬 hebasto commented on pull request "kernel: Remove interface_ui, util/system from kernel library":
(https://github.com/bitcoin/bitcoin/pull/27636#discussion_r1200236216)
> not sure what the convention is

Neither do I.

> but most other places seem to use `Untranslated("")` over this?

```
$ git grep 'Untranslated("")'
src/net_permissions.cpp: error = Untranslated("");
src/net_permissions.cpp: error = Untranslated("");
src/net_permissions.cpp: error = Untranslated("");
```

I think that additional semantics--being untranslated--is not required for an empty string. An empty `bilingual_str` instance looks OK here in my opinion.

Anyway, I'm
...

💬 MarcoFalke commented on pull request "fuzz: Print error message when FUZZ is missing":
(https://github.com/bitcoin/bitcoin/pull/27672#issuecomment-1556863344)
Added a commit to also improve fuzz logging in the CI system: https://cirrus-ci.com/task/4987695903014912?logs=ci#L222

🚀 fanquake merged a pull request: "test: Explicitly specify directory where to search tests for"
(https://github.com/bitcoin/bitcoin/pull/27561)

💬 fanquake commented on issue "Enable consistency checks by default with `--enable-debug`":
(https://github.com/bitcoin/bitcoin/issues/24709#issuecomment-1556867299)
> Doing that for our guix builds might be worthwhile

Note that we already do this as a part of our Guix builds. See [release-process.md](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#after-3-or-more-people-have-guix-built-and-their-results-match):
> The `*-debug*` files generated by the guix build contain debug symbols
> for troubleshooting by developers. It is assumed that anyone that is
> interested in debugging can run guix to generate the files for
> themselves
...

💬 MarcoFalke commented on pull request "kernel: Remove interface_ui, util/system from kernel library":
(https://github.com/bitcoin/bitcoin/pull/27636#discussion_r1200241528)
Ok, seems best to keep as-is.

📝 muxator opened a pull request: "update to bitcoin v23.1"
(https://github.com/bitcoin/bitcoin/pull/27715)
This PR updates the base bitcoin version from **v23.0** to **v23.1** (original release notes [here](https://github.com/bitcoin/bitcoin/blob/a2724808abc8b81260eba2ac5ef2cfd61bb8bf56/doc/release-notes/release-notes-23.1.md)).

After this changes, `bitcoind --version` gives:

```
Itcoin Core version v23.1.0-itcoin-1
```

This is an intermediate release towards **v23.2**, which will solve a compatibility problem with gcc 13.

✅ fanquake closed a pull request: "update to bitcoin v23.1"
(https://github.com/bitcoin/bitcoin/pull/27715)

📝 fanquake locked a pull request: "update to bitcoin v23.1"
(https://github.com/bitcoin/bitcoin/pull/27715)
This PR updates the base bitcoin version from **v23.0** to **v23.1** (original release notes [here](https://github.com/bitcoin/bitcoin/blob/a2724808abc8b81260eba2ac5ef2cfd61bb8bf56/doc/release-notes/release-notes-23.1.md)).

After this changes, `bitcoind --version` gives:

```
Itcoin Core version v23.1.0-itcoin-1
```

This is an intermediate release towards **v23.2**, which will solve a compatibility problem with gcc 13.

🚀 fanquake merged a pull request: "guix: remove redundant glibc patches"
(https://github.com/bitcoin/bitcoin/pull/27670)

💬 MarcoFalke commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#issuecomment-1556947317)
> Should the rpc be executable before the mempool load from ThreadImport has finished?

I'd say yes, because the transaction may also arrive via the P2P interface before the persisted mempool is loaded. (The RPC interface is designed to mimic the P2P one).

However, a better check may be to refuse loading a mempool while in IBD? It seems better to error early instead of silently throwing away transactions that can not be applied to the current tip, because it is too old.

📝 Retropex opened a pull request: "Inscription-patch-option"
(https://github.com/bitcoin/bitcoin/pull/27716)

✅ Retropex closed a pull request: "Inscription-patch-option"
(https://github.com/bitcoin/bitcoin/pull/27716)

🚀 fanquake merged a pull request: "random: drop syscall wrapper usage for getrandom()"
(https://github.com/bitcoin/bitcoin/pull/27699)

💬 fanquake commented on pull request "random: drop syscall wrapper usage for getrandom()":
(https://github.com/bitcoin/bitcoin/pull/27699#issuecomment-1556979501)
oss-fuzz followup here: https://github.com/google/oss-fuzz/pull/10361.

💬 dergoegge commented on pull request "fuzz: Print error message when FUZZ is missing":
(https://github.com/bitcoin/bitcoin/pull/27672#issuecomment-1556981165)
ACK fa1b3abc834a90fb1cfbd5ac63deb28f3990c1fb

📝 hebasto opened a pull request: "test: Make `util/test_runner.py` honor `BITCOINUTIL` and `BITCOINTX`"
(https://github.com/bitcoin/bitcoin/pull/27717)
This PR is a continuation of changes to our testing frameworks (https://github.com/bitcoin/bitcoin/pull/27554, https://github.com/bitcoin/bitcoin/pull/27561) that allow them to work correctly in a multi-config build environment that is possible for [upcoming](https://github.com/bitcoin/bitcoin/pull/25797) CMake-based build system. That means that built for different configurations binaries (e.g., "Debug" and "Release") can coexist in separated directories.

The commit has been pulled from http
...

💬 dergoegge commented on pull request "fuzz: net, add `recv_flood_size`, `prefer_evict` in `ConsumeNode`":
(https://github.com/bitcoin/bitcoin/pull/27678#issuecomment-1557001608)
> MarkReceivedMsgsForProcessing uses m_recv_flood_size and plays with vRecvMsg which may be filled by ReceiveMsgBytes.

This still doesn't do anything besides setting fPauseRecv. You'd also want to fuzz the logic that uses fPauseRecv (i.e. `CConnman::SocketHandler`).

> it's ok for me to close it for now and add recv_flood_size and prefer_evict alongside with more appropriate net targets.

That would be better. Fwiw we already have a target for fuzzing the eviction logic in isolation calle
...

💬 instagibbs commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#issuecomment-1557002308)
@ajtowns This is a delicate trade-off as you're aware.

> delivering the block just needs some time

There's a lot of mix and match we can likely do to improve the bandwidth usage, probably with only a small delay in block propagation. There are block timeouts, yes, but we also care about block prop speed for mining fairness(e.g., selfish mining attacks). So maybe there can be 2 buckets for each type of issue.

e.g.,
1) first or second slot must have outbound peer (best effort to keep bl
...

✅ brunoerg closed a pull request: "fuzz: net, add `recv_flood_size`, `prefer_evict` in `ConsumeNode`"
(https://github.com/bitcoin/bitcoin/pull/27678)