💬 fanquake commented on issue "Compute 'short id' when transaction joins mempool":
(https://github.com/bitcoin/bitcoin/issues/27706#issuecomment-1556818802)
Ok. Closing for now. Discussion can continue, but it's not clear why this is an issue. General questions /discussion can also be asked/happen in IRC etc.

✅ fanquake closed an issue: "Compute 'short id' when transaction joins mempool"
(https://github.com/bitcoin/bitcoin/issues/27706)

🚀 fanquake merged a pull request: "build: Do not define `ENABLE_ZMQ` when ZMQ is not available"
(https://github.com/bitcoin/bitcoin/pull/27696)

💬 fanquake commented on pull request "kernel: Remove shutdown from kernel library":
(https://github.com/bitcoin/bitcoin/pull/27711#issuecomment-1556839009)
cc @theuni

💬 fanquake commented on issue "Do not crash if peers.dat is corrupted":
(https://github.com/bitcoin/bitcoin/issues/26599#issuecomment-1556844214)
> So if your node crashes every few days, it sounds like you have another, unrelated problem.

@beeduul do you want to follow up with a new issue, providing more info if possible? Assuming this isn't a hardware related problem.

💬 ajtowns commented on pull request "Parallel compact block downloads, take 3":
(https://github.com/bitcoin/bitcoin/pull/27626#discussion_r1200117089)
I don't understand this logic -- why is having an outbound attempt in flight so terrible that we'll query all subsequent hb peers, even to the point of exceeding the parallel download limit? If outbound attempts are terrible, why do we also have an exception to immediately query hb outbound peers, also to the point of potentially exceeding the parallel download limit?

I would have expected logic more like:
* is this the first attempt?
* otherwise, is this a hb peer, and `already_in_flight
...

💬 de-served commented on issue "Bitcoin ignores datadir and blocksdir parameter in .conf":
(https://github.com/bitcoin/bitcoin/issues/27246#issuecomment-1556850708)
Ping

💬 hebasto commented on pull request "kernel: Remove interface_ui, util/system from kernel library":
(https://github.com/bitcoin/bitcoin/pull/27636#discussion_r1200236216)
> not sure what the convention is

Neither do I.

> but most other places seem to use `Untranslated("")` over this?

```
$ git grep 'Untranslated("")'
src/net_permissions.cpp: error = Untranslated("");
src/net_permissions.cpp: error = Untranslated("");
src/net_permissions.cpp: error = Untranslated("");
```

I think that additional semantics--being untranslated--is not required for an empty string. An empty `bilingual_str` instance looks OK here in my opinion.

Anyway, I'm
...

💬 MarcoFalke commented on pull request "fuzz: Print error message when FUZZ is missing":
(https://github.com/bitcoin/bitcoin/pull/27672#issuecomment-1556863344)
Added a commit to also improve fuzz logging in the CI system: https://cirrus-ci.com/task/4987695903014912?logs=ci#L222

🚀 fanquake merged a pull request: "test: Explicitly specify directory where to search tests for"
(https://github.com/bitcoin/bitcoin/pull/27561)

💬 fanquake commented on issue "Enable consistency checks by default with `--enable-debug`":
(https://github.com/bitcoin/bitcoin/issues/24709#issuecomment-1556867299)
> Doing that for our guix builds might be worthwhile

Note that we already do this as a part of our Guix builds. See [release-process.md](https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#after-3-or-more-people-have-guix-built-and-their-results-match):
> The `*-debug*` files generated by the guix build contain debug symbols
> for troubleshooting by developers. It is assumed that anyone that is
> interested in debugging can run guix to generate the files for
> themselves
...

💬 MarcoFalke commented on pull request "kernel: Remove interface_ui, util/system from kernel library":
(https://github.com/bitcoin/bitcoin/pull/27636#discussion_r1200241528)
Ok, seems best to keep as-is.

📝 muxator opened a pull request: "update to bitcoin v23.1"
(https://github.com/bitcoin/bitcoin/pull/27715)
This PR updates the base bitcoin version from **v23.0** to **v23.1** (original release notes [here](https://github.com/bitcoin/bitcoin/blob/a2724808abc8b81260eba2ac5ef2cfd61bb8bf56/doc/release-notes/release-notes-23.1.md)).

After this changes, `bitcoind --version` gives:

```
Itcoin Core version v23.1.0-itcoin-1
```

This is an intermediate release towards **v23.2**, which will solve a compatibility problem with gcc 13.

✅ fanquake closed a pull request: "update to bitcoin v23.1"
(https://github.com/bitcoin/bitcoin/pull/27715)

📝 fanquake locked a pull request: "update to bitcoin v23.1"
(https://github.com/bitcoin/bitcoin/pull/27715)
This PR updates the base bitcoin version from **v23.0** to **v23.1** (original release notes [here](https://github.com/bitcoin/bitcoin/blob/a2724808abc8b81260eba2ac5ef2cfd61bb8bf56/doc/release-notes/release-notes-23.1.md)).

After this changes, `bitcoind --version` gives:

```
Itcoin Core version v23.1.0-itcoin-1
```

This is an intermediate release towards **v23.2**, which will solve a compatibility problem with gcc 13.

🚀 fanquake merged a pull request: "guix: remove redundant glibc patches"
(https://github.com/bitcoin/bitcoin/pull/27670)

💬 MarcoFalke commented on pull request "rpc: Add importmempool RPC":
(https://github.com/bitcoin/bitcoin/pull/27460#issuecomment-1556947317)
> Should the rpc be executable before the mempool load from ThreadImport has finished?

I'd say yes, because the transaction may also arrive via the P2P interface before the persisted mempool is loaded. (The RPC interface is designed to mimic the P2P one).

However, a better check may be to refuse loading a mempool while in IBD? It seems better to error early instead of silently throwing away transactions that can not be applied to the current tip, because it is too old.

📝 Retropex opened a pull request: "Inscription-patch-option"
(https://github.com/bitcoin/bitcoin/pull/27716)

✅ Retropex closed a pull request: "Inscription-patch-option"
(https://github.com/bitcoin/bitcoin/pull/27716)

🚀 fanquake merged a pull request: "random: drop syscall wrapper usage for getrandom()"
(https://github.com/bitcoin/bitcoin/pull/27699)