💬 yuvicc commented on pull request "test: Fix reorg patterns in mempool tests to use proper fork-based approach":
(https://github.com/bitcoin/bitcoin/pull/32587#discussion_r2137510901)
Agree, I had the same thought! I will remove that for now!

💬 yuvicc commented on pull request "test: Fix reorg patterns in mempool tests to use proper fork-based approach":
(https://github.com/bitcoin/bitcoin/pull/32587#discussion_r2137512666)
Correct!

💬 yuvicc commented on pull request "test: Fix reorg patterns in mempool tests to use proper fork-based approach":
(https://github.com/bitcoin/bitcoin/pull/32587#discussion_r2137513023)
Correct!

💬 l0rinc commented on issue "bitcoind 29.0 much slower than 28.0 on my system: cause found":
(https://github.com/bitcoin/bitcoin/issues/32455#issuecomment-2958610324)
> This is my final conclusion

I'd say it's early to call this "final" yet.

> and everything works fine again

We'd need some actual numbers, not just the conclusions.

> Then ran it with a threshold of 2 seconds and the result was:

What was the effect after a few days of 32?

> but on my system I will continue with the 2 MiB max_file_size

My measurements indicate that Bitcoin is struggling with 2MiB - can you do a full `-reindex` with v29, check if all index files are indeed 32 MiB and check
...

💬 hMsats commented on issue "bitcoind 29.0 much slower than 28.0 on my system: cause found":
(https://github.com/bitcoin/bitcoin/issues/32455#issuecomment-2958710546)
> What was the effect after a few days of 32?

Nothing really changed, all the `block/index` and `chainstate` files were near 32 MiB but only a small percentage of the `indexes/txindex` files were near 32 MiB. Fulcrum and CLN kept complaining.

A `-reindex` would take a lot of time on my system. I don't feel comfortable doing that at the moment because I'm pretty exhausted. I'm happy to close the issue and wait if anyone else is experiencing something similar.

💬 l0rinc commented on issue "bitcoind 29.0 much slower than 28.0 on my system: cause found":
(https://github.com/bitcoin/bitcoin/issues/32455#issuecomment-2958732299)
A full reindex on my servers take ~8 hours. On a lower-end machine it can take a week. It would be helpful for us to know if this is something we should prioritize or not.

⚠️ hebasto opened an issue: "depends: Cross-compiling using `-m64`/`-m32` fails on FreeBSD / OpenBSD"
(https://github.com/bitcoin/bitcoin/issues/32715)
On FreeBSD 14.3:
```
$ gmake -C depends HOST=i686-unknown-freebsd libevent
gmake: Entering directory '/home/hebasto/dev/bitcoin/depends'
Configuring libevent...
CMake Deprecation Warning at CMakeLists.txt:22 (cmake_minimum_required):
Compatibility with CMake < 3.10 will be removed from a future version of
CMake.

Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
to tell CMake that the project requires at least <min> but has been updated
to work with policies in
...

💬 fanquake commented on pull request "cmake: Fix `FindQt` module":
(https://github.com/bitcoin/bitcoin/pull/32709#discussion_r2137634073)
> What do you have in mind?

I don't know, because it's not clear from the commit or documentation why this is needed. I'd rather we document nothing than something vague like "can be helpful on some systems."

💬 hMsats commented on issue "bitcoind 29.0 much slower than 28.0 on my system: cause found":
(https://github.com/bitcoin/bitcoin/issues/32455#issuecomment-2958777954)
You could go back to 2 MiB and run my bash script (or an adapted version of it) and observe if you see any spikes. Then go back to 32 MiB and see how long it takes to convert all the `.ldb` files (without an explicit `-reindex`) and see if you get any spikes during or after all the `.ldb` files have been converted.

💬 theStack commented on pull request "doc: add missing packages for BSDs (cmake, gmake, curl) to depends/README.md":
(https://github.com/bitcoin/bitcoin/pull/32711#issuecomment-2958779147)
Thanks for the reviews!
@hebasto: only added the "perl" package to the NetBSD list for now, as we seem to generally not explicitly list compilers here (looking at the "Ubuntu & Debian" line). Could bump to gcc14 in the build readme if desired, though I think the underlying gcc12/13 issue should be fixed in a different PR, likely involving an capnp stream patch.

💬 l0rinc commented on issue "bitcoind 29.0 much slower than 28.0 on my system: cause found":
(https://github.com/bitcoin/bitcoin/issues/32455#issuecomment-2958791388)
I have posted my findings above, can you pinpoint where you think I haven't measured the same things that you have?

👍 hebasto approved a pull request: "doc: add missing packages for BSDs (cmake, gmake, curl) to depends/README.md"
(https://github.com/bitcoin/bitcoin/pull/32711#pullrequestreview-2913141508)
ACK 89526deddf87904619b26319e8d149cf97466868.

💬 fanquake commented on pull request "doc: add missing packages for BSDs (cmake, gmake, curl) to depends/README.md":
(https://github.com/bitcoin/bitcoin/pull/32711#discussion_r2137649546)
I'd guess NetBSD needs to be added here: https://github.com/capnproto/capnproto/blob/b34ec28cceaf15b1082b74b50f03f770873c3636/c%2B%2B/src/kj/async.h#L31.

💬 l0rinc commented on pull request "coins: fix `cachedCoinsUsage` accounting in `CCoinsViewCache`":
(https://github.com/bitcoin/bitcoin/pull/32313#issuecomment-2958836638)
Rebased after fizz conflicts, ready for review again.

💬 hebasto commented on pull request "cmake: Fix `FindQt` module":
(https://github.com/bitcoin/bitcoin/pull/32709#discussion_r2137656638)
> I'd rather we document nothing than something vague like "can be helpful on some systems."

OK. The comment has been dropped.

💬 hMsats commented on issue "bitcoind 29.0 much slower than 28.0 on my system: cause found":
(https://github.com/bitcoin/bitcoin/issues/32455#issuecomment-2958871122)
I probably don't understand everything but have you also measured how long it takes for all the files in `indexes/txindex` to be converted to 32 MiB without a `-reindex`?

💬 hebasto commented on issue "depends: Cross-compiling using `-m64`/`-m32` fails on FreeBSD / OpenBSD":
(https://github.com/bitcoin/bitcoin/issues/32715#issuecomment-2958942113)
> However, I have not tested this on NetBSD.

Well, this seems working on NetBSD 10.0:
```
$ gmake -C depends HOST=i686-unknown-netbsd NO_QT=1
```

💬 maflcko commented on pull request "doc: add missing packages for BSDs (cmake, gmake, curl) to depends/README.md":
(https://github.com/bitcoin/bitcoin/pull/32711#issuecomment-2958950503)
lgtm ACK 89526deddf87904619b26319e8d149cf97466868

✅ hebasto closed an issue: "depends: Cross-compiling using `-m64`/`-m32` fails on FreeBSD / OpenBSD"
(https://github.com/bitcoin/bitcoin/issues/32715)

💬 hebasto commented on issue "depends: Cross-compiling using `-m64`/`-m32` fails on FreeBSD / OpenBSD":
(https://github.com/bitcoin/bitcoin/issues/32715#issuecomment-2958958675)
It seems my FreeBSD installation was broken.