💬 achow101 commented on pull request "wallet: Allow read-only database access for info and dump commands":
(https://github.com/bitcoin/bitcoin/pull/32685#discussion_r2136538706)
In 6189a20491f71e3a6f499d2a510b38bb914e00d9 "test: Add tests for readonly database access"

`MockableBatch` should have `m_read_only` as well and it should be enforcing that in its `Write()`.

💬 achow101 commented on pull request "wallet: Allow read-only database access for info and dump commands":
(https://github.com/bitcoin/bitcoin/pull/32685#discussion_r2136534067)
In bf62c6f50230ed11b0335bc254258701765c7f00 "typo: fix lint issue"

This commit should be squashed with the previous.

💬 achow101 commented on pull request "wallet: Allow read-only database access for info and dump commands":
(https://github.com/bitcoin/bitcoin/pull/32685#discussion_r2136549063)
In 6189a20491f71e3a6f499d2a510b38bb914e00d9 "test: Add tests for readonly database access"

There is a lot of code duplication with `test_tool_wallet_info`, it'd be nice if this could be de-deuplicated.

🚀 achow101 merged a pull request: "rpc, doc: update `listdescriptors` RCP help"
(https://github.com/bitcoin/bitcoin/pull/32708)

💬 achow101 commented on pull request "wallet: have external signer use PSBT error code EXTERNAL_SIGNER_NOT_FOUND":
(https://github.com/bitcoin/bitcoin/pull/32682#issuecomment-2957108743)
ACK 0a4ee93529d68a31f3ba6c7c6009954be47bbbd6

💬 brunoerg commented on pull request "wallet: have external signer use PSBT error code EXTERNAL_SIGNER_NOT_FOUND":
(https://github.com/bitcoin/bitcoin/pull/32682#discussion_r2136560107)
Perhaps we could have a test for it since it doesn't throw a runtime error anymore?

👍 brunoerg approved a pull request: "wallet: have external signer use PSBT error code EXTERNAL_SIGNER_NOT_FOUND"
(https://github.com/bitcoin/bitcoin/pull/32682#pullrequestreview-2911446036)
code review ACK 0a4ee93529d68a31f3ba6c7c6009954be47bbbd6

📝 brunoerg opened a pull request: "doc: fuzz: fix AFL++ link"
(https://github.com/bitcoin/bitcoin/pull/32713)
Fix link about selecting the best AFL compiler.

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#issuecomment-2957170296)
Rebased for silent merge conflict with #32406

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2136484132)
Moved

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2135952193)
Done

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2136530972)
Renamed to `unique`. I consolidated `IsUnique` to only have the `wtxid` variant, and it's now only used by the erasure functions that aren't holding `ByWtxid` iterators.

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2136540717)
Nice yes, made `Usage = int64_t` and `Count = unsigned int`

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2136462525)
Nice, done

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2136531813)
Changed this one, but wasn't sure if there is a max Wtxid I can use for `EraseForPeer`?

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2136535935)
Also a `ByPeer` iterator (see other comment)

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2136463200)
Done

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2136421097)
nice, done

💬 glozow commented on pull request "p2p: improve TxOrphanage denial of service bounds":
(https://github.com/bitcoin/bitcoin/pull/31829#discussion_r2136417290)
`num_erased` has the number of announcements so it can be greater than 1. However, since I've changed this to return a bool, I just made this `return true`.

💬 juanitoddd commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2957181542)
There was no clear consensus on this, and therefore should have been never merged ! This action will set in motion a movement against this project. Well done, you just destroy your reputation ! Bravo