💬 Sjors commented on issue "depends: OpenBSD (aarch64) needs gcc (instruction) for libevent":
(https://github.com/bitcoin/bitcoin/issues/32691#issuecomment-2955562001)
@hebasto I cherry-picked your patch on top of master @ e2174378aa8a339c7be8b4e91311513ed520a16d and indeed libevent now builds fine.

It also works on top of #32690 (I also ran the unit and functional test suite).

Can you open a PR with it?

💬 delta1 commented on pull request "BIP-119 (OP_CHECKTEMPLATEVERIFY) (regtest only)":
(https://github.com/bitcoin/bitcoin/pull/31989#issuecomment-2955572099)
Concept ACK. Will code review.

💬 delta1 commented on pull request "BIP-348 (OP_CHECKSIGFROMSTACK) (regtest only)":
(https://github.com/bitcoin/bitcoin/pull/32247#issuecomment-2955583380)
Concept ACK

🤔 Prabhat1308 reviewed a pull request: "test: Fix reorg patterns in mempool tests to use proper fork-based approach"
(https://github.com/bitcoin/bitcoin/pull/32587#pullrequestreview-2909861578)
ACK with the approach . Left some nits

💬 Prabhat1308 commented on pull request "test: Fix reorg patterns in mempool tests to use proper fork-based approach":
(https://github.com/bitcoin/bitcoin/pull/32587#discussion_r2135597013)
```suggestion
# Prep for fork with empty blocks
```

I think this should be included in the PR description or commit description rather than in the code. We would not like to refer to a old function we used here which anyway could be easily find if we backtracked to the PR.

💬 Prabhat1308 commented on pull request "test: Fix reorg patterns in mempool tests to use proper fork-based approach":
(https://github.com/bitcoin/bitcoin/pull/32587#discussion_r2135597231)
same here

💬 glozow commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2955614286)

After weighing the technical arguments for/against this change and considering the objections [0], I believe this is ready for merge. Below is my handwritten summary outlining why I think so. I’m including (non-exhaustive list of) links where possible, so if you’d like to analyze the same sources without my personal bias, please do.

The concept was discussed here, #32359, #28130, #32381, the mailing list / google group [1], delving [2][3][4], stacker news [5], twitter, etc.

The primary m
...

💬 vasild commented on pull request "Fuzz: extend CConnman tests":
(https://github.com/bitcoin/bitcoin/pull/28584#issuecomment-2955631074)
`582d9e3dbd...0802398e74`: rebase and address suggestions

💬 vasild commented on pull request "Fuzz: extend CConnman tests":
(https://github.com/bitcoin/bitcoin/pull/28584#discussion_r2135618533)
Done, thanks!

💬 vasild commented on pull request "Fuzz: extend CConnman tests":
(https://github.com/bitcoin/bitcoin/pull/28584#discussion_r2135621956)
Added a fake/fuzzed `NetEventsInterface` that is created and destroyed per every run, like the test connman itself. That addresses the "out of memory eventually" concern as well. Thanks!

🚀 glozow merged a pull request: "policy: uncap datacarrier by default"
(https://github.com/bitcoin/bitcoin/pull/32406)

💬 maflcko commented on pull request "rpc, doc: update `listdescriptors` RCP help":
(https://github.com/bitcoin/bitcoin/pull/32708#issuecomment-2955662363)
lgtm ACK b44514b876333a94ae242da8b1e4cee439c2d37e

⚠️ fanquake opened an issue: "qt: translation related warnings"
(https://github.com/bitcoin/bitcoin/issues/32710)
master @ f3bbc746647d1fd23bf5cfe357e32f38c5f6319c
```bash
# cmake -B build -DBUILD_GUI=ON
CMake Warning at /opt/homebrew/opt/qt/lib/cmake/Qt6LinguistTools/Qt6LinguistToolsMacros.cmake:393 (message):
Failed to resolve language code for
/bitcoin/src/qt/locale/bitcoin_no.ts. Please update
CFBundleLocalizations in your Info.plist manually.
Call Stack (most recent call first):
/opt/homebrew/opt/qt/lib/cmake/Qt6LinguistTools/Qt6LinguistToolsMacros.cmake:596 (_qt_internal_store_languages_from_
...

💬 fanquake commented on issue "qt: translation related warnings":
(https://github.com/bitcoin/bitcoin/issues/32710#issuecomment-2955683945)
These are also happening in the CI. ie https://cirrus-ci.com/task/5819006470324224?logs=ci#L822:
```bash
[08:26:39.652] -- The OBJCXX compiler identification is Clang 18.1.3
[08:26:39.722] -- Detecting OBJCXX compiler ABI info
[08:26:40.007] -- Detecting OBJCXX compiler ABI info - done
[08:26:40.027] -- Check for working OBJCXX compiler: /usr/bin/clang++ - skipped
[08:26:40.055] CMake Warning at depends/x86_64-apple-darwin/native/lib/cmake/Qt6LinguistTools/Qt6LinguistToolsMacros.cmake:418 (messa
...

📝 theStack opened a pull request: "doc: add missing packages for BSDs (cmake, gmake, curl) to depends/README.md"
(https://github.com/bitcoin/bitcoin/pull/32711)
Suggested initially only for OpenBSD and cmake (see https://github.com/bitcoin/bitcoin/pull/32690#issuecomment-2949660658, https://github.com/bitcoin/bitcoin/pull/32690#issuecomment-2949729126), this PR adds missing package recommendations for other BSDs as well in order to build depends. I tested this only on OpenBSD, but found the package names for the other BDSs on the ports search engines:
* FreeBSD: https://ports.freebsd.org/cgi/ports.cgi
* NetBSD: https://ftp.netbsd.org/pub/pkgsrc/curren
...

🚀 fanquake merged a pull request: "[27.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/32479)

💬 maflcko commented on pull request "doc: add missing packages for BSDs (cmake, gmake, curl) to depends/README.md":
(https://github.com/bitcoin/bitcoin/pull/32711#issuecomment-2955731746)
lgtm ACK f8ff5690212866597958a52d4cd049d66e51d9fd

💬 Crypt-iQ commented on pull request "log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError":
(https://github.com/bitcoin/bitcoin/pull/32604#discussion_r2135685134)
Oh I completely misunderstood! I like this suggestion a lot and I think it plugs the hole. I am not sure the future plans for `LogPrintLevel` but I wonder if eventually all instances of `LogPrintLevel` with level >= `BCLog::Info` could instead be converted to `LogInfo` or the equivalent?

🤔 prasincs reviewed a pull request: "BIP-119 (OP_CHECKTEMPLATEVERIFY) (regtest only)"
(https://github.com/bitcoin/bitcoin/pull/31989#pullrequestreview-2910009061)
Concept ACK. Strongly support getting this in Regtest and Signet and doing further battle testing

💬 prasincs commented on pull request "BIP-119 (OP_CHECKTEMPLATEVERIFY) (regtest only)":
(https://github.com/bitcoin/bitcoin/pull/31989#discussion_r2135683944)
Possibly nit: since other elements in the array are using designated initializers, commenting the field names isn't necessary. Since the prior element in array would fail to compile on < C++20