💬 luke-jr commented on pull request "fs: use `ftruncate` in `AllocateFileRange` on OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/32645#discussion_r2132921035)
We're already calling fallocate here... seems like this whole #if mess should be sorted out.

💬 luke-jr commented on pull request "fs: use `ftruncate` in `AllocateFileRange` on OpenBSD":
(https://github.com/bitcoin/bitcoin/pull/32645#discussion_r2132921703)
`ftruncate` isn't OpenBSD-specific. We should just check its availability and use it on platforms that support it (after preferred methods are ruled out)

💬 chrisguida commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2950849431)
Hi @darosior -

As you are well aware, your "list" here is nowhere close to a steelman of the opposition to this PR.

You have yet to address anything in my responses to your Delving post.

I remain a firm Concept NACK.

💬 achow101 commented on pull request "test: wallet: cover wallet passphrase with a null char":
(https://github.com/bitcoin/bitcoin/pull/32675#issuecomment-2950920751)
ACK 7cfbb8575e1ffbad5c48e2c461b45dd6ac63d064

🚀 achow101 merged a pull request: "test: wallet: cover wallet passphrase with a null char"
(https://github.com/bitcoin/bitcoin/pull/32675)

💬 achow101 commented on pull request "init: Configure reachable networks before we start the RPC server":
(https://github.com/bitcoin/bitcoin/pull/32539#issuecomment-2950964098)
ACK 12ff4be9c724c752fe67835419be3ff4d0e65990

✅ achow101 closed an issue: ""rpcallowip=" configuration directive doesn't accept RFC4193 addresses"
(https://github.com/bitcoin/bitcoin/issues/32433)

🚀 achow101 merged a pull request: "init: Configure reachable networks before we start the RPC server"
(https://github.com/bitcoin/bitcoin/pull/32539)

💬 davidgumberg commented on pull request "wallet: Keep track of the wallet's own transaction outputs in memory":
(https://github.com/bitcoin/bitcoin/pull/27286#discussion_r2132983477)
My mistake, that makes sense.

⚠️ harryvik990 opened an issue: "My main"
(https://github.com/bitcoin/bitcoin/issues/32695)

📝 luisschwab opened a pull request: "doc: make `-DWITH_ZMQ=ON` explicit on `build-unix.md`"
(https://github.com/bitcoin/bitcoin/pull/32696)
ZMQ support is not built by default on Linux, and the docs don't make that clear. This PR makes it explicit that the `-DWITH_ZMQ=ON` flag is required to build with ZMQ support on `build-unix.md`.

💬 BitcoinMechanic commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2951144895)
Hi @darosier nowhere in your comprehensive rebuttal do you mention that **>99% of OP RETURNs in the chain fit within the limit imposed by the existing filter**

That is **despite the fact that people are deliberately trying to demonstrate how "useless" filters are by going out of band to get miners to manually add this stuff to their block templates**.

It's very simple: before you merge this PR, most OP RETURNs will be limited to 80 bytes or less.

If it gets merged, there will be a massi
...

💬 davidgumberg commented on pull request "wallet: Keep track of the wallet's own transaction outputs in memory":
(https://github.com/bitcoin/bitcoin/pull/27286#issuecomment-2951194040)
reACK https://github.com/bitcoin/bitcoin/commit/ec25de35b2a51b493d36452f75096f790230a4e9

Reviewed range-diff (`git range-diff 3973425...ec25de35`), addresses all the nits I left in my previous review that were correct. Mainly, the benchmark iterations are no longer unnecessarily hardcoded, two transaction level checks that were being performed per-output in `AvailableCoins()` are now part of the cached tx-level checks, and stylistically, code was moved to more closely resemble the order of c
...

✅ hebasto closed an issue: "."
(https://github.com/bitcoin/bitcoin/issues/32695)

💬 maflcko commented on pull request "doc: make `-DWITH_ZMQ=ON` explicit on `build-unix.md`":
(https://github.com/bitcoin/bitcoin/pull/32696#issuecomment-2951916899)
lgtm ACK 32d4e92b9ac81858d754487bfec2fef6bed13a57

📝 maflcko opened a pull request: " test: Turn util/test_runner into functional test "
(https://github.com/bitcoin/bitcoin/pull/32697)
The `test/util/test_runner.py` has many issues:

* The boilerplate for the test runner is duplicate or inconsistent with the other (functional) tests. For example, logging options, config file handling, ...
* The cmake/ci behavior is brittle and can silently fail, as explained in https://github.com/bitcoin/bitcoin/issues/31476
* corecheck (and likely other places that manually run the tests) completely forget to run it
* If the test is manually called, it runs single threaded, when it could
...

⚠️ JeremyRand opened an issue: "Developer Notes don't give advice on initialisms in class/function/method names"
(https://github.com/bitcoin/bitcoin/issues/32698)
### Please describe the feature you'd like to see added.

The developer notes say that class/function/method names in newly added code should be UpperCamelCase:

https://github.com/bitcoin/bitcoin/blob/e2174378aa8a339c7be8b4e91311513ed520a16d/doc/developer-notes.md?plain=1#L98-L99

However, no recommendation is given for initialisms in class/function/method names. Searching DuckDuckGo for "camelcase" indicates a general consensus that the term "CamelCase" does not imply any particular policy her
...

💬 maflcko commented on pull request "ci, iwyu: Treat warnings as errors for specific directories":
(https://github.com/bitcoin/bitcoin/pull/31308#issuecomment-2952262151)
lgtm, except for the two missing includes

re-ACK ec42fb489a7eabed4dec155c6655d36114fa67ba 👜

<details><summary>Show signature</summary>

Signature:

```
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
...

💬 maflcko commented on pull request "test: Turn util/test_runner into functional test":
(https://github.com/bitcoin/bitcoin/pull/32697#issuecomment-2952272882)
<details><summary>rant</summary>


force pushed to fix a python type related error after an error. Stuff like this wouldn't happen in a type-safe language.

```
logging.error("OSError, Failed to execute " + execprog)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
TypeError: can only concatenate str (not "list") to str
```

</details>

💬 fanquake commented on pull request "[28.x] 28.2rc2":
(https://github.com/bitcoin/bitcoin/pull/32684#discussion_r2133703110)
Added.