💬 ryanofsky commented on pull request "Add bitcoin-{node,gui} to release binaries for IPC":
(https://github.com/bitcoin/bitcoin/pull/31802#issuecomment-2873513948)
re: Sjors https://github.com/bitcoin/bitcoin/pull/31802#issuecomment-2858241771
> @ryanofsky CI complains about `std::move` in `libmultiprocess`: https://cirrus-ci.com/task/6187773452877824, e.g.:
Thanks for catching this. I implemented a fix for that error and the other errors in https://github.com/bitcoin-core/libmultiprocess/pull/172
If you wanted to test the fix here you could do:
```shell
git fetch https://github.com/bitcoin-core/libmultiprocess 8d8e9f65f1d9faaafe91ca90910c1f96
...
(https://github.com/bitcoin/bitcoin/pull/31802#issuecomment-2873513948)
re: Sjors https://github.com/bitcoin/bitcoin/pull/31802#issuecomment-2858241771
> @ryanofsky CI complains about `std::move` in `libmultiprocess`: https://cirrus-ci.com/task/6187773452877824, e.g.:
Thanks for catching this. I implemented a fix for that error and the other errors in https://github.com/bitcoin-core/libmultiprocess/pull/172
If you wanted to test the fix here you could do:
```shell
git fetch https://github.com/bitcoin-core/libmultiprocess 8d8e9f65f1d9faaafe91ca90910c1f96
...
💬 xstoicunicornx commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873550444)
>Bitcoin’s success hinges on its decentralization and accessibility.
>Moreover, out-of-band services that cater to data-carrier transactions are not inherently harmful to the network. They exist because Bitcoin was intentionally not designed as a general-purpose data storage layer, but rather as a secure payments system. Private markets offering these services reflect a willingness to pay for non-standard transactions, and this market demand does not justify altering Bitcoin’s core design to
...
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873550444)
>Bitcoin’s success hinges on its decentralization and accessibility.
>Moreover, out-of-band services that cater to data-carrier transactions are not inherently harmful to the network. They exist because Bitcoin was intentionally not designed as a general-purpose data storage layer, but rather as a secure payments system. Private markets offering these services reflect a willingness to pay for non-standard transactions, and this market demand does not justify altering Bitcoin’s core design to
...
💬 instagibbs commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873582873)
@xstoicunicornx It's LLM spam
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873582873)
@xstoicunicornx It's LLM spam
💬 sipa commented on pull request "Introduce per-txin sighash midstate cache for legacy/p2sh/segwitv0 scripts":
(https://github.com/bitcoin/bitcoin/pull/32473#discussion_r2085229102)
Hmm, this didn't change between legacy and witv0, I think?
(https://github.com/bitcoin/bitcoin/pull/32473#discussion_r2085229102)
Hmm, this didn't change between legacy and witv0, I think?
💬 joshdoman commented on pull request "[Policy] Discourage Unsigned Annexes":
(https://github.com/bitcoin/bitcoin/pull/32453#issuecomment-2873627043)
@JeremyRubin I think this is a great idea. I made a PR into Peter Todd's repo doing something similar, which may or may not be useful (https://github.com/petertodd/bitcoin/pull/10).
Primary difference is I modified execdata like @instagibbs described and add a single line `execdata.m_annex_committed = execdata.m_annex_present;` to the end of CheckSchnorrSignature. This eliminates ~6 lines of code.
(https://github.com/bitcoin/bitcoin/pull/32453#issuecomment-2873627043)
@JeremyRubin I think this is a great idea. I made a PR into Peter Todd's repo doing something similar, which may or may not be useful (https://github.com/petertodd/bitcoin/pull/10).
Primary difference is I modified execdata like @instagibbs described and add a single line `execdata.m_annex_committed = execdata.m_annex_present;` to the end of CheckSchnorrSignature. This eliminates ~6 lines of code.
👍 pinheadmz approved a pull request: "doc: Fix typo"
(https://github.com/bitcoin/bitcoin/pull/32472#pullrequestreview-2834167326)
utACK trivial typo fix in error string
(https://github.com/bitcoin/bitcoin/pull/32472#pullrequestreview-2834167326)
utACK trivial typo fix in error string
💬 pinheadmz commented on pull request "config: allow setting -proxy per network":
(https://github.com/bitcoin/bitcoin/pull/32425#discussion_r2085261557)
Since you're touching this doc, you could also add a note about UNIX sockets which I should've added in #27375 ;-)
e.g.
```
UNIX domain sockets may be used for proxy connections. Set `-onion` or `-proxy`
to the local socket path with the prefix `unix:` (e.g. `-onion=unix:/home/me/torsocket`).
```
(https://github.com/bitcoin/bitcoin/pull/32425#discussion_r2085261557)
Since you're touching this doc, you could also add a note about UNIX sockets which I should've added in #27375 ;-)
e.g.
```
UNIX domain sockets may be used for proxy connections. Set `-onion` or `-proxy`
to the local socket path with the prefix `unix:` (e.g. `-onion=unix:/home/me/torsocket`).
```
🚀 fanquake merged a pull request: "doc: Fix typo"
(https://github.com/bitcoin/bitcoin/pull/32472)
(https://github.com/bitcoin/bitcoin/pull/32472)
🚀 fanquake merged a pull request: "guix: move `*-check.py` scripts under contrib/guix/"
(https://github.com/bitcoin/bitcoin/pull/32458)
(https://github.com/bitcoin/bitcoin/pull/32458)
💬 copy2018 commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873664099)
> These two statements are incongruent with each other, as out-of-band services directly undermine the decentralization and accessibility of the network by eroding the transparency of the fee market as well as miner rewards.
It’s true that out-of-band services introduce inefficiencies or opacity, but they do not fundamentally undermine Bitcoin’s decentralization in the same way that relaxing the datacarriersize limit would. Out-of-band services operate as opt-in, market-driven solutions tailo
...
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873664099)
> These two statements are incongruent with each other, as out-of-band services directly undermine the decentralization and accessibility of the network by eroding the transparency of the fee market as well as miner rewards.
It’s true that out-of-band services introduce inefficiencies or opacity, but they do not fundamentally undermine Bitcoin’s decentralization in the same way that relaxing the datacarriersize limit would. Out-of-band services operate as opt-in, market-driven solutions tailo
...
👋 fanquake's pull request is ready for review: "[28.x] Backports"
(https://github.com/bitcoin/bitcoin/pull/32299)
(https://github.com/bitcoin/bitcoin/pull/32299)
🤔 hebasto reviewed a pull request: "guix: move `*-check.py` scripts under contrib/guix/"
(https://github.com/bitcoin/bitcoin/pull/32458#pullrequestreview-2834190263)
My Guix build:
```
aarch64
f15ff81485789fe4fa22c3ecf887cfbfa0b3ae8620fd8c8926deb257ef19cff9 guix-build-415650cea94f/output/aarch64-linux-gnu/SHA256SUMS.part
7320f11f0ff5005d841dc2d854f46c5d317df077dae41b4631493f090b34875c guix-build-415650cea94f/output/aarch64-linux-gnu/bitcoin-415650cea94f-aarch64-linux-gnu-debug.tar.gz
af696399978c60a9517006c8435d8053b541b3dcfec49dacaa46932404d22b7b guix-build-415650cea94f/output/aarch64-linux-gnu/bitcoin-415650cea94f-aarch64-linux-gnu.tar.gz
6da90889
...
(https://github.com/bitcoin/bitcoin/pull/32458#pullrequestreview-2834190263)
My Guix build:
```
aarch64
f15ff81485789fe4fa22c3ecf887cfbfa0b3ae8620fd8c8926deb257ef19cff9 guix-build-415650cea94f/output/aarch64-linux-gnu/SHA256SUMS.part
7320f11f0ff5005d841dc2d854f46c5d317df077dae41b4631493f090b34875c guix-build-415650cea94f/output/aarch64-linux-gnu/bitcoin-415650cea94f-aarch64-linux-gnu-debug.tar.gz
af696399978c60a9517006c8435d8053b541b3dcfec49dacaa46932404d22b7b guix-build-415650cea94f/output/aarch64-linux-gnu/bitcoin-415650cea94f-aarch64-linux-gnu.tar.gz
6da90889
...
💬 jesterhodl commented on pull request "doc: Fix typo":
(https://github.com/bitcoin/bitcoin/pull/32472#issuecomment-2873670146)
Thanks :-)
(https://github.com/bitcoin/bitcoin/pull/32472#issuecomment-2873670146)
Thanks :-)
🤔 hebasto reviewed a pull request: "guix: move `*-check.py` scripts under contrib/guix/"
(https://github.com/bitcoin/bitcoin/pull/32458#pullrequestreview-2834192070)
Post-merge ACK 415650cea94f5050d7c368fdf9fd9878809957e1.
(https://github.com/bitcoin/bitcoin/pull/32458#pullrequestreview-2834192070)
Post-merge ACK 415650cea94f5050d7c368fdf9fd9878809957e1.
💬 polespinasa commented on pull request "rpc: generatetomany":
(https://github.com/bitcoin/bitcoin/pull/32468#issuecomment-2873672475)
> * `generateblock` is much more flexible than `generatetoaddress` (or `generatetodescriptor`), since it takes the txs to include as the second argument. For advanced test cases, it is likely that users would want this functionality to test multiple output coinbases with blocks that mine non-standard txs or otherwise don't mine the entire mempool. They would not have this capability with `generatetomany` as implemented here, but would have that for free with `generateblock`.
This is a fair po
...
(https://github.com/bitcoin/bitcoin/pull/32468#issuecomment-2873672475)
> * `generateblock` is much more flexible than `generatetoaddress` (or `generatetodescriptor`), since it takes the txs to include as the second argument. For advanced test cases, it is likely that users would want this functionality to test multiple output coinbases with blocks that mine non-standard txs or otherwise don't mine the entire mempool. They would not have this capability with `generatetomany` as implemented here, but would have that for free with `generateblock`.
This is a fair po
...
💬 moth-oss commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873678445)
> @moth-oss config options are not removed in this pull request.
It is deprecating the option though. I don't think deprecating it now is the right move. Increase the default (ideally not disabled/max) and see how things go before making the decision to deprecate it.
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873678445)
> @moth-oss config options are not removed in this pull request.
It is deprecating the option though. I don't think deprecating it now is the right move. Increase the default (ideally not disabled/max) and see how things go before making the decision to deprecate it.
🤔 glozow reviewed a pull request: "cluster mempool: add txgraph diagrams/mining/eviction"
(https://github.com/bitcoin/bitcoin/pull/31444#pullrequestreview-2834208934)
ACK 7208ec2f1f0
Light code review + tested by [implementing](https://github.com/glozow/bitcoin/commits/2025-04-package-validation/) a package linearizer + chunker on top of `TxGraph` and running #26711 unit tests. It is linearizing and chunking the transactions as I expect, which is great (it still has trouble with cases like RBF, chunks not fitting, and skipping non-descendants, but definitely out of scope for this PR).
(https://github.com/bitcoin/bitcoin/pull/31444#pullrequestreview-2834208934)
ACK 7208ec2f1f0
Light code review + tested by [implementing](https://github.com/glozow/bitcoin/commits/2025-04-package-validation/) a package linearizer + chunker on top of `TxGraph` and running #26711 unit tests. It is linearizing and chunking the transactions as I expect, which is great (it still has trouble with cases like RBF, chunks not fitting, and skipping non-descendants, but definitely out of scope for this PR).
💬 darosior commented on pull request "Introduce per-txin sighash midstate cache for legacy/p2sh/segwitv0 scripts":
(https://github.com/bitcoin/bitcoin/pull/32473#discussion_r2085282675)
It did, legacy skips `OP_CODESEPARATOR`s in the suffix (i.e. "upcoming `CODESEP`s") whereas Segwit v0 doesn't.
(https://github.com/bitcoin/bitcoin/pull/32473#discussion_r2085282675)
It did, legacy skips `OP_CODESEPARATOR`s in the suffix (i.e. "upcoming `CODESEP`s") whereas Segwit v0 doesn't.
💬 willcl-ark commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873707039)
Reminder that this project's current [moderation guidelines](https://github.com/bitcoin-core/meta/blob/main/MODERATION-GUIDELINES.md) describe what we expect of contributors to this repository.
To keep it productive, especially on threads like these please:
- Stay on-topic: discuss the patch, not Bitcoin in general.
- Critique ideas, not motives.
- Contribute new signal: avoid repeating arguments already made earlier (these will start being marked as duplicate, to make the thread easier
...
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873707039)
Reminder that this project's current [moderation guidelines](https://github.com/bitcoin-core/meta/blob/main/MODERATION-GUIDELINES.md) describe what we expect of contributors to this repository.
To keep it productive, especially on threads like these please:
- Stay on-topic: discuss the patch, not Bitcoin in general.
- Critique ideas, not motives.
- Contribute new signal: avoid repeating arguments already made earlier (these will start being marked as duplicate, to make the thread easier
...
💬 sipa commented on pull request "Introduce per-txin sighash midstate cache for legacy/p2sh/segwitv0 scripts":
(https://github.com/bitcoin/bitcoin/pull/32473#discussion_r2085298526)
Ah, yes, but this all happens before the call to `LegacySignatureMsg()`, which filters out the `OP_CODESEPARATOR`s that remain. In either case, this function `default_scriptcode_suffix` is exercised for both p2wsh and p2sh, so the fact that the test works should mean something...
(https://github.com/bitcoin/bitcoin/pull/32473#discussion_r2085298526)
Ah, yes, but this all happens before the call to `LegacySignatureMsg()`, which filters out the `OP_CODESEPARATOR`s that remain. In either case, this function `default_scriptcode_suffix` is exercised for both p2wsh and p2sh, so the fact that the test works should mean something...
💬 1440000bytes commented on pull request "policy: uncap datacarrier by default":
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873734612)
> > @moth-oss config options are not removed in this pull request.
>
> It is deprecating the option though. I don't think deprecating it now is the right move. Increase the default (ideally not disabled/max) and see how things go before making the decision to deprecate it.
Deprecation notice can last for years: https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2861778194
(https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2873734612)
> > @moth-oss config options are not removed in this pull request.
>
> It is deprecating the option though. I don't think deprecating it now is the right move. Increase the default (ideally not disabled/max) and see how things go before making the decision to deprecate it.
Deprecation notice can last for years: https://github.com/bitcoin/bitcoin/pull/32406#issuecomment-2861778194