Bitcoin Core Github
42 subscribers
126K links
Download Telegram
⚠️ 69690000 opened an issue: "Tttbbb"
(https://github.com/bitcoin/bitcoin/issues/32171)
### Motivation

[export-0x71c7656ec7ab88b098defb751b7401b5f6d8976f.docx](https://github.com/user-attachments/files/19527909/export-0x71c7656ec7ab88b098defb751b7401b5f6d8976f.docx)

### Possible solution

_No response_

### Useful Skills

* Compiling Bitcoin Core from source
* Running the C++ unit tests and the Python functional tests
* ...


### Guidance for new contributors

Want to work on this issue?

For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitco
...
fanquake closed an issue: "Tttbbb"
(https://github.com/bitcoin/bitcoin/issues/32169)
fanquake closed an issue: "Tttbbb"
(https://github.com/bitcoin/bitcoin/issues/32170)
fanquake closed an issue: "Tttbbb"
(https://github.com/bitcoin/bitcoin/issues/32171)
:lock: fanquake locked an issue: "Tttbbb"
(https://github.com/bitcoin/bitcoin/issues/32171)
:lock: fanquake locked an issue: "(removed)"
(https://github.com/bitcoin/bitcoin/issues/32165)
⚠️ mwsmitty opened an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/32172)
fanquake closed an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/32172)
:lock: fanquake locked an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/32172)
💬 fanquake commented on issue "oss-fuzz build fails":
(https://github.com/bitcoin/bitcoin/issues/32167#issuecomment-2764941875)
Looks like it's fixed by removing the workarounds on the oss-fuzz side: https://github.com/google/oss-fuzz/pull/13187.
💬 stratospher commented on pull request "validation: set BLOCK_FAILED_CHILD correctly":
(https://github.com/bitcoin/bitcoin/pull/31835#discussion_r2020368714)
updated it to look like prev pointers. I thought of it as block heights growing but prev pointers are more accurate/less confusing.
💬 stratospher commented on pull request "validation: set BLOCK_FAILED_CHILD correctly":
(https://github.com/bitcoin/bitcoin/pull/31835#discussion_r2020368826)
done.
💬 ryanofsky commented on pull request "multiprocess: Add libmultiprocess git subtree":
(https://github.com/bitcoin/bitcoin/pull/31741#issuecomment-2765000837)
Rebased 4e265debdc0319bbfcea915d9026b33810b810f8 -> 625bd576215e82d430998bfa68501db7ba03c3b2 ([`pr/subtree.25`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree.25) -> [`pr/subtree.26`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree.26), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/subtree.25-rebase..pr/subtree.26)) due to conflict with #31992
👍 rkrux approved a pull request: "descriptors: Multipath/PR 22838 follow-ups"
(https://github.com/bitcoin/bitcoin/pull/32134#pullrequestreview-2728250898)
crACK 56f271e9b9c82f40054d63d4b638584bd2faef00

Overall, I believe this change leaves the code in a more readable state.
💬 rkrux commented on pull request "descriptors: Multipath/PR 22838 follow-ups":
(https://github.com/bitcoin/bitcoin/pull/32134#discussion_r2020415005)
I'd have used `multipath_substitutes` at the cost of being a bit more verbose but this is also fine.
💬 rkrux commented on pull request "descriptors: Multipath/PR 22838 follow-ups":
(https://github.com/bitcoin/bitcoin/pull/32134#discussion_r2020415960)
Using `substitutes` seems reasonable to me as the calculated derivation path indices are indeed substituting the multipath specifier `*`.
💬 rkrux commented on pull request "descriptors: Multipath/PR 22838 follow-ups":
(https://github.com/bitcoin/bitcoin/pull/32134#discussion_r2020423324)
+1 for using `placeholder`, makes it easier to follow.
📝 whitslack opened a pull request: "cmake: support `-DBUILD_GUI=qt6`"
(https://github.com/bitcoin-core/gui/pull/861)
This PR adds support in `CMakeLists.txt` for `-DBUILD_GUI=qt6` to allow building against system-installed Qt6 libraries in distributions that are dropping support for Qt5 (such as [Gentoo](https://bugs.gentoo.org/948836)).

I specify Qt 6.2.4 as a minimum requirement based on the work in bitcoin/bitcoin#24798, but I do not know whether Bitcoin Core currently builds against such an old version of Qt6. I have successfully built v29.0rc2 against Qt 6.8.3.
fanquake closed a pull request: "cmake: support `-DBUILD_GUI=qt6`"
(https://github.com/bitcoin-core/gui/pull/861)
💬 fanquake commented on pull request "cmake: support `-DBUILD_GUI=qt6`":
(https://github.com/bitcoin-core/gui/pull/861#issuecomment-2765196621)
Thanks, however the changes to switch to Qt6 are being done in https://github.com/bitcoin/bitcoin/pull/30997.
💬 fanquake commented on pull request "cmake: support `-DBUILD_GUI=qt6`":
(https://github.com/bitcoin-core/gui/pull/861#issuecomment-2765197200)
(There are no plans to support both qt 5 & 6 at the same time.