💬 fjahr commented on pull request "index: Fix coinstats overflow and introduce index versioning":
(https://github.com/bitcoin/bitcoin/pull/30469#issuecomment-2764743201)
Picking this up again after this has gone a bit quiet for a while. After having a brief conversation about it with @mzumsande at CoreDev I took another look at his migration idea. Initially I was a bit undecided honestly but I now think that it's reasonable to try this and I would like to open this up for additional approach feedback from other reviewers. Aside from a rebase this has now cherry-picked @mzumsande 's draft commit with minor changes by me and I adapted the tests to check the new be
...

✅ tnndbtc closed a pull request: "miniscript: fixes #29098 by only use first k valid signatures"
(https://github.com/bitcoin/bitcoin/pull/31719)

📝 tnndbtc reopened a pull request: "miniscript: fixes #29098 by only use first k valid signatures"
(https://github.com/bitcoin/bitcoin/pull/31719)
In issue #29098 a recommendation is not to use "best (smallest) set of k signatures". So, this effort is to fall back to the original algorithm which only use the first k available signatures for satisfying a k-of-n multisig. Otherwise, there will be timeout in unit test when we have 999-of-999 use case.

Profiling has been done on Mac to confirm the most time consuming function is in internal::InputResult ProduceInput.

Following tests will hit the affected code:

- ctest --test-dir bui
...

⚠️ 69690000 opened an issue: "Tttbbb"
(https://github.com/bitcoin/bitcoin/issues/32169)
### Motivation

Tttbbb

### Possible solution

_No response_

### Useful Skills

* Compiling Bitcoin Core from source
* Running the C++ unit tests and the Python functional tests
* ...


### Guidance for new contributors

Want to work on this issue?

For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.

⚠️ 69690000 opened an issue: "Tttbbb"
(https://github.com/bitcoin/bitcoin/issues/32170)
### Motivation

apr-bc14855e34295b96f158e8c62a2b11cd : ibq1wtpQd4kxKB6LkKmfe0pDN3euGdZS

### Possible solution

_No response_

### Useful Skills

* Compiling Bitcoin Core from source
* Running the C++ unit tests and the Python functional tests
* ...


### Guidance for new contributors

Want to work on this issue?

For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.

⚠️ 69690000 opened an issue: "Tttbbb"
(https://github.com/bitcoin/bitcoin/issues/32171)
### Motivation

[export-0x71c7656ec7ab88b098defb751b7401b5f6d8976f.docx](https://github.com/user-attachments/files/19527909/export-0x71c7656ec7ab88b098defb751b7401b5f6d8976f.docx)

### Possible solution

_No response_

### Useful Skills

* Compiling Bitcoin Core from source
* Running the C++ unit tests and the Python functional tests
* ...


### Guidance for new contributors

Want to work on this issue?

For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitco
...

✅ fanquake closed an issue: "Tttbbb"
(https://github.com/bitcoin/bitcoin/issues/32169)

✅ fanquake closed an issue: "Tttbbb"
(https://github.com/bitcoin/bitcoin/issues/32170)

✅ fanquake closed an issue: "Tttbbb"
(https://github.com/bitcoin/bitcoin/issues/32171)

:lock: fanquake locked an issue: "Tttbbb"
(https://github.com/bitcoin/bitcoin/issues/32171)

:lock: fanquake locked an issue: "(removed)"
(https://github.com/bitcoin/bitcoin/issues/32165)

⚠️ mwsmitty opened an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/32172)

✅ fanquake closed an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/32172)

:lock: fanquake locked an issue: "Bitcoin"
(https://github.com/bitcoin/bitcoin/issues/32172)

💬 fanquake commented on issue "oss-fuzz build fails":
(https://github.com/bitcoin/bitcoin/issues/32167#issuecomment-2764941875)
Looks like it's fixed by removing the workarounds on the oss-fuzz side: https://github.com/google/oss-fuzz/pull/13187.

💬 stratospher commented on pull request "validation: set BLOCK_FAILED_CHILD correctly":
(https://github.com/bitcoin/bitcoin/pull/31835#discussion_r2020368714)
updated it to look like prev pointers. I thought of it as block heights growing but prev pointers are more accurate/less confusing.

💬 stratospher commented on pull request "validation: set BLOCK_FAILED_CHILD correctly":
(https://github.com/bitcoin/bitcoin/pull/31835#discussion_r2020368826)
done.

💬 ryanofsky commented on pull request "multiprocess: Add libmultiprocess git subtree":
(https://github.com/bitcoin/bitcoin/pull/31741#issuecomment-2765000837)
Rebased 4e265debdc0319bbfcea915d9026b33810b810f8 -> 625bd576215e82d430998bfa68501db7ba03c3b2 ([`pr/subtree.25`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree.25) -> [`pr/subtree.26`](https://github.com/ryanofsky/bitcoin/commits/pr/subtree.26), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/subtree.25-rebase..pr/subtree.26)) due to conflict with #31992

👍 rkrux approved a pull request: "descriptors: Multipath/PR 22838 follow-ups"
(https://github.com/bitcoin/bitcoin/pull/32134#pullrequestreview-2728250898)
crACK 56f271e9b9c82f40054d63d4b638584bd2faef00

Overall, I believe this change leaves the code in a more readable state.

💬 rkrux commented on pull request "descriptors: Multipath/PR 22838 follow-ups":
(https://github.com/bitcoin/bitcoin/pull/32134#discussion_r2020415005)
I'd have used `multipath_substitutes` at the cost of being a bit more verbose but this is also fine.

💬 rkrux commented on pull request "descriptors: Multipath/PR 22838 follow-ups":
(https://github.com/bitcoin/bitcoin/pull/32134#discussion_r2020415960)
Using `substitutes` seems reasonable to me as the calculated derivation path indices are indeed substituting the multipath specifier `*`.