💬 laanwj commented on pull request "build: Switch to Qt 6":
(https://github.com/bitcoin/bitcoin/pull/30997#issuecomment-2764240416)
i built with the following patch to set a UTF-8 locale check if there would be a difference:
```patch
diff --git a/contrib/guix/libexec/build.sh b/contrib/guix/libexec/build.sh
index 26180bae24..47366c7e11 100755
--- a/contrib/guix/libexec/build.sh
+++ b/contrib/guix/libexec/build.sh
@@ -2,7 +2,8 @@
# Copyright (c) 2019-2022 The Bitcoin Core developers
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.p
...

👍 TheCharlatan approved a pull request: "validation: stricter internal handling of invalid blocks"
(https://github.com/bitcoin/bitcoin/pull/31405#pullrequestreview-2727393482)
crACK 7b6fe5a2196d53a3024dfe7f11b316a50acc3cb7

This reduces complexity overall and I am happy that the slightly verbose block in `AcceptBlockHeader` and the `m_dirty_blockindex` are gone. It is not really straight forward to review though and I hope I did not miss any edge cases or real performance drawbacks. Might be good to get some more eyes on this. Having a better abstraction on the BlockMap / block tree data structure that just handles all of this internally could make things easier in
...

💬 TheCharlatan commented on pull request "validation: stricter internal handling of invalid blocks":
(https://github.com/bitcoin/bitcoin/pull/31405#discussion_r2019820910)
In commit fbe9e2a391d5f6e14998776b03d4ffbbf43f33c8:

Nit: Should this change really be in this commit? It does make sense in the next commit. I don't think it would be a bug per se to never erase, but it might be less efficient.

📝 olaristo109 opened a pull request: "Grammatical typos in benchmarking.md"
(https://github.com/bitcoin/bitcoin/pull/32163)
docs: Corrected grammatical and stylistic errors in benchmarking.md

This commit addresses several grammatical typos and improves the clarity and readability of the benchmarking.md documentation. It also standardizes terminology
# On branch grammatical_typos_in_benchmarking.md
# Changes to be committed:
# modified: doc/benchmarking.md
#

✅ pinheadmz closed a pull request: "Grammatical typos in benchmarking.md"
(https://github.com/bitcoin/bitcoin/pull/32163)

💬 pinheadmz commented on pull request "Grammatical typos in benchmarking.md":
(https://github.com/bitcoin/bitcoin/pull/32163#issuecomment-2764255685)
Typo fixes are generally not accepted from new contributors because they are a burden on regular reviewers. I encourage you to find a more significant way to contribute to this code base and open a new PR.

See contributing and developer-notes in our docs.

📝 doug369shirey opened a pull request: "Create aws.yml"
(https://github.com/bitcoin/bitcoin/pull/32164)
<!--
UN commissioner of cryptocurrency IHL Humanitarian BeinExchange involvement since 2008 sashatoshi mr pool Mr forbes always Beinhauer born Shirey living one enternity.
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your
...

🤔 doug369shirey reviewed a pull request: "Create aws.yml"
(https://github.com/bitcoin/bitcoin/pull/32164#pullrequestreview-2727736154)
Green

> ``

💬 mabu44 commented on pull request "descriptors: Multipath/PR 22838 follow-ups":
(https://github.com/bitcoin/bitcoin/pull/32134#issuecomment-2764269830)
tACK 56f271e9b9c82f40054d63d4b638584bd2faef00

<details>
<summary>Testing procedure</summary>

```bash
./bitcoind -regtest
```
```bash
./bitcoin-cli createwallet pr32134 false true
```
```bash
./bitcoin-cli importdescriptors '[{"desc":"wpkh(tprv8ZgxMBicQKsPdGJed5SjAaeKBLjKoYKbp4E8855hsG3HNiFuaHNprjb4UmuovVsvAQ7Hwa2MdBsrgyhePCyVgMPnTgQdigFFZLCJTkNm7CK/<0;1>/*)#p5mvj4c3","timestamp":0,"range":[0,999],"active":true}]'
```
Output:
```bash
[
{
"success": true
}
]
```
```
...

✅ hebasto closed a pull request: "Create aws.yml"
(https://github.com/bitcoin/bitcoin/pull/32164)

📝 hebasto locked a pull request: "Create aws.yml"
(https://github.com/bitcoin/bitcoin/pull/32164)
<!--
UN commissioner of cryptocurrency IHL Humanitarian BeinExchange involvement since 2008 sashatoshi mr pool Mr forbes always Beinhauer born Shirey living one enternity.
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your
...

💬 fjahr commented on pull request "Embed default ASMap as binary dump header file":
(https://github.com/bitcoin/bitcoin/pull/28792#issuecomment-2764271297)
Rebased to get all the latest cmake changes and swapped the included mapping data to the [latest asmap run](https://github.com/asmap/asmap-data/pull/23). This used the `--fill` feature in encoding which leads to additional space savings. This is why the embedded data has gone down significantly from ~1.7MB to ~1.4MB.

💬 warioishere commented on issue "assumeutxo: not syncing the snapshot chainstate":
(https://github.com/bitcoin/bitcoin/issues/30971#issuecomment-2764273554)
hello, I think it doesnt help much, but assume utxo worked for me, but a 12G big chainstate_snapshot directory is left. Can I delete it? I have no more background validation logs inside my debug log an it said some hours ago:

```
2025-03-29T13:04:42Z [background validation] UpdateTip: new best=0000000000000000000320283a032748cef8227873ff4872689bf23f1cda83a5 height=840000 version=0x2a5fe000 log2_work=94.873245 tx=991032194 date='2024-04-20T00:09:27Z' progress=0.832048 cache=253.6MiB(1789616txo)

...

💬 fjahr commented on issue "assumeutxo: not syncing the snapshot chainstate":
(https://github.com/bitcoin/bitcoin/issues/30971#issuecomment-2764286415)
@warioishere The `chainstate_snapshot` directory is automatically deleted at the next restart of your node. Have you done one already? If not, please restart your node and see if it was removed. Thanks you!

💬 jirijakes commented on pull request "doc: Fix and clarify description of ZMQ message format":
(https://github.com/bitcoin/bitcoin/pull/31862#discussion_r2020060211)
I overlooked that, fixed.

💬 jirijakes commented on pull request "doc: Fix and clarify description of ZMQ message format":
(https://github.com/bitcoin/bitcoin/pull/31862#discussion_r2020060259)
Used this suggestion.

💬 jirijakes commented on pull request "doc: Fix and clarify description of ZMQ message format":
(https://github.com/bitcoin/bitcoin/pull/31862#discussion_r2020060307)
This was a very useful suggestion. Thanks!

💬 jirijakes commented on pull request "doc: Fix and clarify description of ZMQ message format":
(https://github.com/bitcoin/bitcoin/pull/31862#issuecomment-2764377913)
Reflected @ryanofsky's comments (thanks!) and used his suggestions.

- format of messages is now first outlined in a single table
- explanation of each topic follows the table in dedicated subsections
- format of numbers is consistent
- sequence numbers are referred to as either _message sequence number_ or _mempool sequence number_ to stress the difference
- the last subsection of “Usage” section is now called “Implementing ZMQ client” to separate it from previous sections; additionally,
...

⚠️ SatoshiFans888 opened an issue: "Acccedence; Double Poisson Sum†; p 0.04999579029644097"
(https://github.com/bitcoin/bitcoin/issues/32165)
Dear Bitcoin,

Wouldn't it Is the Poisson Sum shown as the periodic end or the spearhead in Bitcoin? Because it is not at all applicable to either Blockchain or what we call Cryptocurrency. Either you can really implement what the Poisson Sum is or you just have Delusions that think you understand what Satoshi Nakamoto published.

Why is it hurt by the content of my message? Let's focus on the topic ^^.

We know that the Poisson Sum has an exponential value of rational repeating but one thing
...

✅ fanquake closed an issue: "Acccedence; Double Poisson Sum†; p 0.04999579029644097"
(https://github.com/bitcoin/bitcoin/issues/32165)

💬 warioishere commented on issue "assumeutxo: not syncing the snapshot chainstate":
(https://github.com/bitcoin/bitcoin/issues/30971#issuecomment-2764480408)
> [@warioishere](https://github.com/warioishere) The `chainstate_snapshot` directory is automatically deleted at the next restart of your node. Have you done one already? If not, please restart your node and see if it was removed. Thanks you!

thanks pal I was better to read

[](https://github.com/bitcoin/bitcoin/blob/master/doc/design/assumeutxo.md?utm_source=chatgpt.com)
first hehe

Yes after restart `chainstate_snapshot` got cleaned up