💬 achow101 commented on pull request "psbt: add non-default sighash types to PSBTs and unify sighash type match checking":
(https://github.com/bitcoin/bitcoin/pull/31622#discussion_r1979941576)
I don't think it makes sense to do that here since PSBTv2 is still entirely unparseable.

💬 achow101 commented on pull request "Add assumeutxo chainparams to release-process.md":
(https://github.com/bitcoin/bitcoin/pull/31940#issuecomment-2698466564)
ACK 02fae3363511e96a76ff64a4513c7a7e8d8d4403

👍 hebasto approved a pull request: "doc: update fuzz instructions when on macOS"
(https://github.com/bitcoin/bitcoin/pull/31954#pullrequestreview-2658499705)
ACK 75486c8ed87a480b9f0c4dc7a10f3cd4eee87b12, tested on macOS 15.3.1 (Apple M1) + Clang 19.1.7.

💬 Christewart commented on pull request "kernel: pre-29.x chainparams and headerssync update":
(https://github.com/bitcoin/bitcoin/pull/31978#discussion_r1979954361)
du -csh ~/.bitcoin/testnet3/blocks/ ~/.bitcoin/testnet3/chainstate/
167G /home/chris/.bitcoin/testnet3/blocks/
13G /home/chris/.bitcoin/testnet3/chainstate/
179G total

💬 achow101 commented on pull request "kernel: pre-29.x chainparams and headerssync update":
(https://github.com/bitcoin/bitcoin/pull/31978#discussion_r1979954715)
In 570191a758bc326ae0f0a479b72759f962c0db12 "[kernel] update chainTxData for v29"

Comment needs to be updated for the block that these stats are for.

💬 davidgumberg commented on pull request "wallet: Replace "non-0" with "non-zero" in translatable error message":
(https://github.com/bitcoin/bitcoin/pull/31987#issuecomment-2698490041)
ACK https://github.com/bitcoin/bitcoin/pull/31987/commits/18e83534ace7aa2d26bc7dfa521b1d591b66edfa

💬 Morinyo1907 commented on pull request "Add mainnet assumeutxo param at height 880,000":
(https://github.com/bitcoin/bitcoin/pull/31969#issuecomment-2698513148)
> #31940 her büyük sürümde bir anlık görüntü eklenmesini öneriyor.
>
> Bu anlık görüntü v29 için uygun olmalı. 10K blokların en son katlarını seçtim.
>
> Bu torrent'i şu şekilde indirebilirsiniz:
>
> ```
> magnet:?xt=urn:btih:559bd78170502971e15e97d7572e4c824f033492&dn=utxo-880000.dat&tr=udp%3A%2F%2Ftracker.bitcoin.sprovoost.nl%3A6969
> ```
>
> Veya anlık görüntüyü kendiniz oluşturun:
>
> ```shell
> bitcoin-cli -rpcclienttimeout=0 -named dumptxoutset utxo-880000.dat rollback=88
...

💬 l0rinc commented on pull request "wallet: Replace "non-0" with "non-zero" in translatable error message":
(https://github.com/bitcoin/bitcoin/pull/31987#issuecomment-2698520197)
Concept ACK

> Since not all translations preserve "-0," this triggers a corresponding warning

How complicated would it be to align the other translations instead?

💬 jonatack commented on pull request "Add mainnet assumeutxo param at height 880,000":
(https://github.com/bitcoin/bitcoin/pull/31969#issuecomment-2698523411)
Concept ACK, shasum of the torrent file matches up and will test soon, currently am reindexing and seeing:

"Unable to load UTXO snapshot: assumeutxo block hash in snapshot metadata not recognized (hash: 000000000000000000010b17283c3c400507969a9c2afd1dcf2082ec5cca2880). The following snapshot heights are available: 840000. (utxo-880000.dat)"

💬 hebasto commented on issue "Avoid plural forms in non-GUI translatable strings (lacks `%n` support)":
(https://github.com/bitcoin/bitcoin/issues/31890#issuecomment-2698532546)
> What would you change the string to in this case?

I've asked our translators.

💬 hebasto commented on pull request "wallet: Replace "non-0" with "non-zero" in translatable error message":
(https://github.com/bitcoin/bitcoin/pull/31987#issuecomment-2698536743)
> Concept ACK
>
> > Since not all translations preserve "-0," this triggers a corresponding warning
>
> How complicated would it be to align the other translations instead?

It depends on the language. I cannot say about all of them.

💬 fanquake commented on issue "Ability to build the library":
(https://github.com/bitcoin/bitcoin/issues/31964#issuecomment-2698546421)
I think what you want is #30595?

💬 mzumsande commented on pull request "validation: stricter internal handling of invalid blocks":
(https://github.com/bitcoin/bitcoin/pull/31405#discussion_r1980008065)
There is some more discussion about this in #31835, where I wrote my opinion. Since `BLOCK_FAILED_CHILD` has never been used for anything, it's hard to say what the intentions really were, but my impression is that the first invalid block should be marked as `BLOCK_FAILED_VALID` and all of its descendants as `BLOCK_FAILED_CHILD` - so having both `BLOCK_FAILED_VALID` and `BLOCK_FAILED_CHILD` at the same time doesn't make sense to me.

💬 placintaalexandru commented on issue "Ability to build the library":
(https://github.com/bitcoin/bitcoin/issues/31964#issuecomment-2698559287)
Yes, I want to be able to build (selectively of possible) the libs used by the project and be able to get the header files as well

💬 fanquake commented on issue "TSan warning with legacy wallet on macos ("too long mutex cycle found")":
(https://github.com/bitcoin/bitcoin/issues/31986#issuecomment-2698566827)
```bash
# master (15717f0ef3960969ee550a4a41741987b86684dc) aarch64 Linux
# clang version 19.1.7 (Fedora 19.1.7-2.fc41)
make -C depends/ CC=clang CXX="clang++ -stdlib=libc++" -j16 NO_QT=1 NO_ZMQ=1 NO_SQLITE=1
cmake -B build --toolchain /root/bitcoin/depends/aarch64-unknown-linux-gnu/toolchain.cmake -DSANITIZERS=thread -DCMAKE_BUILD_TYPE=Debug
cmake --build build -j17
build/test/functional/wallet_listtransactions.py --legacy-wallet --nocleanup
```

```bash
node0 2025-03-04T18:34:31.466976Z [shut
...

💬 Morinyo1907 commented on pull request "wallet: Replace "non-0" with "non-zero" in translatable error message":
(https://github.com/bitcoin/bitcoin/pull/31987#discussion_r1980025668)
[](https://github.com/bitcoin/bitcoin/actions/workflows/ci.yml)Sjors:2025/03/utxo-880000

💬 mzumsande commented on pull request "validation: stricter internal handling of invalid blocks":
(https://github.com/bitcoin/bitcoin/pull/31405#discussion_r1980042629)
With `pindex->pprev` being the predecessor of the block passed to the `invalidateblock` rpc call, the logic in `InvalidateBlock()` is to go from the tip back to `pindex->pprev` - and we may need to update other forked descendants of the blocks encountered along that way (which must have more accumulated work than their parents), which is why we put them in the cache. But all blocks with lower work can never be encountered by that process and therefore don't need to be in the caches.
I'll add m
...

💬 instagibbs commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#discussion_r1980055069)
Would it go too far to assure the caller that the ordering reflects the underlying stored linearization i.e. reflects the underlying ordering values like chunk feerates are coming from?

📝 jamesob opened a pull request: "Add BIP-119 (OP_CHECKTEMPLATEVERIFY) (no activation)"
(https://github.com/bitcoin/bitcoin/pull/31989)
This implements [BIP-119 (`OP_CHECKTEMPLATEVERIFY`)](https://github.com/bitcoin/bips/blob/master/bip-0119.mediawiki), but does not specify a deployment. There is no effective policy change, since the `SCRIPT_VERIFY_*` flags (as used) result in the same NOP-like behavior.

I encourage more general, conceptual discussion to happen on [Delving Bitcoin](https://delvingbitcoin.org/) and not on this pull request.

See also:
- https://bitcoinops.org/en/topics/op_checktemplateverify/
- https://ut
...

🚀 glozow merged a pull request: "Add mainnet assumeutxo param at height 880,000"
(https://github.com/bitcoin/bitcoin/pull/31969)

👍 pinheadmz approved a pull request: "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries"
(https://github.com/bitcoin/bitcoin/pull/31407#pullrequestreview-2658743291)
tested ACK e181bda061ca63021511be6e286fdf6a5818df49

Codesigning process works and is properly documented. tested codesigned binaries on arm64/macos. Shallow review of code looks good and certainly is in the right scope (just shell scripts modified). Will test signed win64 binary asap.