💬 fjahr commented on pull request "test: Use rpc_deprecated only for testing deprecation":
(https://github.com/bitcoin/bitcoin/pull/31977#discussion_r1979856225)
Changed this but with slightly different wording

💬 fjahr commented on pull request "test: Use rpc_deprecated only for testing deprecation":
(https://github.com/bitcoin/bitcoin/pull/31977#issuecomment-2698328931)
Addressed the comments by @rkrux , thanks!

💬 eval-exec commented on pull request "torcontrol: Limit reconnect timeout to max seconds and log delay in whole seconds":
(https://github.com/bitcoin/bitcoin/pull/31979#discussion_r1979862817)
Thank you, updated.

💬 hebasto commented on pull request "ci: Test cross-built Windows executables on Windows natively":
(https://github.com/bitcoin/bitcoin/pull/31176#issuecomment-2698343835)
Addressed @hodlinator's feedback.

💬 hebasto commented on pull request "ci: Test cross-built Windows executables on Windows natively":
(https://github.com/bitcoin/bitcoin/pull/31176#discussion_r1979867464)
Thanks! [Done](https://github.com/bitcoin/bitcoin/pull/31176#issuecomment-2698343835).

💬 hebasto commented on pull request "ci: Test cross-built Windows executables on Windows natively":
(https://github.com/bitcoin/bitcoin/pull/31176#discussion_r1979867604)
Thanks! [Done](https://github.com/bitcoin/bitcoin/pull/31176#issuecomment-2698343835).

📝 mabu44 opened a pull request: "[WIP] refactor: migrate unit tests to Google Test"
(https://github.com/bitcoin/bitcoin/pull/31988)
WIP: both the code and the following motivations will be updated with new information obtained during research and through feedback from reviewers.

#### Motivation
By migrating the unit tests from Boost to Google Test we can increase the chances of removing all dependencies from Boost in the future.

#### Benefits of Google Test
* Most used C++ testing framework with a large community
* Includes Google Mock for creating mock objects
* Similar syntax to Boost, making refactor simpler
*
...

✅ fanquake closed a pull request: "[WIP] refactor: migrate unit tests to Google Test"
(https://github.com/bitcoin/bitcoin/pull/31988)

💬 instagibbs commented on pull request "cluster mempool: introduce TxGraph":
(https://github.com/bitcoin/bitcoin/pull/31363#issuecomment-2698367852)
ACK 72a97c0a07ea6e5a95ab37c8d95e1ea02cff8e92

With the weaker claims in the code re:PostLinearization, it works for me, and obviates the need for an additional harness test.

`git range-diff master d5abb86439e79d4adfbfbd46f833268bbca0bf6e 72a97c0a07ea6e5a95ab37c8d95e1ea02cff8e92`

💬 achow101 commented on pull request "psbt: add non-default sighash types to PSBTs and unify sighash type match checking":
(https://github.com/bitcoin/bitcoin/pull/31622#discussion_r1979899843)
Huh, it does say that. Perhaps I'm remembering an old draft where it was different.

Changed the test to check that it doesn't finalize, and added a commit to implement that behavior.

💬 achow101 commented on pull request "psbt: add non-default sighash types to PSBTs and unify sighash type match checking":
(https://github.com/bitcoin/bitcoin/pull/31622#discussion_r1979900773)
Nothing, it just helps to mutate one which we know is definitely good.

🤔 hebasto reviewed a pull request: "depends: Update libmultiprocess library to fix CI failures"
(https://github.com/bitcoin/bitcoin/pull/31945#pullrequestreview-2658407119)
Post-merge ACK 01f771576608403dbfc5dee4fcdd84ef262f9390.

💬 achow101 commented on pull request "psbt: add non-default sighash types to PSBTs and unify sighash type match checking":
(https://github.com/bitcoin/bitcoin/pull/31622#discussion_r1979937428)
Done

💬 fanquake commented on issue "Avoid plural forms in non-GUI translatable strings (lacks `%n` support)":
(https://github.com/bitcoin/bitcoin/issues/31890#issuecomment-2698457477)
I'm not really sure what we can do here. We could try and change all the strings now, but then it's whack-a-mole with requirements that developers are not really aware off, nor are enforced by anything (similar thoughts for changes like #31987).

> Here is an example of such a string:
> "Not enough file descriptors available. %d available, %d required."

What would you change the string to in this case? How many strings are there that need changing?

💬 achow101 commented on pull request "psbt: add non-default sighash types to PSBTs and unify sighash type match checking":
(https://github.com/bitcoin/bitcoin/pull/31622#discussion_r1979940474)
That's orthogonal to this PR and can be done separately.

💬 achow101 commented on pull request "psbt: add non-default sighash types to PSBTs and unify sighash type match checking":
(https://github.com/bitcoin/bitcoin/pull/31622#discussion_r1979941576)
I don't think it makes sense to do that here since PSBTv2 is still entirely unparseable.

💬 achow101 commented on pull request "Add assumeutxo chainparams to release-process.md":
(https://github.com/bitcoin/bitcoin/pull/31940#issuecomment-2698466564)
ACK 02fae3363511e96a76ff64a4513c7a7e8d8d4403

👍 hebasto approved a pull request: "doc: update fuzz instructions when on macOS"
(https://github.com/bitcoin/bitcoin/pull/31954#pullrequestreview-2658499705)
ACK 75486c8ed87a480b9f0c4dc7a10f3cd4eee87b12, tested on macOS 15.3.1 (Apple M1) + Clang 19.1.7.

💬 Christewart commented on pull request "kernel: pre-29.x chainparams and headerssync update":
(https://github.com/bitcoin/bitcoin/pull/31978#discussion_r1979954361)
du -csh ~/.bitcoin/testnet3/blocks/ ~/.bitcoin/testnet3/chainstate/
167G /home/chris/.bitcoin/testnet3/blocks/
13G /home/chris/.bitcoin/testnet3/chainstate/
179G total

💬 achow101 commented on pull request "kernel: pre-29.x chainparams and headerssync update":
(https://github.com/bitcoin/bitcoin/pull/31978#discussion_r1979954715)
In 570191a758bc326ae0f0a479b72759f962c0db12 "[kernel] update chainTxData for v29"

Comment needs to be updated for the block that these stats are for.

💬 davidgumberg commented on pull request "wallet: Replace "non-0" with "non-zero" in translatable error message":
(https://github.com/bitcoin/bitcoin/pull/31987#issuecomment-2698490041)
ACK https://github.com/bitcoin/bitcoin/pull/31987/commits/18e83534ace7aa2d26bc7dfa521b1d591b66edfa