⚠️ pinheadmz opened an issue: "TSan warning with legacy wallet on macos ("too long mutex cycle found")"
(https://github.com/bitcoin/bitcoin/issues/31986)
master branch at 15717f0ef3960969ee550a4a41741987b86684dc

built on arm64/macos

Notably there is no TSan warning when the test is run with `--descriptors`

To reproduce:
```
--> build_master/test/functional/wallet_listtransactions.py --legacy-wallet --nocleanup
...
AssertionError: Unexpected stderr WARNING: too long mutex cycle found
```

complete configuration:
```
Configure summary
=================
Executables:
bitcoind ............................ ON
bitcoin-node (multiprocess) ........
...

💬 achow101 commented on pull request "kernel: pre-29.x chainparams and headerssync update":
(https://github.com/bitcoin/bitcoin/pull/31978#discussion_r1979764666)
> It is a big jump, but `du .bitcoin/testnet3 -h` gives me 181G. Let's see what other people have?

In the past, I've done `du -csh chainstate/ blocks/` so that indexes, debug.log, and wallets, are not included in the size.

```
du -csh ~/.bitcoin/testnet3/chainstate/ ~/.bitcoin/testnet3/blocks/
11G /home/ava/.bitcoin/testnet3/chainstate/
101G /home/ava/.bitcoin/testnet3/blocks/
111G total
```

💬 achow101 commented on pull request "kernel: pre-29.x chainparams and headerssync update":
(https://github.com/bitcoin/bitcoin/pull/31978#discussion_r1979766255)
10% buffer, as stated in the release process doc. `9.2 * 1.1 = 10.12 ~= 11`

👍 darosior approved a pull request: "descriptor: check whitespace in keys within fragments"
(https://github.com/bitcoin/bitcoin/pull/31603#pullrequestreview-2658166364)
re-ACK re-ACK 21e9d39a3725cd6107b742f0cb97f65b3640201b

💬 pinheadmz commented on issue "TSan warning with legacy wallet on macos ("too long mutex cycle found")":
(https://github.com/bitcoin/bitcoin/issues/31986#issuecomment-2698225051)
* I ran all wallet tests and only `wallet_listtransactions.py --legacy-wallet` fails with this warning

✅ achow101 closed an issue: "Request for Wiki Edit Permissions – Testing Guide: Bitcoin Core 29.0 RC"
(https://github.com/bitcoin/bitcoin/issues/31984)

💬 achow101 commented on issue "Request for Wiki Edit Permissions – Testing Guide: Bitcoin Core 29.0 RC":
(https://github.com/bitcoin/bitcoin/issues/31984#issuecomment-2698235879)
Invites have been sent.

💬 fanquake commented on pull request "kernel: pre-29.x chainparams and headerssync update":
(https://github.com/bitcoin/bitcoin/pull/31978#discussion_r1979802796)
```bash
du -csh chainstate/ blocks/
13G chainstate/
167G blocks/
180G total
```

💬 fjahr commented on pull request "Add mainnet assumeutxo param at height 880,000":
(https://github.com/bitcoin/bitcoin/pull/31969#issuecomment-2698243705)
tACK 14f16748557faf57cf4b0f4c91c162592557434c

I tested all of the steps outlined in the PR description and did indeed enjoy the speedy ride 🏎️

📝 hebasto opened a pull request: "wallet: Replace "non-0" with "non-zero" in translatable error message"
(https://github.com/bitcoin/bitcoin/pull/31987)
Transifex interprets the "-0" substring as a number in translatable strings. Since not all translations preserve "-0," this triggers a corresponding warning. While this warning could be disabled globally, it is more reasonable to adjust the original string instead.

🤔 sipa reviewed a pull request: "descriptor: check whitespace in keys within fragments"
(https://github.com/bitcoin/bitcoin/pull/31603#pullrequestreview-2658256613)
utACK 21e9d39a3725cd6107b742f0cb97f65b3640201b

👍 brunoerg approved a pull request: "doc: update fuzz instructions when on macOS"
(https://github.com/bitcoin/bitcoin/pull/31954#pullrequestreview-2658264313)
ACK 75486c8ed87a480b9f0c4dc7a10f3cd4eee87b12

I just tested it on macOS 14.3 and worked fine.

💬 mprenditore commented on pull request "Added rescan option for import descriptors":
(https://github.com/bitcoin/bitcoin/pull/31668#issuecomment-2698289660)
> Moved to draft for now. You'll need to squash your commits, and address the various review feedback.

@fanquake code has been updated as per the discussions and all checks are now passing.
Hope now it's good to be merged.

👍 hodlinator approved a pull request: "ci: Test cross-built Windows executables on Windows natively"
(https://github.com/bitcoin/bitcoin/pull/31176#pullrequestreview-2658280804)
re-ACK e3d3500e8088c446c8ab93a67d80ac241a69488c

Range-diff showed no changes beyond rebase since my [previous review](https://github.com/bitcoin/bitcoin/pull/31176#pullrequestreview-2611426260).

Looked through [latest run of PR](https://github.com/bitcoin/bitcoin/actions/runs/13649585472?pr=31176). Suggest some job names that are clearer to me, maybe there's some middle ground, nothing blocking.

💬 hodlinator commented on pull request "ci: Test cross-built Windows executables on Windows natively":
(https://github.com/bitcoin/bitcoin/pull/31176#discussion_r1979832552)
```suggestion
name: 'Linux->Windows cross, no tests'
```

💬 hodlinator commented on pull request "ci: Test cross-built Windows executables on Windows natively":
(https://github.com/bitcoin/bitcoin/pull/31176#discussion_r1979833466)
```suggestion
name: 'Windows, test cross-built'
```

💬 fjahr commented on pull request "test: Use rpc_deprecated only for testing deprecation":
(https://github.com/bitcoin/bitcoin/pull/31977#discussion_r1979855796)
Added, thanks!

💬 fjahr commented on pull request "test: Use rpc_deprecated only for testing deprecation":
(https://github.com/bitcoin/bitcoin/pull/31977#discussion_r1979855960)
fixed

💬 fjahr commented on pull request "test: Use rpc_deprecated only for testing deprecation":
(https://github.com/bitcoin/bitcoin/pull/31977#discussion_r1979856225)
Changed this but with slightly different wording

💬 fjahr commented on pull request "test: Use rpc_deprecated only for testing deprecation":
(https://github.com/bitcoin/bitcoin/pull/31977#issuecomment-2698328931)
Addressed the comments by @rkrux , thanks!

💬 eval-exec commented on pull request "torcontrol: Limit reconnect timeout to max seconds and log delay in whole seconds":
(https://github.com/bitcoin/bitcoin/pull/31979#discussion_r1979862817)
Thank you, updated.