💬 willcl-ark commented on pull request "kernel: pre-29.x chainparams and headerssync update":
(https://github.com/bitcoin/bitcoin/pull/31978#discussion_r1979246362)
> On my existing node du -h returns 681G for the blocks and 12G for the chainstate.

I also have numbers matching these on my nodes too.

<details>
<summary>Details</summary>

```
bitcoin in ~/.bitcoin ➜ du -h | rg chainstate
77M ./signet/chainstate
12G ./chainstate
bitcoin in ~/.bitcoin ➜ cd /mnt/data/bitcoin/.bitcoin/
bitcoin in data/bitcoin/.bitcoin ➜ du -h | rg blocks
469M ./signet/blocks
681G ./blocks
```

</details>

💬 Sjors commented on pull request "Add checkBlock() to Mining interface":
(https://github.com/bitcoin/bitcoin/pull/31981#issuecomment-2697242642)
I also salvaged the functional tests from 15d841e41bb61f435dd3e60e99fa4db47d34a3a6.

📝 fanquake opened a pull request: "build: don't show ccache summary with MSVC"
(https://github.com/bitcoin/bitcoin/pull/31983)
Given we skip MSVC when performing any ccache setup, it doesn't really make sense to show this output when using MSVC. Even less so if it's going to (possibly incorrectly) show it as Enabled.

Fixes #31771.

💬 fanquake commented on issue "cmake: incorrectly reporting MSVC as using ccache":
(https://github.com/bitcoin/bitcoin/issues/31771#issuecomment-2697266556)
I've opened #31983 to deal with this for now.

💬 dergoegge commented on pull request "rpc: increase the defaults for -rpcthreads and -rpcworkqueue":
(https://github.com/bitcoin/bitcoin/pull/31215#issuecomment-2697276918)
The docs still say that the default is 4: https://github.com/bitcoin/bitcoin/blob/15717f0ef3960969ee550a4a41741987b86684dc/doc/reduce-memory.md#thread-configuration

💬 hebasto commented on pull request "build: don't show ccache summary with MSVC":
(https://github.com/bitcoin/bitcoin/pull/31983#issuecomment-2697283225)
Ccache could be supported for MSVC in the future, which might lead to these changes being reverted. Why not use https://github.com/bitcoin/bitcoin/pull/30861/commits/c19a187c42fe867d61ca5dbd48ae18f15201839f instead?

💬 fjahr commented on pull request "wallet, rpc: deprecate settxfee and paytxfee":
(https://github.com/bitcoin/bitcoin/pull/31278#issuecomment-2697295701)
utACK f4344220d7195324f921dcf001c1a117008477fd

💬 fanquake commented on pull request "build: don't show ccache summary with MSVC":
(https://github.com/bitcoin/bitcoin/pull/31983#issuecomment-2697305165)
> Why not use https://github.com/bitcoin/bitcoin/commit/c19a187c42fe867d61ca5dbd48ae18f15201839f instead?

From my read of #30861 nobody seems to agree that we should make this change? https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1937227612

💬 Sjors commented on pull request "scripted-diff: rename libmultiprocess repository":
(https://github.com/bitcoin/bitcoin/pull/31982#issuecomment-2697315226)
Concept ACK

💬 eval-exec commented on pull request "torcontrol: Limit reconnect timeout to max seconds and log delay in whole seconds":
(https://github.com/bitcoin/bitcoin/pull/31979#issuecomment-2697317938)
CI has passed, so I think this PR is ready for review.

💬 Sjors commented on pull request "guix: Notarize MacOS app bundle and codesign all MacOS and Windows binaries":
(https://github.com/bitcoin/bitcoin/pull/31407#issuecomment-2697341062)
Tested ACK e181bda061ca63021511be6e286fdf6a5818df49

I only tested on macOS (Intel and Apple Silicon), and only lightly reviewed the code.

💬 hebasto commented on pull request "build: don't show ccache summary with MSVC":
(https://github.com/bitcoin/bitcoin/pull/31983#discussion_r1979315337)
The [`MSVC`](https://cmake.org/cmake/help/latest/variable/MSVC.html) variable is defined based on the compiler. However, the current ccache settings rely on the [`<LANG>_COMPILER_LAUNCHER`](https://cmake.org/cmake/help/latest/prop_tgt/LANG_COMPILER_LAUNCHER.html) properties, which are considered depending on the generator rather than the compiler.

💬 m3dwards commented on pull request "doc: update fuzz instructions when on macOS":
(https://github.com/bitcoin/bitcoin/pull/31954#discussion_r1979319485)
Changed to this

💬 m3dwards commented on pull request "doc: update fuzz instructions when on macOS":
(https://github.com/bitcoin/bitcoin/pull/31954#discussion_r1979319968)
Thanks, dropped.

💬 hebasto commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2697383952)
Closing and marking "Up for grabs".

✅ hebasto closed a pull request: "build: Enhance Ccache performance across worktrees and build trees"
(https://github.com/bitcoin/bitcoin/pull/30861)

💬 laanwj commented on pull request "torcontrol: Limit reconnect timeout to max seconds and log delay in whole seconds":
(https://github.com/bitcoin/bitcoin/pull/31979#discussion_r1979326582)
`timeout` should be a float, this a comparison on two float values returning a float.

💬 laanwj commented on pull request "torcontrol: Limit reconnect timeout to max seconds and log delay in whole seconds":
(https://github.com/bitcoin/bitcoin/pull/31979#discussion_r1979328349)
imo it would be better to do the capping here:
```c++
reconnect_timeout = std::min(reconnect_timeout * RECONNECT_TIMEOUT_EXP, RECONNECT_TIMEOUT_MAX);
```

🤔 naiyoma reviewed a pull request: "wallet: fix crash on double block disconnection"
(https://github.com/bitcoin/bitcoin/pull/31757#pullrequestreview-2657287497)
TestedACK [https://github.com/bitcoin/bitcoin/pull/31757/commits/c80b105f77d8ee397c7dc07b013c37b7df63abd5](https://github.com/bitcoin/bitcoin/pull/31757/commits/c80b105f77d8ee397c7dc07b013c37b7df63abd5)

cherry-picked the test commit on master branch and verified that the test case fails on the second invalidation:

```
2025-03-04T12:18:39.077000Z TestFramework (ERROR): Unexpected exception caught during testing
raise RemoteDisconnected("Remote end closed connection without"
http.client.
...

⚠️ arejula27 opened an issue: "Request for Wiki Edit Permissions – Testing Guide: Bitcoin Core 29.0 RC"
(https://github.com/bitcoin/bitcoin/issues/31984)
Hello, maintainers,
We are currently working on the Testing Guide: Bitcoin Core 29.0 Release Candidate as part of the [BOSS program](https://learning.chaincode.com/#seminars). We are:
@musaHaruna
@arejula27
@janb84
@Prabhat1308
We would like to request permission to edit the Wiki so we can contribute and publish our guide.

Looking forward to your response.

Thank you!

💬 laanwj commented on pull request "torcontrol: Limit reconnect timeout to max seconds and log delay in whole seconds":
(https://github.com/bitcoin/bitcoin/pull/31979#issuecomment-2697457225)
Concept ACK.

It's debatable whether we need an exponential backoff here in the first place. After all Tor is generally a local service, there is no risk of creating a DoS. i added it back then, to reduce the amount of log spam in case Tor isn't running. However we have a better logging system now that takes both category and level into account, so that motivation is no longer relevant.