β οΈ texasspurstar opened an issue: "build: broken CMake *flags output"
(https://github.com/bitcoin/bitcoin/issues/31749)
### Please describe the feature you'd like to see added.
Seen in CI runs, i.e https://cirrus-ci.com/task/5616358949388288?logs=configure#L309:
C++ compiler flags .................... -O2 -g -std=c++20 -fPIC -fdebug-prefix-map=/tmp/cirrus-ci-build/bitcoin-core/src=. -fmacro-prefix-map=/tmp/cirrus-ci-build/bitcoin-core/src=. -Werror $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>:SHELL:-Xcompiler -pthread> $<$<AND:$<NOT:$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>>,$<NOT:$<COMPILE_LANGUAGE:Swift>>>:-pthread> -Wall -
...
(https://github.com/bitcoin/bitcoin/issues/31749)
### Please describe the feature you'd like to see added.
Seen in CI runs, i.e https://cirrus-ci.com/task/5616358949388288?logs=configure#L309:
C++ compiler flags .................... -O2 -g -std=c++20 -fPIC -fdebug-prefix-map=/tmp/cirrus-ci-build/bitcoin-core/src=. -fmacro-prefix-map=/tmp/cirrus-ci-build/bitcoin-core/src=. -Werror $<$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>:SHELL:-Xcompiler -pthread> $<$<AND:$<NOT:$<COMPILE_LANG_AND_ID:CUDA,NVIDIA>>,$<NOT:$<COMPILE_LANGUAGE:Swift>>>:-pthread> -Wall -
...
β
fanquake closed an issue: "build: broken CMake *flags output"
(https://github.com/bitcoin/bitcoin/issues/31749)
(https://github.com/bitcoin/bitcoin/issues/31749)
π€ ismaelsadeeq reviewed a pull request: "RPC: improve SFFO arg parsing, error catching and coverage"
(https://github.com/bitcoin/bitcoin/pull/30844#pullrequestreview-2579487271)
Code review and Tested ACK cddcbaf81e8e3d107cd321ee2c9a7fd786a8917e
(https://github.com/bitcoin/bitcoin/pull/30844#pullrequestreview-2579487271)
Code review and Tested ACK cddcbaf81e8e3d107cd321ee2c9a7fd786a8917e
β οΈ Alward0 opened an issue: "Key events of bitcoin "
(https://github.com/bitcoin/bitcoin/issues/31750)
The history of **Satoshi Nakamoto**, the pseudonymous creator of Bitcoin, is shrouded in mystery. Despite extensive speculation and investigation, no one has definitively uncovered Satoshi's true identity. Hereβs what is known about Satoshi Nakamoto based on available information:
---
### **Key Events in Satoshi Nakamoto's History**
1. **October 2008**:
- Satoshi Nakamoto published the **Bitcoin whitepaper**, titled *"Bitcoin: A Peer-to-Peer Electronic Cash System,"* on a cryptography maili
...
(https://github.com/bitcoin/bitcoin/issues/31750)
The history of **Satoshi Nakamoto**, the pseudonymous creator of Bitcoin, is shrouded in mystery. Despite extensive speculation and investigation, no one has definitively uncovered Satoshi's true identity. Hereβs what is known about Satoshi Nakamoto based on available information:
---
### **Key Events in Satoshi Nakamoto's History**
1. **October 2008**:
- Satoshi Nakamoto published the **Bitcoin whitepaper**, titled *"Bitcoin: A Peer-to-Peer Electronic Cash System,"* on a cryptography maili
...
β
pinheadmz closed an issue: "Key events of bitcoin "
(https://github.com/bitcoin/bitcoin/issues/31750)
(https://github.com/bitcoin/bitcoin/issues/31750)
:lock: fanquake locked an issue: "Key events of bitcoin "
(https://github.com/bitcoin/bitcoin/issues/31750)
(https://github.com/bitcoin/bitcoin/issues/31750)
π¬ darosior commented on issue "RFC: Multiprocess binaries and packaging options":
(https://github.com/bitcoin/bitcoin/issues/30983#issuecomment-2620155964)
I don't think the cons of option 3 are necessary to get its pros. How about simply keeping `bitcoind` and `bitcoin-qt` which would start `-node`, `-wallet` and `-gui` binaries from `libexec`? The bigger binaries are a consequence of wanting to be able to disable IPC through a runtime option. It's an internal, why is it something we would want to make possible for the user to change? And why should we keep releasing the large binaries? If we do, when do we stop? I think that *once we are confiden
...
(https://github.com/bitcoin/bitcoin/issues/30983#issuecomment-2620155964)
I don't think the cons of option 3 are necessary to get its pros. How about simply keeping `bitcoind` and `bitcoin-qt` which would start `-node`, `-wallet` and `-gui` binaries from `libexec`? The bigger binaries are a consequence of wanting to be able to disable IPC through a runtime option. It's an internal, why is it something we would want to make possible for the user to change? And why should we keep releasing the large binaries? If we do, when do we stop? I think that *once we are confiden
...
π¬ mzumsande commented on issue "test: intermittent issue in p2p_1p1c_network.py ":
(https://github.com/bitcoin/bitcoin/issues/31721#issuecomment-2620169640)
I think that the following is happening:
- Orphan is announced to node 1 by python peer, but it doesn't send the tx.
- submitpackage is executed on node 0, which will sequentially schedule `RelayTransaction`, first for the parent, then for the child.
- Usually parent and child are put together in one inv, but if the node sends out an inv in between these two `RelayTransaction` calls, the inv for the child may arrive after the tx for the parent was received - since we now only do orphan resolutio
...
(https://github.com/bitcoin/bitcoin/issues/31721#issuecomment-2620169640)
I think that the following is happening:
- Orphan is announced to node 1 by python peer, but it doesn't send the tx.
- submitpackage is executed on node 0, which will sequentially schedule `RelayTransaction`, first for the parent, then for the child.
- Usually parent and child are put together in one inv, but if the node sends out an inv in between these two `RelayTransaction` calls, the inv for the child may arrive after the tx for the parent was received - since we now only do orphan resolutio
...
π mzumsande opened a pull request: "test: fix intermittent timeout in p2p_1p1c_network.py"
(https://github.com/bitcoin/bitcoin/pull/31751)
The timeout is due to outstanding txrequests with python peers.
I explained this in more detail in https://github.com/bitcoin/bitcoin/issues/31721#issuecomment-2620169640
Fix this by disconnecting the python peers after they send their txns, they aren't needed after this point anyway because the main goal of the test is the sync between the 4 full nodes.
Fixes #31721
(https://github.com/bitcoin/bitcoin/pull/31751)
The timeout is due to outstanding txrequests with python peers.
I explained this in more detail in https://github.com/bitcoin/bitcoin/issues/31721#issuecomment-2620169640
Fix this by disconnecting the python peers after they send their txns, they aren't needed after this point anyway because the main goal of the test is the sync between the 4 full nodes.
Fixes #31721
π maximevtush opened a pull request: "Update LICENSE"
(https://github.com/bitcoin/bitcoin/pull/31752)
Updated the copyright year from 2017 to 2025 in the LICENSE file
(https://github.com/bitcoin/bitcoin/pull/31752)
Updated the copyright year from 2017 to 2025 in the LICENSE file
β
fanquake closed a pull request: "Update LICENSE"
(https://github.com/bitcoin/bitcoin/pull/31752)
(https://github.com/bitcoin/bitcoin/pull/31752)
π fanquake locked a pull request: "Update LICENSE"
(https://github.com/bitcoin/bitcoin/pull/31752)
Updated the copyright year from 2017 to 2025 in the LICENSE file
(https://github.com/bitcoin/bitcoin/pull/31752)
Updated the copyright year from 2017 to 2025 in the LICENSE file
π¬ hodlinator commented on pull request "qa: Verify clean shutdown on startup failure":
(https://github.com/bitcoin/bitcoin/pull/30660#issuecomment-2620208770)
Resolved conflict with @maflcko's #31620 which solved the core issue more elegantly.
I think there is still some use in the tests from this PR, as we want to avoid knock-on exceptions being reintroduced. I've reworked the tests from 3 to 1 Python file. They now launch a child process of which keeps the success-state of the parent `BitcoinTestFramework` separate from the expected failures of the child processes.
The final commit (f2e3721e018c3038d5d648ec7ae08e96418f3c29) is what remains of
...
(https://github.com/bitcoin/bitcoin/pull/30660#issuecomment-2620208770)
Resolved conflict with @maflcko's #31620 which solved the core issue more elegantly.
I think there is still some use in the tests from this PR, as we want to avoid knock-on exceptions being reintroduced. I've reworked the tests from 3 to 1 Python file. They now launch a child process of which keeps the success-state of the parent `BitcoinTestFramework` separate from the expected failures of the child processes.
The final commit (f2e3721e018c3038d5d648ec7ae08e96418f3c29) is what remains of
...
π¬ ftruter commented on something "":
(https://github.com/bitcoin/bitcoin/commit/b483084d866c16d97a34251ae652bac94f85f61d#commitcomment-151875207)
The information that WAS in this file BEFORE this commit is no longer ANYWHERE else in the repo. Please revert!!
(https://github.com/bitcoin/bitcoin/commit/b483084d866c16d97a34251ae652bac94f85f61d#commitcomment-151875207)
The information that WAS in this file BEFORE this commit is no longer ANYWHERE else in the repo. Please revert!!
π ShivaanjayNarula opened a pull request: "Merge pull request #1 from bitcoin/master"
(https://github.com/bitcoin/bitcoin/pull/31753)
Merge
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests th
...
(https://github.com/bitcoin/bitcoin/pull/31753)
Merge
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests th
...
β
willcl-ark closed a pull request: "Merge pull request #1 from bitcoin/master"
(https://github.com/bitcoin/bitcoin/pull/31753)
(https://github.com/bitcoin/bitcoin/pull/31753)
π fanquake locked a pull request: "Merge pull request #1 from bitcoin/master"
(https://github.com/bitcoin/bitcoin/pull/31753)
Merge
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests th
...
(https://github.com/bitcoin/bitcoin/pull/31753)
Merge
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests th
...
π¬ pinheadmz commented on something "":
(https://github.com/bitcoin/bitcoin/commit/b483084d866c16d97a34251ae652bac94f85f61d#commitcomment-151875532)
@ftruter it's generated with each new release:
https://github.com/bitcoin/bitcoin/blob/28.x/share/examples/bitcoin.conf
(https://github.com/bitcoin/bitcoin/commit/b483084d866c16d97a34251ae652bac94f85f61d#commitcomment-151875532)
@ftruter it's generated with each new release:
https://github.com/bitcoin/bitcoin/blob/28.x/share/examples/bitcoin.conf
β οΈ tofutim opened an issue: "guix SWH vault Internal Server Error"
(https://github.com/bitcoin/bitcoin/issues/31754)
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Current behaviour
For the first time, running contrib/guix/guix-build, I ran into:
```
Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
SWH: found revision 53396a22afc04536ddf75d8f82ad2eafa5082725 with directory at 'https://archive.softwareheritage.org/api/1/directory/d6d830512c16e46521fab9a956c1842ab2fcdea9/'
SWH vault: failure: Internal Server Error. This inc
...
(https://github.com/bitcoin/bitcoin/issues/31754)
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Current behaviour
For the first time, running contrib/guix/guix-build, I ran into:
```
Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'...
SWH: found revision 53396a22afc04536ddf75d8f82ad2eafa5082725 with directory at 'https://archive.softwareheritage.org/api/1/directory/d6d830512c16e46521fab9a956c1842ab2fcdea9/'
SWH vault: failure: Internal Server Error. This inc
...
π¬ davidgumberg commented on pull request "build: Enhance Ccache performance across worktrees and build trees":
(https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2620364986)
Tested ACK, fixes worktree and build tree ccache hits. https://github.com/bitcoin/bitcoin/commit/4d3f360e2af94f4ed46dc0943196d548da82003e
Note that as the PR description states, in the latest push, setting a `BASE_DIR` for `ccache` (as advised in the productivity notes) is essential for ccache to get hits in different directories.
<details>
<summary>Tested on gcc and clang on ubuntu 22.04</summary>
All on fresh ubuntu 22.04.1 vm images running running with qemu, in variations
I
...
(https://github.com/bitcoin/bitcoin/pull/30861#issuecomment-2620364986)
Tested ACK, fixes worktree and build tree ccache hits. https://github.com/bitcoin/bitcoin/commit/4d3f360e2af94f4ed46dc0943196d548da82003e
Note that as the PR description states, in the latest push, setting a `BASE_DIR` for `ccache` (as advised in the productivity notes) is essential for ccache to get hits in different directories.
<details>
<summary>Tested on gcc and clang on ubuntu 22.04</summary>
All on fresh ubuntu 22.04.1 vm images running running with qemu, in variations
I
...
π espi3 opened a pull request: "doc: Add test coverage troubleshooting tip"
(https://github.com/bitcoin/bitcoin/pull/31755)
This PR adds troubleshooting information to explain how to overcome two errors that may arise when running the tests with coverage as described in doc/developer-notes.md.
Specifically, running the `cmake -P build/Coverage.cmake` step may produces geninfo mismatch errors of the following sort (Ubuntu 24.04, g++ compiler):
```
geninfo: ERROR: mismatched end line for _ZN7Num30723SerI10DataStreamEEvRT_RKS_ at /home/espi3/src/bitcoin/src/crypto/muhash.h:62: 67 -> 62
(use "geninfo --ig
...
(https://github.com/bitcoin/bitcoin/pull/31755)
This PR adds troubleshooting information to explain how to overcome two errors that may arise when running the tests with coverage as described in doc/developer-notes.md.
Specifically, running the `cmake -P build/Coverage.cmake` step may produces geninfo mismatch errors of the following sort (Ubuntu 24.04, g++ compiler):
```
geninfo: ERROR: mismatched end line for _ZN7Num30723SerI10DataStreamEEvRT_RKS_ at /home/espi3/src/bitcoin/src/crypto/muhash.h:62: 67 -> 62
(use "geninfo --ig
...