💬 realsetvin commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605762427)
> > okay I may be mixing up hd phrases with seed phrases but realistically they are the same right?
>
> No, HD key derivation is BIP32. Seed phrases can refer to a number of things, but most commonly the ones specified in BIP39.
>
> > why do bitcoin copies have the function but bitcoin dosent?
>
> This is not a property of the currency, but of the software. There are lots of Bitcoin wallets that support seed phrases. Bitcoin Core just happens to not be one of them.
>
> > what can I do to wri
...

💬 sipa commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605763751)
Again, Bitcoin Core does not, and has never supported seed phrases.

💬 realsetvin commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605764959)
> Again, Bitcoin Core does not, and has never supported seed phrases.

in that case, am I falsely attributing something on dash to bitcoin?

what about hd phrases?

💬 realsetvin commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605767749)
I understand you're annoyed that I dont know everything you know, maybe you can see im trying to learn. Any attempt of explanation would help.

💬 maflcko commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605768299)
> im familiar with the function of bitcoin core, can I use an older version?

See https://bitcoincore.org/en/lifecycle/

💬 sipa commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605768390)
> in that case, am I falsely attributing something on dash to bitcoin?

Again, this has nothing to do with the currency, but with the wallet software. If you want seed phrases, feel free to use any of the dozens of other Bitcoin wallet software out there that supports it. Bitcoin Core does not.

> what about hd phrases?

Bitcoin Core does not support HD phrases, or seed phrases, or phrases of any kind. It uses HD key derivation, however.

👋 maflcko's pull request is ready for review: "refactor: Use std::span over Span"
(https://github.com/bitcoin/bitcoin/pull/31519)

💬 realsetvin commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605771293)
> > in that case, am I falsely attributing something on dash to bitcoin?
>
> Again, this has nothing to do with the currency, but with the wallet software. If you want seed phrases, feel free to use any of the dozens of other Bitcoin wallet software out there that supports it. Bitcoin Core does not.
>
> > what about hd phrases?
>
> HD phrases, or seed phrases, are the same thing. Bitcoin Core does not support any kind of phrases. It uses HD key derivation, however, but that has nothing to do
...

💬 realsetvin commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605773248)
> > in that case, am I falsely attributing something on dash to bitcoin?
>
> Again, this has nothing to do with the currency, but with the wallet software. If you want seed phrases, feel free to use any of the dozens of other Bitcoin wallet software out there that supports it. Bitcoin Core does not.
>
> > what about hd phrases?
>
> HD phrases, or seed phrases, are the same thing. Bitcoin Core does not support any kind of phrases. It uses HD key derivation, however, but that has nothing to do
...

💬 maflcko commented on pull request "refactor: Use std::span over Span":
(https://github.com/bitcoin/bitcoin/pull/31519#issuecomment-2605828719)
Sure, rebased and worked around a fresh GCC false positive regression in 14 (fixed in 15): https://godbolt.org/z/Gcs5WznYj

💬 furszy commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605828864)
> so that was a dash addition im falsely ascribing to bitcoin core? in that case why cant it be added to btc? Risk of being too convenient for end users?

This was the reason for not adding support for it in the past: https://bitcoin.stackexchange.com/questions/88237/is-there-a-reason-to-why-bitcoin-core-does-not-implement-bip39. The topic could, of course, be revisited by experts in the field.

💬 realsetvin commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605838856)
> > so that was a dash addition im falsely ascribing to bitcoin core? in that case why cant it be added to btc? Risk of being too convenient for end users?
>
> This was the reason for not adding support for it in the past: https://bitcoin.stackexchange.com/questions/88237/is-there-a-reason-to-why-bitcoin-core-does-not-implement-bip39. The topic could, of course, be revisited by experts in the field.

Since many altcoins are based on dash they boast about being built from bitcoin,

it seems funn
...

💬 realsetvin commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605842673)
Wouldnt it be great if the bitcoin core wallet had all of the features that bitcoin developed? Make them optional. not non existent

💬 jimhashhq commented on issue "cmake: Compiling for test coverage (low-priority workaround exists)":
(https://github.com/bitcoin/bitcoin/issues/31638#issuecomment-2605870181)
Hi @hebasto, My cmake version was 3.28.3. I think(?) I generally followed the commands from the developer-notes.md link above:

I did got a little "off script" and instead used the following cmake "user" preset for the clang tool chain with coverage reporting which should be just the same:
{
"name": "my-coverage",
"displayName": "clang coverage mode build for testing",
"cacheVariables": {
"CMAKE_C_COMPILER": "clang",
"CMAKE_CXX_COMPILER": "clang++",

...

🤔 ismaelsadeeq reviewed a pull request: "rpc: add gettarget , target getmininginfo field and show next block info"
(https://github.com/bitcoin/bitcoin/pull/31583#pullrequestreview-2565795711)
Code review ACK cb305da72df501991a6700cd20be79dde4591184

> The gettarget and getdifficulty methods are a bit useless in their current state, because what miners really want to know if the target / difficulty for the next block. So I added a boolean argument next to getdifficulty and gettarget. (These values are typically the same, except for the first block in a retarget period.

> Similarly I added a next object to getmininginfo which shows bit, difficulty and target for the next block.

...

💬 ismaelsadeeq commented on pull request "rpc: add gettarget , target getmininginfo field and show next block info":
(https://github.com/bitcoin/bitcoin/pull/31583#discussion_r1924428164)
nit:
```suggestion
retarget period, by producing blocks approximately 2 minutes apart.
```

💬 ismaelsadeeq commented on pull request "rpc: add gettarget , target getmininginfo field and show next block info":
(https://github.com/bitcoin/bitcoin/pull/31583#discussion_r1924451286)
Should we also the difficulties before mining those blocks?

💬 ismaelsadeeq commented on pull request "rpc: add gettarget , target getmininginfo field and show next block info":
(https://github.com/bitcoin/bitcoin/pull/31583#discussion_r1924430588)
Nice readme, I think other data files should also be explained like this!

💬 glozow commented on pull request "multi-peer orphan resolution followups":
(https://github.com/bitcoin/bitcoin/pull/31666#discussion_r1924467724)
thanks, edited

💬 glozow commented on pull request "multi-peer orphan resolution followups":
(https://github.com/bitcoin/bitcoin/pull/31666#discussion_r1924467780)
thanks, fixed

💬 instagibbs commented on pull request "multi-peer orphan resolution followups":
(https://github.com/bitcoin/bitcoin/pull/31666#discussion_r1924468033)
Thanks for the update even though on second reading it was already ok :)