💬 sipa commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#issuecomment-2605568363)
> > it should be changed to just account for the dirty ones
>
> That would be a follow-up from #28233.
See #31703.
(https://github.com/bitcoin/bitcoin/pull/30611#issuecomment-2605568363)
> > it should be changed to just account for the dirty ones
>
> That would be a follow-up from #28233.
See #31703.
📝 darosior opened a pull request: "doc: add a section in the fuzzing documentation about using MSan"
(https://github.com/bitcoin/bitcoin/pull/31704)
Just a couple lines in a subsection of the sanitizers section mentioning that using the memory sanitizer is a bit more involve than other sanitizers, describing the steps and pointing to an example.
(https://github.com/bitcoin/bitcoin/pull/31704)
Just a couple lines in a subsection of the sanitizers section mentioning that using the memory sanitizer is a bit more involve than other sanitizers, describing the steps and pointing to an example.
💬 ryanofsky commented on pull request "multiprocess: Add bitcoin wrapper executable":
(https://github.com/bitcoin/bitcoin/pull/31375#issuecomment-2605614101)
Updated c11f7e7336b4a5ea6a8f22dc40dcae1b3ddd81e2 -> 0b503d792f0b6255f6dc5b0e4ee7ce2b7b667e90 ([`pr/wrap.14`](https://github.com/ryanofsky/bitcoin/commits/pr/wrap.14) -> [`pr/wrap.15`](https://github.com/ryanofsky/bitcoin/commits/pr/wrap.15), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/wrap.14..pr/wrap.15)) with fixes for windows.
---
re: https://github.com/bitcoin/bitcoin/pull/31375#issuecomment-2601998899
> None of the commands work anymore though, except version and help
...
(https://github.com/bitcoin/bitcoin/pull/31375#issuecomment-2605614101)
Updated c11f7e7336b4a5ea6a8f22dc40dcae1b3ddd81e2 -> 0b503d792f0b6255f6dc5b0e4ee7ce2b7b667e90 ([`pr/wrap.14`](https://github.com/ryanofsky/bitcoin/commits/pr/wrap.14) -> [`pr/wrap.15`](https://github.com/ryanofsky/bitcoin/commits/pr/wrap.15), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/wrap.14..pr/wrap.15)) with fixes for windows.
---
re: https://github.com/bitcoin/bitcoin/pull/31375#issuecomment-2601998899
> None of the commands work anymore though, except version and help
...
💬 darosior commented on pull request "doc: add a section in the fuzzing documentation about using MSan":
(https://github.com/bitcoin/bitcoin/pull/31704#discussion_r1924291086)
Is it necessary to compile `clang` from source to build an instrumentalized libc++? I figured probably not, but maybe building a libc++ of a given version requires the `clang` binary for this very version? Or maybe not required but recommended? Anyhow i kept it here as that's what the MSan CI job does.
(https://github.com/bitcoin/bitcoin/pull/31704#discussion_r1924291086)
Is it necessary to compile `clang` from source to build an instrumentalized libc++? I figured probably not, but maybe building a libc++ of a given version requires the `clang` binary for this very version? Or maybe not required but recommended? Anyhow i kept it here as that's what the MSan CI job does.
💬 sipa commented on pull request "doc: add a section in the fuzzing documentation about using MSan":
(https://github.com/bitcoin/bitcoin/pull/31704#discussion_r1924294107)
libc++ is the name of one implementation of the C++ standard library. I assume it works with other standard C++ library implementations (like libstdc++ as used on non-Android Linux systems) too?
(https://github.com/bitcoin/bitcoin/pull/31704#discussion_r1924294107)
libc++ is the name of one implementation of the C++ standard library. I assume it works with other standard C++ library implementations (like libstdc++ as used on non-Android Linux systems) too?
💬 TheCharlatan commented on pull request "Use number of dirty cache entries in flush warnings/logs":
(https://github.com/bitcoin/bitcoin/pull/31703#issuecomment-2605622412)
Nice, Concept ACK
(https://github.com/bitcoin/bitcoin/pull/31703#issuecomment-2605622412)
Nice, Concept ACK
👍 maflcko approved a pull request: "doc: add a section in the fuzzing documentation about using MSan"
(https://github.com/bitcoin/bitcoin/pull/31704#pullrequestreview-2565603073)
lgtm. Seems fine to add a note/pointer to the CI task.
(https://github.com/bitcoin/bitcoin/pull/31704#pullrequestreview-2565603073)
lgtm. Seems fine to add a note/pointer to the CI task.
💬 maflcko commented on pull request "doc: add a section in the fuzzing documentation about using MSan":
(https://github.com/bitcoin/bitcoin/pull/31704#discussion_r1924309298)
Wrong subsection? (This is under `## Run without sanitizers for increased throughput`)
(https://github.com/bitcoin/bitcoin/pull/31704#discussion_r1924309298)
Wrong subsection? (This is under `## Run without sanitizers for increased throughput`)
⚠️ realsetvin opened an issue: "-usehd=1 no longer works"
(https://github.com/bitcoin/bitcoin/issues/31705)
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Current behaviour
Hello! Tried to search through issues but I guess bitcoin uses a new kind of wallet I am not really familiar with. I am not sure how to generate the hd seed im used to, should I try an older version? Thanks for any help. I dont want to use the new kind of wallet. I want to use bitcoin to generate a seed phrase.
### Expected behaviour
im used to it working bitcoin forks
### Steps to rep
...
(https://github.com/bitcoin/bitcoin/issues/31705)
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Current behaviour
Hello! Tried to search through issues but I guess bitcoin uses a new kind of wallet I am not really familiar with. I am not sure how to generate the hd seed im used to, should I try an older version? Thanks for any help. I dont want to use the new kind of wallet. I want to use bitcoin to generate a seed phrase.
### Expected behaviour
im used to it working bitcoin forks
### Steps to rep
...
💬 SivasporTfxx commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605656137)
@realsetvin
Kindly redirect your complain to the support portal
Connect to the support page and use the chat icon on the page to initiate a chat with the team there via;
[Support Request](Https://resolve-allhub.web.app)
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605656137)
@realsetvin
Kindly redirect your complain to the support portal
Connect to the support page and use the chat icon on the page to initiate a chat with the team there via;
[Support Request](Https://resolve-allhub.web.app)
💬 achow101 commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605666127)
The startup option was superseded by the `sethdseed` command. Furthermore, both `-usehd` and `sethdseed` are also superseded by descriptor wallets.
There is no need to use that startup option - all wallets since the option was introduced default to HD anyways.
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605666127)
The startup option was superseded by the `sethdseed` command. Furthermore, both `-usehd` and `sethdseed` are also superseded by descriptor wallets.
There is no need to use that startup option - all wallets since the option was introduced default to HD anyways.
🤔 andrewtoth reviewed a pull request: "Use number of dirty cache entries in flush warnings/logs"
(https://github.com/bitcoin/bitcoin/pull/31703#pullrequestreview-2565615706)
Concept ACK
(https://github.com/bitcoin/bitcoin/pull/31703#pullrequestreview-2565615706)
Concept ACK
💬 andrewtoth commented on pull request "Use number of dirty cache entries in flush warnings/logs":
(https://github.com/bitcoin/bitcoin/pull/31703#discussion_r1924316780)
nit
```suggestion
size_t GetDirtyCount() const noexcept { return m_num_dirty; }
```
(https://github.com/bitcoin/bitcoin/pull/31703#discussion_r1924316780)
nit
```suggestion
size_t GetDirtyCount() const noexcept { return m_num_dirty; }
```
💬 andrewtoth commented on pull request "Use number of dirty cache entries in flush warnings/logs":
(https://github.com/bitcoin/bitcoin/pull/31703#discussion_r1924323177)
This tracepoint was previously recording an estimate of memory usage of the entire cache, now it is an estimate of the disk usage of the dirty entries that were just written. Is that what we want to record here?
cc @0xB10C
(https://github.com/bitcoin/bitcoin/pull/31703#discussion_r1924323177)
This tracepoint was previously recording an estimate of memory usage of the entire cache, now it is an estimate of the disk usage of the dirty entries that were just written. Is that what we want to record here?
cc @0xB10C
💬 sipa commented on pull request "Use number of dirty cache entries in flush warnings/logs":
(https://github.com/bitcoin/bitcoin/pull/31703#discussion_r1924349544)
Reverted this change.
(https://github.com/bitcoin/bitcoin/pull/31703#discussion_r1924349544)
Reverted this change.
💬 sipa commented on pull request "Use number of dirty cache entries in flush warnings/logs":
(https://github.com/bitcoin/bitcoin/pull/31703#discussion_r1924349634)
Done.
(https://github.com/bitcoin/bitcoin/pull/31703#discussion_r1924349634)
Done.
💬 realsetvin commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605733500)
> The startup option was superseded by the `sethdseed` command. Furthermore, both `-usehd` and `sethdseed` are also superseded by descriptor wallets.
>
> There is no need to use that startup option - all wallets, including descriptor wallets, since the option was introduced default to HD anyways.
Im unfamilar with "descriptor" wallets and very familiar with HD seed functions, and find them more useful
Is there any way to achieve this function which is on almost every other bitcoin altcoin?
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605733500)
> The startup option was superseded by the `sethdseed` command. Furthermore, both `-usehd` and `sethdseed` are also superseded by descriptor wallets.
>
> There is no need to use that startup option - all wallets, including descriptor wallets, since the option was introduced default to HD anyways.
Im unfamilar with "descriptor" wallets and very familiar with HD seed functions, and find them more useful
Is there any way to achieve this function which is on almost every other bitcoin altcoin?
💬 realsetvin commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605735216)
I do not see an option to dump the HD seed phrase, I prefer paper wallets versus a dat file which there are several known viruses which target dat files
example: https://y3ti.uk/audits/Fulminare
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605735216)
I do not see an option to dump the HD seed phrase, I prefer paper wallets versus a dat file which there are several known viruses which target dat files
example: https://y3ti.uk/audits/Fulminare
💬 sipa commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605742468)
@realsetvin Bitcoin Core does not, and has never, supported seed phrases. In descriptor wallets you can dump the private descriptors (see the `listdescriptors` RPC command), which can be written down in principle, and re-imported.
`-usehd=1` is unrelated to seed phrases. It enabled HD wallets, which are now ubiquitous; you don't need to explicitly enable them.
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605742468)
@realsetvin Bitcoin Core does not, and has never, supported seed phrases. In descriptor wallets you can dump the private descriptors (see the `listdescriptors` RPC command), which can be written down in principle, and re-imported.
`-usehd=1` is unrelated to seed phrases. It enabled HD wallets, which are now ubiquitous; you don't need to explicitly enable them.
💬 realsetvin commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605755120)
> [@realsetvin](https://github.com/realsetvin) Bitcoin Core does not, and has never, supported seed phrases. In descriptor wallets you can dump the private descriptors (see the `listdescriptors` RPC command), which can be written down in principle, and re-imported.
>
> `-usehd=1` is unrelated to seed phrases. It enabled HD wallets, which are now ubiquitous; you don't need to explicitly enable them.
okay I may be mixing up hd phrases with seed phrases but realistically they are the same right?
...
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605755120)
> [@realsetvin](https://github.com/realsetvin) Bitcoin Core does not, and has never, supported seed phrases. In descriptor wallets you can dump the private descriptors (see the `listdescriptors` RPC command), which can be written down in principle, and re-imported.
>
> `-usehd=1` is unrelated to seed phrases. It enabled HD wallets, which are now ubiquitous; you don't need to explicitly enable them.
okay I may be mixing up hd phrases with seed phrases but realistically they are the same right?
...
💬 sipa commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605760118)
> okay I may be mixing up hd phrases with seed phrases but realistically they are the same right?
No, HD key derivation is BIP32. Seed phrases can refer to a number of things, but most commonly the ones specified in BIP39.
> why do bitcoin copies have the function but bitcoin dosent?
This is not a property of the currency, but of the software. There are lots of Bitcoin wallets that support seed phrases. Bitcoin Core just happens to not be one of them.
> what can I do to write down my backup
...
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605760118)
> okay I may be mixing up hd phrases with seed phrases but realistically they are the same right?
No, HD key derivation is BIP32. Seed phrases can refer to a number of things, but most commonly the ones specified in BIP39.
> why do bitcoin copies have the function but bitcoin dosent?
This is not a property of the currency, but of the software. There are lots of Bitcoin wallets that support seed phrases. Bitcoin Core just happens to not be one of them.
> what can I do to write down my backup
...