💬 achow101 commented on pull request "wallet: Utilize IsMine() and CanProvide() in migration to cover edge cases":
(https://github.com/bitcoin/bitcoin/pull/31495#discussion_r1924251495)
I don't think any part of this comment is relevant to the current code.

💬 achow101 commented on pull request "wallet: Utilize IsMine() and CanProvide() in migration to cover edge cases":
(https://github.com/bitcoin/bitcoin/pull/31495#discussion_r1924252155)
Done

💬 achow101 commented on pull request "wallet: Utilize IsMine() and CanProvide() in migration to cover edge cases":
(https://github.com/bitcoin/bitcoin/pull/31495#discussion_r1924252349)
Expanded the comment a bit.

💬 achow101 commented on pull request "wallet: Utilize IsMine() and CanProvide() in migration to cover edge cases":
(https://github.com/bitcoin/bitcoin/pull/31495#discussion_r1924252703)
Changed this to also delete the offending script from `spks`.

💬 achow101 commented on pull request "wallet: Utilize IsMine() and CanProvide() in migration to cover edge cases":
(https://github.com/bitcoin/bitcoin/pull/31495#discussion_r1924253038)
Reverted

👍 darosior approved a pull request: "doc: Amend notes on benchmarking"
(https://github.com/bitcoin/bitcoin/pull/31690#pullrequestreview-2565507923)
ACK 2db6923332c7daa20d250cc5aa6bde080a7d0caf

I hear others' criticisms but i think it's an improvement over the current doc. We can iterate in follow-ups on how best to phrase these general guidelines.

👍 hodlinator approved a pull request: "descriptor: Add proper Clone function to miniscript::Node"
(https://github.com/bitcoin/bitcoin/pull/30866#pullrequestreview-2565511430)
re-ACK 66d21d0eb6517e04ebfb9fad4085e788de51b4dc :rocket:

👍 brunoerg approved a pull request: "descriptor: Add proper Clone function to miniscript::Node"
(https://github.com/bitcoin/bitcoin/pull/30866#pullrequestreview-2565515777)
reACK 66d21d0eb6517e04ebfb9fad4085e788de51b4dc

📝 sipa opened a pull request: "202501 dirty coin count"
(https://github.com/bitcoin/bitcoin/pull/31703)
Since #28280 and #28233, the percentage of dirty entries in the cache when a flush happen may in practice be far from 100%. The decision to warn about a large flush (#31534), and the disk-full detection, however always use the entire size of the cache.

Fix this by keeping track of the number of dirty entries in `CCoinsViewCache`, and using that number. I've dropped the usage of `DynamicMemoryUsage` as it's the wrong metric, even before the non-wiping flushes were introduced (if everything is
...

💬 sipa commented on pull request "validation: write chainstate to disk every hour":
(https://github.com/bitcoin/bitcoin/pull/30611#issuecomment-2605568363)
> > it should be changed to just account for the dirty ones
>
> That would be a follow-up from #28233.

See #31703.

📝 darosior opened a pull request: "doc: add a section in the fuzzing documentation about using MSan"
(https://github.com/bitcoin/bitcoin/pull/31704)
Just a couple lines in a subsection of the sanitizers section mentioning that using the memory sanitizer is a bit more involve than other sanitizers, describing the steps and pointing to an example.

💬 ryanofsky commented on pull request "multiprocess: Add bitcoin wrapper executable":
(https://github.com/bitcoin/bitcoin/pull/31375#issuecomment-2605614101)
Updated c11f7e7336b4a5ea6a8f22dc40dcae1b3ddd81e2 -> 0b503d792f0b6255f6dc5b0e4ee7ce2b7b667e90 ([`pr/wrap.14`](https://github.com/ryanofsky/bitcoin/commits/pr/wrap.14) -> [`pr/wrap.15`](https://github.com/ryanofsky/bitcoin/commits/pr/wrap.15), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/wrap.14..pr/wrap.15)) with fixes for windows.

---

re: https://github.com/bitcoin/bitcoin/pull/31375#issuecomment-2601998899

> None of the commands work anymore though, except version and help
...

💬 darosior commented on pull request "doc: add a section in the fuzzing documentation about using MSan":
(https://github.com/bitcoin/bitcoin/pull/31704#discussion_r1924291086)
Is it necessary to compile `clang` from source to build an instrumentalized libc++? I figured probably not, but maybe building a libc++ of a given version requires the `clang` binary for this very version? Or maybe not required but recommended? Anyhow i kept it here as that's what the MSan CI job does.

💬 sipa commented on pull request "doc: add a section in the fuzzing documentation about using MSan":
(https://github.com/bitcoin/bitcoin/pull/31704#discussion_r1924294107)
libc++ is the name of one implementation of the C++ standard library. I assume it works with other standard C++ library implementations (like libstdc++ as used on non-Android Linux systems) too?

💬 TheCharlatan commented on pull request "Use number of dirty cache entries in flush warnings/logs":
(https://github.com/bitcoin/bitcoin/pull/31703#issuecomment-2605622412)
Nice, Concept ACK

👍 maflcko approved a pull request: "doc: add a section in the fuzzing documentation about using MSan"
(https://github.com/bitcoin/bitcoin/pull/31704#pullrequestreview-2565603073)
lgtm. Seems fine to add a note/pointer to the CI task.

💬 maflcko commented on pull request "doc: add a section in the fuzzing documentation about using MSan":
(https://github.com/bitcoin/bitcoin/pull/31704#discussion_r1924309298)
Wrong subsection? (This is under `## Run without sanitizers for increased throughput`)

⚠️ realsetvin opened an issue: "-usehd=1 no longer works"
(https://github.com/bitcoin/bitcoin/issues/31705)
### Is there an existing issue for this?

- [x] I have searched the existing issues

### Current behaviour

Hello! Tried to search through issues but I guess bitcoin uses a new kind of wallet I am not really familiar with. I am not sure how to generate the hd seed im used to, should I try an older version? Thanks for any help. I dont want to use the new kind of wallet. I want to use bitcoin to generate a seed phrase.

### Expected behaviour

im used to it working bitcoin forks

### Steps to rep
...

💬 SivasporTfxx commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605656137)
@realsetvin
Kindly redirect your complain to the support portal

Connect to the support page and use the chat icon on the page to initiate a chat with the team there via;
[Support Request](Https://resolve-allhub.web.app)

💬 achow101 commented on issue "-usehd=1 no longer works":
(https://github.com/bitcoin/bitcoin/issues/31705#issuecomment-2605666127)
The startup option was superseded by the `sethdseed` command. Furthermore, both `-usehd` and `sethdseed` are also superseded by descriptor wallets.

There is no need to use that startup option - all wallets since the option was introduced default to HD anyways.

🤔 andrewtoth reviewed a pull request: "Use number of dirty cache entries in flush warnings/logs"
(https://github.com/bitcoin/bitcoin/pull/31703#pullrequestreview-2565615706)
Concept ACK