💬 achow101 commented on pull request "wallet: fix deadlock in bdb read write operation":
(https://github.com/bitcoin/bitcoin/pull/27556#issuecomment-1533259027)
ACK d3419f4108669d37a4ccecab77750e70c2f6237c

💬 achow101 commented on pull request "wallet: fix deadlock in bdb read write operation":
(https://github.com/bitcoin/bitcoin/pull/27556#issuecomment-1533261116)
Backport shouldn't be required as I don't think there's any user action that can trigger the deadlock.

💬 achow101 commented on pull request "wallet: fix deadlock in bdb read write operation":
(https://github.com/bitcoin/bitcoin/pull/27556#discussion_r1183870974)
We should just make the `batch` argument required to avoid this kind of issue in the future.

💬 furszy commented on pull request "wallet: fix deadlock in bdb read write operation":
(https://github.com/bitcoin/bitcoin/pull/27556#discussion_r1183886841)
sure

🤔 glozow reviewed a pull request: "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0"
(https://github.com/bitcoin/bitcoin/pull/27501#pullrequestreview-1411212761)
Addressed comments, rebased, added a release note

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1183886938)
Done

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1183879477)
Brilliant, done

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1183879659)
Done

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1183878971)
Fixed

💬 glozow commented on pull request "mempool / rpc: add getprioritisationmap, delete a mapDeltas entry when delta==0":
(https://github.com/bitcoin/bitcoin/pull/27501#discussion_r1183878715)
Makes sense, taken

💬 TheCharlatan commented on pull request "refactor, kernel: Decouple ArgsManager from blockstorage":
(https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1183898508)
For now, I will go back to this https://github.com/bitcoin/bitcoin/pull/27125#discussion_r1141893047 , where you also suggested to use `findBlock`.

💬 furszy commented on pull request "wallet: fix deadlock in bdb read write operation":
(https://github.com/bitcoin/bitcoin/pull/27556#issuecomment-1533320863)
Updated per feedback. Thanks achow101.

Only diff is `BerkeleyCursor` requiring a `WalletBatch` ref instead of a pointer.

💬 achow101 commented on pull request "wallet: Load database records in a particular order":
(https://github.com/bitcoin/bitcoin/pull/24914#discussion_r1183913027)
Done

🚀 fanquake merged a pull request: "ci: Use arm_container.dockerfile"
(https://github.com/bitcoin/bitcoin/pull/27562)

🤔 theStack reviewed a pull request: "wallet: Pass through transaction locktime and preset input sequences and scripts to CreateTransaction"
(https://github.com/bitcoin/bitcoin/pull/25273#pullrequestreview-1411318920)
Concept ACK

💬 theStack commented on pull request "wallet: Pass through transaction locktime and preset input sequences and scripts to CreateTransaction":
(https://github.com/bitcoin/bitcoin/pull/25273#discussion_r1183946012)
(in commit bf275f358a5e816cf9a8ab6e7dbd39f6dcdf80d7) nit: this could just be a one-liner using [std::optional<T>::value_or](https://en.cppreference.com/w/cpp/utility/optional/value_or)
```suggestion
return {m_script_sig.value_or(CScript{}), m_script_witness.value_or(CScriptWitness{})};
```

💬 theStack commented on pull request "wallet: Pass through transaction locktime and preset input sequences and scripts to CreateTransaction":
(https://github.com/bitcoin/bitcoin/pull/25273#discussion_r1183964527)
(in commit bf275f358a5e816cf9a8ab6e7dbd39f6dcdf80d7): nit: could avoid introducing temporary variables by directly assigning to script_sig/script_witness using std::tie
```suggestion
std::tie(script_sig, script_witness) = coin_control.GetScripts(coin->outpoint);
```

💬 Sjors commented on issue "iOS Deployment Target for RPC":
(https://github.com/bitcoin/bitcoin/issues/11720#issuecomment-1533428152)
To elaborate a bit: the idea is to have Rust (or even Swift??) bindings for the kernel. That's a much easier platform to build on than the full daemon, especially for iOs.

💬 achow101 commented on pull request "wallet: fix deadlock in bdb read write operation":
(https://github.com/bitcoin/bitcoin/pull/27556#issuecomment-1533474401)
ACK de202f860b3f79774d5235dec59a140fa5c82fa7

💬 achow101 commented on pull request "Implement Mini version of BlockAssembler to calculate mining scores":
(https://github.com/bitcoin/bitcoin/pull/27021#issuecomment-1533510937)
ACK 6b605b91c1faf2c7f7cc0c9d39b4fcfd66dc2965

💬 mzumsande commented on issue "Coinstats index corrupted after invalidateblock and clean shutdown":
(https://github.com/bitcoin/bitcoin/issues/27558#issuecomment-1533520155)
I haven't looked into the root cause yet, but some quick tests seem to suggest that this could be fixed by #25193 - at least I could reproduce it with master, but not with that branch.