💬 achow101 commented on pull request "rpc: Add signet_challenge field to getblockchaininfo and getmininginfo":
(https://github.com/bitcoin/bitcoin/pull/31531#issuecomment-2565782475)
ACK ecaa786cc103cf7cc63ae899ec13d81a54e2fd1e

📝 Sjors converted_to_draft a pull request: "Add checkblock RPC and checkBlock() to Mining interface"
(https://github.com/bitcoin/bitcoin/pull/31564)
## Rationale

### Verifying block templates (no PoW)

Stratum v2 and DATUM allow miners to generate their own block template. Pools may wish (or need) to verify these templates. This typically involves comparing mempools, asking miners to providing missing transactions and then reconstructing the proposed block.[^0] This is not sufficient to ensure a proposed block is actually valid. In some schemes miners could take advantage of incomplete validation[^1].

The Stratum Reference Implementa
...

💬 achow101 commented on pull request "refactor: std::span compat fixes":
(https://github.com/bitcoin/bitcoin/pull/31540#issuecomment-2565786650)
ACK fa494a1d53f3f030fafe7b533d72b2200428a0fd

🚀 achow101 merged a pull request: "Remove unused variable assignment"
(https://github.com/bitcoin/bitcoin/pull/31497)

💬 Sjors commented on pull request "Add checkblock RPC and checkBlock() to Mining interface":
(https://github.com/bitcoin/bitcoin/pull/31564#issuecomment-2565793245)
I might make a separate PR to consider whether to drop `AssertLockHeld(cs_main)` from the original `TestBlockValidity`.

If that ends up rejected, then I'll keep the existing `TestBlockValidity` calls as they are, i.e. drop the last two commits from this PR and leave them as a followup.

💬 achow101 commented on pull request "rpc: increase the defaults for -rpcthreads and -rpcworkqueue":
(https://github.com/bitcoin/bitcoin/pull/31215#issuecomment-2565793417)
ACK e56fc7ce6a92eae7e80657d9f57a148cc002358d

Low powered machines have advanced quite a lot in the past decade, makes sense to increase these.

💬 achow101 commented on pull request "test: report detailed msg during utf8 response decoding error":
(https://github.com/bitcoin/bitcoin/pull/31251#issuecomment-2565795242)
ACK a2c45ae5480a2ee643665d6ecaee9714a287a70e

🚀 achow101 merged a pull request: "rpc: Add signet_challenge field to getblockchaininfo and getmininginfo"
(https://github.com/bitcoin/bitcoin/pull/31531)

✅ achow101 closed an issue: "Default rpcthreads value (4) is too small"
(https://github.com/bitcoin/bitcoin/issues/29386)

🚀 achow101 merged a pull request: "rpc: increase the defaults for -rpcthreads and -rpcworkqueue"
(https://github.com/bitcoin/bitcoin/pull/31215)

💬 furszy commented on pull request "descriptor: Add proper Clone function to miniscript::Node":
(https://github.com/bitcoin/bitcoin/pull/30866#issuecomment-2565809261)
Any way to add a test that fails without the [last push](https://github.com/bitcoin/bitcoin/compare/6a00ea17c136e67a66f3558dd2d02a07860b0afe..b579e3413a1b4ff893fafcecdc1a55dd722f820e).

🚀 achow101 merged a pull request: "refactor: std::span compat fixes"
(https://github.com/bitcoin/bitcoin/pull/31540)

💬 achow101 commented on pull request "test: Call generate RPCs through test framework only":
(https://github.com/bitcoin/bitcoin/pull/31403#issuecomment-2565824667)
ACK fa6e599cf9fbacb393ac17e0a1b3572f217817f0

💬 achow101 commented on pull request "test: Avoid intermittent error in assert_equal(pruneheight_new, 248)":
(https://github.com/bitcoin/bitcoin/pull/31468#issuecomment-2565829351)
ACK fa0998f0a028161fe7264d0e81af36ffdcb43384

🚀 achow101 merged a pull request: "test: report detailed msg during utf8 response decoding error"
(https://github.com/bitcoin/bitcoin/pull/31251)

💬 achow101 commented on pull request "qa: Limit `-maxconnections` in tests":
(https://github.com/bitcoin/bitcoin/pull/31537#issuecomment-2565832426)
ACK d9d5bc2e7466033d989432f53a112325fa3d6d4a

🚀 achow101 merged a pull request: "test: Call generate RPCs through test framework only"
(https://github.com/bitcoin/bitcoin/pull/31403)

💬 Sjors commented on pull request "test: have miner_tests use Mining interface":
(https://github.com/bitcoin/bitcoin/pull/31581#issuecomment-2565835622)
I dropped the second commit, as I was confused. This PR should now be very easy to review.

💬 achow101 commented on pull request "validation: Send correct notification during snapshot completion":
(https://github.com/bitcoin/bitcoin/pull/31556#issuecomment-2565840703)
ACK bc43ecaf6dc0830a27296d3a29428814fed07bb1

💬 achow101 commented on pull request "rpc: Extend scope of validation mutex in generateblock":
(https://github.com/bitcoin/bitcoin/pull/31563#issuecomment-2565841234)
ACK fa63b8232f38e78d3c6413fa7d51809f376de75c

💬 achow101 commented on pull request "test: descriptor: fix test for `MaxSatisfactionWeight`":
(https://github.com/bitcoin/bitcoin/pull/31570#issuecomment-2565842092)
ACK b29d68f942e333d2cfdd6be8d49fe484e0d15e11