🚀 fanquake merged a pull request: "[28.x] Backports & 28.1rc1"
(https://github.com/bitcoin/bitcoin/pull/31104)

💬 vasild commented on pull request "ci: detect outbound internet traffic generated while running tests":
(https://github.com/bitcoin/bitcoin/pull/31349#discussion_r1869542423)
Ok, I changed this to fail if `tcpdump` gives error when it reads the file.

💬 vasild commented on pull request "ci: detect outbound internet traffic generated while running tests":
(https://github.com/bitcoin/bitcoin/pull/31349#issuecomment-2517450862)
`feabffd808...925ee8707e`: (hopefully) address https://github.com/bitcoin/bitcoin/pull/31349#discussion_r1869211837

💬 hebasto commented on issue "macOS 13.7 depends build can't find qt (symlink)":
(https://github.com/bitcoin/bitcoin/issues/31050#issuecomment-2517454703)
@Sjors

I've managed to reproduce the issue.

I believe https://github.com/bitcoin/bitcoin/pull/31358 should resolve it. Could you please verify the fix on your system?

💬 hebasto commented on pull request "depends, refactor: Avoid hardcoding `host_prefix` in toolchain file":
(https://github.com/bitcoin/bitcoin/pull/31358#issuecomment-2517459170)
> Is there any particular motivation (to do this now), given it doesn't work/can't be tested?

Apparently, this PR fixes https://github.com/bitcoin/bitcoin/issues/31050.

💬 glozow commented on pull request "package validation: relax the package-not-child-with-unconfirmed-parents rule":
(https://github.com/bitcoin/bitcoin/pull/31385#discussion_r1869569271)
added

💬 glozow commented on pull request "package validation: relax the package-not-child-with-unconfirmed-parents rule":
(https://github.com/bitcoin/bitcoin/pull/31385#issuecomment-2517544785)
Rebased after #31096 and took @instagibbs' comment, thank you

👋 glozow's pull request is ready for review: "package validation: relax the package-not-child-with-unconfirmed-parents rule"
(https://github.com/bitcoin/bitcoin/pull/31385)

👍 hodlinator approved a pull request: "refactor: Check translatable format strings at compile-time"
(https://github.com/bitcoin/bitcoin/pull/31061#pullrequestreview-2477648972)
ACK f4df783f1ca22d96476d52ec5d1929547691ba13

Increased validation of format strings. :+1:

---

Maybe amend PR summary or final commit by spelling out something like:

Delays `bilingual_str`-construction until the end of the overload of `tinyformat::format` in *translation.h*. The `fmt` parameter to the overload is changed from `bilingual_str` -> `util::bilingual_fmt`, the latter being a new type which contains a `ConstevalFormatString`. `bilingual_fmt` in turn is only constructible fr
...

💬 hodlinator commented on pull request "refactor: Check translatable format strings at compile-time":
(https://github.com/bitcoin/bitcoin/pull/31061#discussion_r1869532227)
nit: Can't we just be explicit here in the test to document what is happening, since it is slightly tricky?
```suggestion
constexpr util::Translatable<false> format{Untranslated("original [%s]")};
```

💬 hodlinator commented on pull request "refactor: Check translatable format strings at compile-time":
(https://github.com/bitcoin/bitcoin/pull/31061#discussion_r1868949895)
nit:
```suggestion
std::string translate() const { return translatable ? util::translate(original.fmt) : original.fmt; }
```

⚠️ fanquake opened an issue: "test: failure in `interface_usdt_net.py`"
(https://github.com/bitcoin/bitcoin/issues/31418)
Master @ ae69fc37e4fff237a119225061d68f69e6cd61d7.
Running on Rawhide.
GCC: `gcc (GCC) 14.2.1 20241104 (Red Hat 14.2.1-6)`.
Systemtap: `systemtap-5.2-1.fc42.src.rpm`

```bash
cmake -B build -DWITH_USDT=ON
cmake --build build -j17
./build/test/functional/test_runner.py --jobs=17
```

```bash
123/314 - interface_usdt_net.py failed, Duration: 3 s

stdout:
2024-12-04T14:13:14.071000Z TestFramework (INFO): PRNG seed is: 2457885293535030371
2024-12-04T14:13:14.072000Z TestFramework (IN
...

💬 ryanofsky commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#discussion_r1869619567)
The version number is always going to be displayed whether you run `bitcoind` with `-version` `-help` or no arguments at all, because it is logged at startup. If you don't want to see the version number you need to run `bitcoind` with `-noprinttoconsole` or `-daemon` to not log to the console.

The point of `-version` is to show the version number and copyright information and exit, and the point of `-noversion` is to do the opposite and start up normally. You can think of `-version` as being
...

💬 l0rinc commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#discussion_r1869626885)
I'm not yet sure this makes the behavior clearer for the version parameter, but the rest seems fine to me, thanks for clarifying.

💬 maflcko commented on issue "test: failure in `interface_usdt_net.py`":
(https://github.com/bitcoin/bitcoin/issues/31418#issuecomment-2517585497)
cc @0xB10C

💬 fanquake commented on issue "test: failure in `interface_usdt_net.py`":
(https://github.com/bitcoin/bitcoin/issues/31418#issuecomment-2517588711)
This also happens on `28.x`.

💬 l0rinc commented on pull request "util: Improve documentation and negation of args":
(https://github.com/bitcoin/bitcoin/pull/31212#issuecomment-2517591742)
utACK 95a0104f2e9869799db84add108ae8c57b56d360
The code seems better than before, though most of these negations seem confusing to me - but it wasn't introduced here.
I have tested the negation of the parameters and reviewed most of the code - but couldn't meaningfully opine on the cookie related new tests, I will leave that to other reviewers.

👍 hodlinator approved a pull request: "refactor: Prepare compile-time check of bilingual format strings"
(https://github.com/bitcoin/bitcoin/pull/31295#pullrequestreview-2478868111)
cr-ACK fa3e074304780549b1e7972217930e34fa55f59a

#### Before
```C++
strprintf(_("Copyright (C) %i-%i").translated, 2009, COPYRIGHT_YEAR)
```
1. Create a `bilingual_str` of `"Copyright (C) %i-%i"`.
1. Calls `G_TRANSLATION_FUN("Copyright (C) %i-%i")`, getting something like `"Szerzői jog (c) %i-%i"`, and storing it in `.translated`.
2. Perform regular `strprintf()` (`tfm::format(std::string...)`) on the returned `.translated` and substitute in the values, yielding `"Szerzői jog (c) 2009-2
...

💬 maflcko commented on issue "test: failure in `interface_usdt_net.py`":
(https://github.com/bitcoin/bitcoin/issues/31418#issuecomment-2517604299)
I guess an easy fix would be to just rename `MIN` to `net_tracepoints_MIN`?

💬 glozow commented on pull request "p2p: track and use all potential peers for orphan resolution":
(https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1869654727)
Ah, need to add the size of `unique_parents` to this. Surprised fuzzer has not tripped on it...

💬 ryanofsky commented on pull request "multiprocess: Add bitcoin wrapper executable":
(https://github.com/bitcoin/bitcoin/pull/31375#issuecomment-2517621750)
Updated 02567bf2bef5997ea5f0765780d196f36d3053e8 -> 2def75a15deeb39fa66b1e8d45679ac29fd18b82 ([`pr/wrap.6`](https://github.com/ryanofsky/bitcoin/commits/pr/wrap.6) -> [`pr/wrap.7`](https://github.com/ryanofsky/bitcoin/commits/pr/wrap.7), [compare](https://github.com/ryanofsky/bitcoin/compare/pr/wrap.6..pr/wrap.7)) to fix argument parsing bug causing a test failure on windows https://github.com/bitcoin/bitcoin/actions/runs/12147886951/job/33875123699?pr=31375#step:12:95