💬 emc99 commented on issue "Drop support for g++-8?":
(https://github.com/bitcoin/bitcoin/issues/27537#issuecomment-1527893748)
What does ACK mean?

💬 jonatack commented on issue "Drop support for g++-8?":
(https://github.com/bitcoin/bitcoin/issues/27537#issuecomment-1527895120)
> What does ACK mean?

https://jonatack.github.io/articles/how-to-review-pull-requests-in-bitcoin-core#terminology

💬 Riahiamirreza commented on issue "rpc: show P2(W)SH redeemScript in getrawtransaction (and friends)":
(https://github.com/bitcoin/bitcoin/issues/27391#issuecomment-1527913381)
Okay, I'm currently working on this issue. But it may take a while, since this is my first contribution.

💬 Sjors commented on pull request "Multiprocess bitcoin":
(https://github.com/bitcoin/bitcoin/pull/10102#issuecomment-1527920697)
Building c86da22175e5bbe40e03624689bd3d4cc1508ba1 fails when configured without a wallet, but with gui.

Intel macOS 13.3.1 with capnp 0.10.3 via homebrew and libmultiprocess 1af83d15239ccfa7e47b8764029320953dd7fdf1.

```
./configure --enable-suppress-external-warnings --enable-c++20 --with-gui --enable-multiprocess --disable-bench --disable-tests --disable-external-signer --disable-fuzz-binary --disable-wallet
...
make
...
CXXLD bitcoin-gui
Undefined symbols for architecture x8
...

📝 Empact opened a pull request: "init: Fixes for file descriptor accounting"
(https://github.com/bitcoin/bitcoin/pull/27539)
This rebases and revises #16003 for clarity of review.

Aims to fix #18911.

💬 0xB10C commented on pull request "ci: use LLVM/clang-16 in native_asan job":
(https://github.com/bitcoin/bitcoin/pull/27360#issuecomment-1528104826)
Can't really comment on the change of using clang-16. The second commit dropping the bpfcc-tools from the PPA looks fine. You could remove the reference to this PR from the description of 5fbda45d2b962a67221ea0c8c35e38f6eef06499.

💬 RandyMcMillan commented on pull request "Updated the installation instructions for macOS":
(https://github.com/bitcoin/bitcoin/pull/27525#issuecomment-1528126395)
ACK


💬 RandyMcMillan commented on pull request "Updated the installation instructions for macOS":
(https://github.com/bitcoin/bitcoin/pull/27525#issuecomment-1528130736)
Note: it is good idea to check that markdown looks good in desktop editors (macdown for example) - github flavored markdown has diverged from other flavors and sometimes there are minor issues.

💬 HenrikJannsen commented on pull request "Remove BIP35 mempool p2p message":
(https://github.com/bitcoin/bitcoin/pull/27426#issuecomment-1528610256)
> The mempool message is used by all wallets based on bitcoinj to learn about pending transactions, in both full blocks mode and also in filtered mode. The estimated install base is 10M+.

I guess the large install base should be reason enough to drop that proposal.

[Bisq](https://bisq.network/) is using BitcoinJ and would be affected by that proposed change as well.

💬 pablomartin4btc commented on pull request "httpserver, rest: fix segmentation fault on evhttp_uri_get_query":
(https://github.com/bitcoin/bitcoin/pull/27253#issuecomment-1528701927)
- Fixed`http_request`fuzz failure and added some relevant comments in the code.

📝 JurbinM opened a pull request: "Create devcontainer.json"
(https://github.com/bitcoin/bitcoin/pull/27541)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

✅ hebasto closed a pull request: "Create devcontainer.json"
(https://github.com/bitcoin/bitcoin/pull/27541)

📝 hebasto locked a pull request: "Create devcontainer.json"
(https://github.com/bitcoin/bitcoin/pull/27541)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 TheCharlatan commented on pull request "rpc: Optimize serialization disk space of dumptxoutset":
(https://github.com/bitcoin/bitcoin/pull/26045#issuecomment-1528716678)
Re https://github.com/bitcoin/bitcoin/pull/26045#issuecomment-1472285629

> I was also wondering why the bitcoin-cli savetxoutset API (same goes for savemempool) requires to specify a filename instead of writing to stdout that would offer better composition while maintaining the possibility to write to file with >utxo.bin

Writing to stdout would mean that the data would have to be carried over the rpc connection, right?

💬 theStack commented on pull request "script: remove unused bitwise `CScriptNum` operators":
(https://github.com/bitcoin/bitcoin/pull/27096#issuecomment-1528724501)
> Idk, this is probably too hard to review to be worth it. You are removing an overload, so reviewers need to check how this interacts with overload resolution. Maybe just close and reopen/mention it the next time the code is touched an reviewers are primed on it?

Agree that reviewing this is more cumbersome than it should be (this is just another example of how overloading leads to obfuscation and makes maintaining code harder). Closing for now.

✅ theStack closed a pull request: "script: remove unused bitwise `CScriptNum` operators"
(https://github.com/bitcoin/bitcoin/pull/27096)

📝 theStack opened a pull request: "test: add ripemd160 to test framework modules list"
(https://github.com/bitcoin/bitcoin/pull/27542)
Currently test runner doesn't execute the unit tests of the ripemd160 module, so add it to the list. All other framework modules that contain unit tests are included, as can be easily checked via
`$ git grep unittest.TestCase ./test/functional/test_framework/`

This is a late follow-up to PR #23716 (commit ad3e9e1f214d739e098c6ebbd300da5df1026a44).

💬 pablomartin4btc commented on pull request "httpserver, rest: fix segmentation fault on evhttp_uri_get_query":
(https://github.com/bitcoin/bitcoin/pull/27253#issuecomment-1528760293)
- Updated 2nd commit message.

💬 kevkevinpal commented on pull request "rpc: Add test-only RPC getaddrmaninfo for new/tried table address count":
(https://github.com/bitcoin/bitcoin/pull/27511#discussion_r1181081666)
Do you think we can add total to this test aswell?

💬 brunoerg commented on pull request "test: add coverage for `-bantime`":
(https://github.com/bitcoin/bitcoin/pull/26604#discussion_r1181104225)
Where is/why the one second sleep?

💬 Riahiamirreza commented on issue "rpc: show P2(W)SH redeemScript in getrawtransaction (and friends)":
(https://github.com/bitcoin/bitcoin/issues/27391#issuecomment-1528866113)
For backward compatibility, Should I add another level of verbosity that includes `redeemScript` in the `scriptSig`?