💬 TheCharlatan commented on pull request "Add Signet launch shortcut for Windows":
(https://github.com/bitcoin/bitcoin/pull/26334#issuecomment-1522212627)
Concept ACK

💬 michaelfolkson commented on pull request "Add Signet launch shortcut for Windows":
(https://github.com/bitcoin/bitcoin/pull/26334#issuecomment-1522312598)
Concept ACK

Perhaps the Bitcoin Design [community](https://bitcoin.design/) will have a view on the wording. I'd go with standalone "signet" but I haven't done any user research on whether this isn't sufficiently informative.

💬 john-moffett commented on pull request "util: Show descriptive error messages when FileCommit fails":
(https://github.com/bitcoin/bitcoin/pull/26654#issuecomment-1522357171)
Thanks for reminding me! Will rebase tomorrow.

📝 Empact opened a pull request: "Remove now-unnecessary poll, fcntl includes from net(base).cpp"
(https://github.com/bitcoin/bitcoin/pull/27530)
As far as I can tell, the code calling for these includes was removed in:
6e68ccbefea6509c61fc4405a391a517c6057bb0 #24356
82d360b5a88d9057b6c09b61cd69e426c7a2412d #21387

💬 kcalvinalvin commented on pull request "index: Compare deserialized block hash with the block hash from the blockindex":
(https://github.com/bitcoin/bitcoin/pull/26390#issuecomment-1522778737)
> Are you still working on this?

Is there any interest for the PR itself? It's not much but you can get additional assurance that the blockfilter stored on disk is not corrupted.

I can rebase if there's interest in that feature.

💬 brunoerg commented on pull request "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`":
(https://github.com/bitcoin/bitcoin/pull/26261#issuecomment-1523037238)
I had to touch `bench` code to fix an error CI pointed out, so I took the moment to address some suggestions from @stickies-v.

Addressed:
https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1153145784
https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1153157545
https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1153170805

💬 ajtowns commented on pull request "Relay own transactions only via short-lived Tor or I2P connections":
(https://github.com/bitcoin/bitcoin/pull/27509#issuecomment-1523087063)
Concept ACK.

Might be good to have some way of being able to configure where to connect to for sensitive relay, defaulting to tor/i2p, but so that you could perhaps enable specific ipv4/ipv6 addresses as well, particularly for testing purposes.

👍 stickies-v approved a pull request: "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`"
(https://github.com/bitcoin/bitcoin/pull/26261#pullrequestreview-1401538483)
re-ACK 4eee95e57

Verified that the only changes are a refactoring to `bench`, removing now unnecessary helper functions `ResolveIP` and `ResolveService`, and incorporating my previous outstanding review comments.

💬 stickies-v commented on pull request "p2p: cleanup `LookupIntern`, `Lookup` and `LookupHost`":
(https://github.com/bitcoin/bitcoin/pull/26261#discussion_r1177587552)
Any reason why not just reuse the already looked up service?
```suggestion
const CService service{Lookup("250.3.1.1", 8333, false).value()};
addrman.Add({CAddress(service, NODE_NONE)}, service);
```

💬 furszy commented on pull request "index: Compare deserialized block hash with the block hash from the blockindex":
(https://github.com/bitcoin/bitcoin/pull/26390#issuecomment-1523092479)
yeah @kcalvinalvin, please rebase it. Will check it asap.

💬 brunoerg commented on pull request "test: clean up logs when there aren't perf subprocesses":
(https://github.com/bitcoin/bitcoin/pull/23928#discussion_r1177611645)
Make sense, gonna address it!

💬 brunoerg commented on pull request "test: clean up logs when there aren't perf subprocesses":
(https://github.com/bitcoin/bitcoin/pull/23928#issuecomment-1523097707)
Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/23928#discussion_r1090676878. Thanks @kouloumos for the review.

💬 ajtowns commented on pull request "mempool: disallow txns under min relay fee, even in packages":
(https://github.com/bitcoin/bitcoin/pull/26933#issuecomment-1523120410)
reACK bf77fc9cb45209b9c560208c65abc94209cd7919

💬 hebasto commented on pull request "qt: 25.0rc2 translations update":
(https://github.com/bitcoin/bitcoin/pull/27517#issuecomment-1523149359)
Updated.

💬 ajtowns commented on pull request "RPC: Accept options as named-only parameters":
(https://github.com/bitcoin/bitcoin/pull/26485#issuecomment-1523170523)
ACK eaee226a17546b93245ca1435e4b468c368d9e86

Failing test looks like it was fixed in #27340 already.

🚀 glozow merged a pull request: "mempool: disallow txns under min relay fee, even in packages"
(https://github.com/bitcoin/bitcoin/pull/26933)

⚠️ ryanofsky opened an issue: "CI failure "buster-backports InRelease: The following signatures couldn't be verified because the public key is not available""
(https://github.com/bitcoin/bitcoin/issues/27531)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Not sure if this CI failure would be fixed by a rebase but the failure happens reliably in the merge_base phase of the "[no wallet, libbitcoinkernel] [focal]" the task in #26485 when the task is rerun:

https://cirrus-ci.com/task/6566074339033088

```
Reading package lists...
W: GPG error: http://deb.debian.org/debian buster-backports InRelease: The following signatures couldn't be v
...

💬 aureleoules commented on pull request "wallet: Refactor and document CoinControl":
(https://github.com/bitcoin/bitcoin/pull/26066#issuecomment-1523198262)
Rebased

💬 fanquake commented on issue "CI failure "buster-backports InRelease: The following signatures couldn't be verified because the public key is not available"":
(https://github.com/bitcoin/bitcoin/issues/27531#issuecomment-1523199075)
Think this might be part of #27492?

⚠️ karask opened an issue: "Cannot disable RBF with walletrbf configuration option"
(https://github.com/bitcoin/bitcoin/issues/27532)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

I am creating a tx using:

$ bitcoin-cli createrawtransaction '''
[{"txid":"7b6412a0eed56338731e83c606f13ebb7a3756b3e4e1dbbe43a7db8d09106e56","vout": 1}]
''' '''{"mtVHHCqCECGwiMbMoZe8ayhJHuTdDbYWdJ": 0.00004}'''
0200000001566e10098ddba743bedbe1e4b356377abb3ef106c6831e733863d5eea012647b0100000000`fdffffff`01a00f0000000000001976a9148e48a6c5108efa
...

💬 furszy commented on issue "Cannot disable RBF with walletrbf configuration option":
(https://github.com/bitcoin/bitcoin/issues/27532#issuecomment-1523257213)
`createrawtransaction` does not interact with the wallet. Use the `replaceable` arg to enable/disable RBF.
```
createrawtransaction <inputs> <outputs> <locktime> <replaceable>
```