💬 sdaftuar commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1833036997)
My thought was that we're storing `CTxMemPool::txiter` objects internally, but the `TxHandle` object could be replaced with some other wrapper if we wanted to hide the internals of the mempool further. So I'm leaving this as-is for now.

💬 bigspider commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#issuecomment-2462766759)
> `musig()` is not being parsed in Miniscript expressions yet.

Ah, ok, I'll keep an eye for updates.
Thanks!

💬 sdaftuar commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1833040860)
Updated the commit message.

💬 sdaftuar commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1833040997)
Gone.

💬 sdaftuar commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1833043139)
I cherry-picked https://github.com/0xB10C/bitcoin/commit/2eb1410e774636040d19d3baf5e22b2e4a8fbfd2, which updates the documentation and resolves the issue discussed above: https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1832803900

💬 fanquake commented on pull request "depends: Specify CMake generator explicitly":
(https://github.com/bitcoin/bitcoin/pull/31171#issuecomment-2462789506)
Guix Build:
```bash
2b8363e54965bc413159a4dbc371a70e4c8a77976c196c57747917928009ed03 guix-build-e2ba8236715e/output/aarch64-linux-gnu/SHA256SUMS.part
4b0b3358ffe8c136759ff8594e5ea4502a7b9299f3c3b271c65bc3187b832960 guix-build-e2ba8236715e/output/aarch64-linux-gnu/bitcoin-e2ba8236715e-aarch64-linux-gnu-debug.tar.gz
303f29d256c2f31909b8a6ffdbcb2c6fd974a3e188bb6726de369c8746ad4b9f guix-build-e2ba8236715e/output/aarch64-linux-gnu/bitcoin-e2ba8236715e-aarch64-linux-gnu.tar.gz
df57974010085f36
...

👍 fanquake approved a pull request: "depends: Specify CMake generator explicitly"
(https://github.com/bitcoin/bitcoin/pull/31171#pullrequestreview-2421636564)
ACK e2ba8236715ee4530d08312b075d8b41cb592257 - Going forward I think we should look at making this work without having to hard code anything.

🚀 fanquake merged a pull request: "depends: Specify CMake generator explicitly"
(https://github.com/bitcoin/bitcoin/pull/31171)

💬 fanquake commented on pull request "wallet: remove BDB dependency from wallet migration benchmark":
(https://github.com/bitcoin/bitcoin/pull/31241#issuecomment-2462816933)
https://cirrus-ci.com/task/4957802181951488?logs=ci#L1777:
```bash
[17:17:27.480] Thread T4 'b-httpworker.1' (tid=27041, running) created by main thread at:
[17:17:27.480] #0 pthread_create <null> (bitcoind+0xf7df5) (BuildId: 759dffa438a525872edb969c48b6c5c4c6341482)
[17:17:27.480] #1 std::__1::__libcpp_thread_create[abi:ne190103](unsigned long*, void* (*)(void*), void*) /usr/lib/llvm-19/bin/../include/c++/v1/__thread/support/pthread.h:182:10 (bitcoind+0x6e06fb) (BuildId: 759dffa43
...

🚀 fanquake merged a pull request: "TxDownloadManager followups"
(https://github.com/bitcoin/bitcoin/pull/31190)

💬 sdaftuar commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1833111731)
Thanks! I've included your commit (and will mark this as resolved).

👋 edilmedeiros's pull request is ready for review: "RFC: doc: Fix dead links to mailing list archives"
(https://github.com/bitcoin/bitcoin/pull/31240)

📝 achow101 opened a pull request: "descriptors: MuSig2"
(https://github.com/bitcoin/bitcoin/pull/31244)
Implements parsing of BIP 328 `musig()` descriptors.

Depends on #31243

Split from #29675

📝 achow101 opened a pull request: "wallet: Sign transactions containing MuSig2 inputs"
(https://github.com/bitcoin/bitcoin/pull/31245)
Implements all of the signing logic for transactions containing MuSig2 inputs.

Note that this is not actually usable as the session data for MuSig2 is not stored. That will require the PSBT fields from #29675

Depends on #31242, #31243, and #31244

Split from #29675

✅ achow101 closed a pull request: "wallet: Sign transactions containing MuSig2 inputs"
(https://github.com/bitcoin/bitcoin/pull/31245)

⚠️ achow101 opened an issue: "MuSig2 Tracking Issue"
(https://github.com/bitcoin/bitcoin/issues/31246)
Current PR to review: #31242

- [x] libsecp:
- [x] libsecp module: https://github.com/bitcoin-core/secp256k1/pull/1479
- [x] libsecp named structs: https://github.com/bitcoin-core/secp256k1/pull/1628
- [x] libsecp subtree update: #31216
- [ ] Refactors
- [ ] #31242
- [ ] #31243
- [ ] Descriptor: #31244
- [ ] PSBT:
- [ ] Signing: #29675

📝 achow101 opened a pull request: "psbt: MuSig2 Fields"
(https://github.com/bitcoin/bitcoin/pull/31247)
Implements un/serialization of MuSig2 PSBT fields and prepares PSBT to be able to sign for MuSig2 inputs.

Split from #29675

👋 achow101's pull request is ready for review: "psbt: MuSig2 Fields"
(https://github.com/bitcoin/bitcoin/pull/31247)

💬 furszy commented on pull request "wallet: remove BDB dependency from wallet migration benchmark":
(https://github.com/bitcoin/bitcoin/pull/31241#issuecomment-2462936240)
> https://cirrus-ci.com/task/4957802181951488?logs=ci#L1777:
>
> ```shell
> [17:17:27.480] Thread T4 'b-httpworker.1' (tid=27041, running) created by main thread at:
> [17:17:27.480] #0 pthread_create <null> (bitcoind+0xf7df5) (BuildId: 759dffa438a525872edb969c48b6c5c4c6341482)
> [17:17:27.480] #1 std::__1::__libcpp_thread_create[abi:ne190103](unsigned long*, void* (*)(void*), void*) /usr/lib/llvm-19/bin/../include/c++/v1/__thread/support/pthread.h:182:10 (bitcoind+0x6e06fb) (Bui
...

📝 achow101 converted_to_draft a pull request: "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys"
(https://github.com/bitcoin/bitcoin/pull/29675)
This PR implements MuSig2 descriptors (BIP 390), derivation (BIP 328), and PSBT fields (BIP 373) so that the wallet can receive and spend from taproot addresses that have keys involving a MuSig2 aggregate key.

The libsecp musig module is enabled so that it can be used for all of the MuSig2 cryptography.

Secnonces are handled in a separate class which holds the libsecp secnonce object in a `secure_unique_ptr`. Since secnonces must not be used, this class has no serialization and will only l
...

💬 achow101 commented on pull request "wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys":
(https://github.com/bitcoin/bitcoin/pull/29675#issuecomment-2462937879)
Several earlier commits have been split out into separate PRs. See the tracking issue #31246 for the breakdown.