💬 instagibbs commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1817172422)
```suggestion
CTxMemPool::setEntries all_conflicts;
```

💬 instagibbs commented on pull request "cluster mempool: Implement changeset interface for mempool":
(https://github.com/bitcoin/bitcoin/pull/31122#discussion_r1817177783)
ah right

📝 l0rinc converted_to_draft a pull request: "optimization: pack util::Xor into 64/32 bit chunks instead of doing it byte-by-byte"
(https://github.com/bitcoin/bitcoin/pull/31144)
The recently merged [XOR obfuscation](https://github.com/bitcoin/bitcoin/pull/28207) is a non-trivial part of serialization, encountered during IBD and `reindex`.

In this PR, I've added a new test (comparing randomized inputs against a trivial implementation), updated the benchmark to validate a [more realistic scenario](https://github.com/bitcoin/bitcoin/blob/master/src/node/mempool_persist.cpp#L180) and optimized the XOR function to do the work in batches (instead of per bytes).

```bash
...

💬 darosior commented on pull request "Drop miniupnp dependency":
(https://github.com/bitcoin/bitcoin/pull/31130#discussion_r1817230404)
Done.

💬 darosior commented on pull request "Drop miniupnp dependency":
(https://github.com/bitcoin/bitcoin/pull/31130#discussion_r1817231681)
It was both. Removed outdated comments and dead code in the latest push. I cleaned up this function in the follow-up.

📝 darosior opened a pull request: "Cleanups to port mapping module post UPnP dropt"
(https://github.com/bitcoin/bitcoin/pull/31157)
Based on #31130, this does a couple cleanups to `src/mapport.*` to clarify the logic now that there is a single protocol option for port mapping.

💬 darosior commented on pull request "Drop miniupnp dependency":
(https://github.com/bitcoin/bitcoin/pull/31130#issuecomment-2438634685)
Pushed two commits to remove outdated comments and dead code. I opened https://github.com/bitcoin/bitcoin/pull/31157 as a follow-up to clean up some of the logic which became unnecessary or confusing now that there is only a single protocol option.

🤔 BrandonOdiwuor reviewed a pull request: "init: Correct coins db cache size setting"
(https://github.com/bitcoin/bitcoin/pull/31064#pullrequestreview-2396283480)
Code Review ACK 3a4a788ee0db83d20607f14801dbed2ee932943c

📝 hebasto opened a pull request: "build, ci: Fix linking `bitcoin-chainstate.exe` to `bticoinkernel.dll` on Windows"
(https://github.com/bitcoin/bitcoin/pull/31158)
On the master branch @ 9a7206a34e3179d7280de98a818a13374178ee7b, linking `bitcoin-chainstate.exe` to `bticoinkernel.dll` fails:
```
> cmake -B build --preset vs2022-static -DBUILD_UTIL_CHAINSTATE=ON -DBUILD_KERNEL_LIB=ON -DBUILD_SHARED_LIBS=ON
> cmake --build build --config Release -j 8 -t bitcoin-chainstate
...
LINK : fatal error LNK1181: cannot open input file 'kernel\Release\bitcoinkernel.lib' [C:\Users\hebasto\source\repos\bitcoin\build-static\src\bitcoin-chainstate.vcxproj]
```

Thi
...

💬 TheCharlatan commented on pull request "build, ci: Fix linking `bitcoin-chainstate.exe` to `bitcoinkernel.dll` on Windows":
(https://github.com/bitcoin/bitcoin/pull/31158#discussion_r1817300867)
Do you want to take this opportunity to also add a better description to the test name? Maybe something like:
`Win64 native, VS 2022, no depends, libbitcoinkernel`?

💬 achow101 commented on pull request "test: Assert that when we add the max orphan amount that we cannot add anymore and that a random orphan gets dropped":
(https://github.com/bitcoin/bitcoin/pull/31040#issuecomment-2438730450)
ACK 5c299ecafe6f336cffa145d28036b04b87e26712

💬 hebasto commented on pull request "build, ci: Fix linking `bitcoin-chainstate.exe` to `bitcoinkernel.dll` on Windows":
(https://github.com/bitcoin/bitcoin/pull/31158#discussion_r1817309322)
Thanks! "libbitcoinkernel" taken; it seems awkward to mention "depends", which is a non-Windows thing, on Windows :)

💬 TheCharlatan commented on pull request "build, ci: Fix linking `bitcoin-chainstate.exe` to `bitcoinkernel.dll` on Windows":
(https://github.com/bitcoin/bitcoin/pull/31158#discussion_r1817314019)
Ah, I was thinking of mentioning it because of the macOS build, but I guess we can have native macOS and depends, so it makes sense there, but as you say, does not make sense for msvc.

🚀 achow101 merged a pull request: "test: Assert that when we add the max orphan amount that we cannot add anymore and that a random orphan gets dropped"
(https://github.com/bitcoin/bitcoin/pull/31040)

💬 tdb3 commented on pull request "rpc: getorphantxs follow-up":
(https://github.com/bitcoin/bitcoin/pull/31043#issuecomment-2438925036)
Pushed to 38c2ef250817351919eebfbea29549c4f68efac1
- Renamed expiration variable to ORPHAN_TX_EXPIRE_TIME
- getorphantxs now rejects undefined verbosity (<0 and >2), and disallows boolean verbosity through an updated `ParseVerbosity()`.

💬 tdb3 commented on pull request "rpc: getorphantxs follow-up":
(https://github.com/bitcoin/bitcoin/pull/31043#discussion_r1817400739)
fixed

👋 tdb3's pull request is ready for review: "test: enhance p2p_orphan_handling"
(https://github.com/bitcoin/bitcoin/pull/31037)

💬 kevkevinpal commented on pull request "test: added test to assert TX decode rpc error on submitpackage rpc":
(https://github.com/bitcoin/bitcoin/pull/31139#discussion_r1817630156)
I removed them in [1fab1d6](https://github.com/bitcoin/bitcoin/pull/31139/commits/1fab1d601e40edc7296cf3d60a7e917b0e6493b3)

💬 kevkevinpal commented on pull request "test: added test to assert TX decode rpc error on submitpackage rpc":
(https://github.com/bitcoin/bitcoin/pull/31139#discussion_r1817631565)
ok I added an assert to check for `txid` in `getrawmempool` in [1fab1d6](https://github.com/bitcoin/bitcoin/pull/31139/commits/1fab1d601e40edc7296cf3d60a7e917b0e6493b3)

let me know if that looks good to you!

👍 hodlinator approved a pull request: "tinyformat: enforce compile-time checks for format string literals"
(https://github.com/bitcoin/bitcoin/pull/31149#pullrequestreview-2397082398)
re-ACK 23560b468c474bbc6a3abd6c0778da62766ac8f7

Changes since [previous ACK](https://github.com/bitcoin/bitcoin/pull/31149#pullrequestreview-2393618400):
- Added file-local `fuzz_fmt` function to reduce churn.
- Rebased and applied conversions to new code from #29936.

👍 rkrux approved a pull request: "test: added test to assert TX decode rpc error on submitpackage rpc"
(https://github.com/bitcoin/bitcoin/pull/31139#pullrequestreview-2397147428)
ACK 1fab1d601e40edc7296cf3d60a7e917b0e6493b3

Thanks for incorporating the changes.