💬 Sjors commented on issue "macOS 15.0.1 can't build Qt (Intel, without Xcode)":
(https://github.com/bitcoin/bitcoin/issues/31054#issuecomment-2427030422)
Going to close this for now, since you can't reproduce on Intel.

💬 Sjors commented on pull request "net, net_processing: additional and consistent disconnect logging":
(https://github.com/bitcoin/bitcoin/pull/28521#issuecomment-2427035858)
Seems like I need to look into and probably fix at least https://github.com/bitcoin/bitcoin/pull/28521#discussion_r1791784114

Will look into the other comments too.

💬 Christewart commented on pull request "test: Assert that when we add the max orphan amount that we cannot add anymore and that a random orphan gets dropped":
(https://github.com/bitcoin/bitcoin/pull/31040#issuecomment-2427058842)
> I'm a bit confused to the behavior i'm observing on this PR. Not necessarily anything to do with the test, but how orphans are handled.
>
> I tried adding another part to the test case to check we can clear the orphanage by propagating parent transactions: [Christewart@04815c4](https://github.com/Christewart/bitcoin/commit/04815c463d331f674f67fdcb3b8da601484d7a33)
>
> It appears that to _totally_ clear the orphanage, we need to propagate the parent transaction for the last child transact
...

💬 cdecker commented on pull request "chainparams: Re-add seed.bitcoinstats.com":
(https://github.com/bitcoin/bitcoin/pull/31086#issuecomment-2427073328)
Oh, that's a good data point. Seems the result is larger than your ISP is willing to forward. Would you like me to return fewer results?

💬 Sjors commented on issue "macOS 13.7 depends build can't find qt":
(https://github.com/bitcoin/bitcoin/issues/31050#issuecomment-2427112271)
Tried https://github.com/bitcoin/bitcoin/commit/aba02f0c06fdcf28fe76de4cf00dc73c3aee6208 with `make NO_WALLET=1 NO_UPNP=1 NO_ZMQ=1 NO_BDB=1` so save some build time:

```
...
copying packages: boost libevent qt qrencode
to: /Volumes/SSD/Dev/bitcoin/depends/x86_64-apple-darwin22.6.0
To build Bitcoin Core with these packages, pass '--toolchain /Volumes/SSD/Dev/bitcoin/depends/x86_64-apple-darwin22.6.0/toolchain.cmake' to the first CMake invocation.
sjors@Sjorss-iMac depends % cd ..
sjors@
...

💬 stickies-v commented on pull request "Package validation: accept packages of size 1":
(https://github.com/bitcoin/bitcoin/pull/31096#discussion_r1809122657)
> You _must_ include unconfirmed parents, if any exist.

Thanks, you're right. I was confused by the `IsChildWithParents` documentation stating:

> ...not all parents need to be present...

But that is of course just an incomplete, context-free check. The `MemPoolAccept::AcceptPackage` documentation and implementation indeed require all unconfirmed parents to be included. Your [suggestion](https://github.com/bitcoin/bitcoin/compare/72872c7073e99da0828e788b25520dcecf721c1b..92ed1bd586f7048f
...

💬 instagibbs commented on pull request "Package validation: accept packages of size 1":
(https://github.com/bitcoin/bitcoin/pull/31096#discussion_r1809129112)
can do when touched again

🤔 hebasto reviewed a pull request: "guix: Enable CET for `glibc` package"
(https://github.com/bitcoin/bitcoin/pull/31121#pullrequestreview-2382645014)
My Guix build:
```
aarch64
f661515f39c1fef7b7ab7e1de3665ccf3efba9ffbcc6c4de396962e9c6b1a92e guix-build-4d3da08d1b9d/output/aarch64-linux-gnu/SHA256SUMS.part
f4889a72693e3249ac5d59b83c23ddb74f15d9e844c131ae41e17fd5daa15772 guix-build-4d3da08d1b9d/output/aarch64-linux-gnu/bitcoin-4d3da08d1b9d-aarch64-linux-gnu-debug.tar.gz
68dc8bb68f0682047357d292ee71e7b654e3aa1431f50a1ae9ef459f51318663 guix-build-4d3da08d1b9d/output/aarch64-linux-gnu/bitcoin-4d3da08d1b9d-aarch64-linux-gnu.tar.gz
9ad44c30
...

🤔 hebasto reviewed a pull request: "guix: Enable CET for `glibc` package"
(https://github.com/bitcoin/bitcoin/pull/31121#pullrequestreview-2382646552)
Post-merge ACK 4d3da08d1b9d07acb43420899e0d16fad2437fb0.

💬 murchandamus commented on issue "Testnet4 consensus failure due to timewarp related "softfork"":
(https://github.com/bitcoin/bitcoin/issues/30786#issuecomment-2427179070)
@wiz, @russeree: Are you still mining on Testnet4?

📝 fanquake opened a pull request: "depends: add *FLAGS to gen_id"
(https://github.com/bitcoin/bitcoin/pull/31125)
The depends cache should be busted when flags change, the same as any other tooling change. I'd also like to start passing `*FLAGS` into depends inside the Guix env, which, without this change, doesn't bust the cache.

💬 laanwj commented on pull request "chainparams: Re-add seed.bitcoinstats.com":
(https://github.com/bitcoin/bitcoin/pull/31086#issuecomment-2427316230)
> Oh, that's a good data point. Seems the result is larger than your ISP is willing to forward. Would you like me to return fewer results?

The number of results (24-25) is not that different from the other DNS seeds. i don't think the problem is with that.

i tried specifying the ISP's DNS server IP directly with `dig` and this worked, and suddenly it's just working also without. Maybe it's just something dumb with the local configuration. Let's wait if other people stumble on problems fir
...

💬 murchandamus commented on pull request "miner: Reorg Testnet4 minimum difficulty blocks":
(https://github.com/bitcoin/bitcoin/pull/31117#issuecomment-2427321347)
In addition to the immediate minimum difficulty blocks after each full difficulty block, someone appears to have started bloating the UTXO set. They have created about 1.5 M UTXOs today so far: https://mempool.space/testnet4/address/tb1q8z0jcrdmfuhyafz06ukhyvfnx4vhcn5azv6jkr

💬 instagibbs commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809231705)
@sdaftuar this should do it if you think something like this is reasonable: https://github.com/instagibbs/bitcoin/commit/6007146613fe663f0af30c24c47a19792f8e691d

💬 murchandamus commented on issue "Improve description of the `filename` parameter of `loadwallet` RPC":
(https://github.com/bitcoin/bitcoin/issues/30269#issuecomment-2427364404)
@paulmaleauxney: It looks like #30302 is getting pretty close to being merged

💬 murchandamus commented on pull request "Fee Estimation via Fee rate Forecasters":
(https://github.com/bitcoin/bitcoin/pull/30157#issuecomment-2427370927)
Concept ACK! Thank you for working on this.

🤔 murchandamus reviewed a pull request: "Remove mempoolfullrbf"
(https://github.com/bitcoin/bitcoin/pull/30592#pullrequestreview-2382949737)
Concept ACK

💬 murchandamus commented on pull request "Remove mempoolfullrbf":
(https://github.com/bitcoin/bitcoin/pull/30592#discussion_r1809262175)
This comment is outdated

👍 laanwj approved a pull request: "wallet: Cleanup accidental encryption keys in watchonly wallets"
(https://github.com/bitcoin/bitcoin/pull/28724#pullrequestreview-2382986480)
Code review re-ACK 69e95c2b4f99eb4c2af6b2b6cc6a66abfea753df

🤔 murchandamus reviewed a pull request: "Ephemeral Dust"
(https://github.com/bitcoin/bitcoin/pull/30239#pullrequestreview-2382979168)
Concept ACK

💬 murchandamus commented on pull request "Ephemeral Dust":
(https://github.com/bitcoin/bitcoin/pull/30239#discussion_r1809271898)
It seems to me that this would apply to any transaction with a dust output rather than just one that fulfills the criteria of "ephemeral dust".

```suggestion
throw JSONRPCError(RPC_INVALID_PARAMETER, "Priority is not supported for transactions with dust outputs.");
```