💬 hebasto commented on pull request "guix: Enable CET for `glibc` package":
(https://github.com/bitcoin/bitcoin/pull/31121#issuecomment-2426705250)
Concept ACK.

👍 instagibbs approved a pull request: "validation: Improve input script check error reporting"
(https://github.com/bitcoin/bitcoin/pull/31097#pullrequestreview-2382078763)
ACK 86e2a6b749c7fecbd086b361806ac9f6e9426d79

played with tests to ensure the test was failing how I'd expect it with modifications

💬 instagibbs commented on pull request "validation: Improve input script check error reporting":
(https://github.com/bitcoin/bitcoin/pull/31097#discussion_r1808805047)
nit: Agreed, this would help readability.

💬 hodlinator commented on pull request "util: Remove RandAddSeedPerfmon":
(https://github.com/bitcoin/bitcoin/pull/31124#issuecomment-2426731716)
Updated 2 more comments along the lines of https://github.com/bitcoin/bitcoin/pull/31124#discussion_r1808780747 in latest push.

👍 TheCharlatan approved a pull request: "Add Signet and testnet4 launch shortcuts for Windows"
(https://github.com/bitcoin/bitcoin/pull/26334#pullrequestreview-2382176682)
ACK cfd03de965a081facbd72316c76603dd7aa511bd

💬 fanquake commented on pull request "validation: Improve input script check error reporting":
(https://github.com/bitcoin/bitcoin/pull/31097#discussion_r1808866610)
@sipa might be able to pull this into #31112, given it's following up.

💬 brunoerg commented on pull request "rpc: net: follow-ups for #30062":
(https://github.com/bitcoin/bitcoin/pull/30183#issuecomment-2426745024)
Force-pushed addressing https://github.com/bitcoin/bitcoin/pull/30183#discussion_r1803064149

💬 sipa commented on pull request "validation: Improve input script check error reporting":
(https://github.com/bitcoin/bitcoin/pull/31097#discussion_r1808874526)
My follow-up PR removes `CScriptCheck::GetScriptError`, so this modification isn't really applicable anymore.

💬 hebasto commented on pull request "doc: replace `-?` with `-h` and `-help`":
(https://github.com/bitcoin/bitcoin/pull/31118#issuecomment-2426756072)
Concept ACK.

💬 instagibbs commented on pull request "Package validation: accept packages of size 1":
(https://github.com/bitcoin/bitcoin/pull/31096#discussion_r1808875653)
took a slightly different tack, I think this is more correct. You *must* include unconfirmed parents, if any exist.

💬 instagibbs commented on pull request "Package validation: accept packages of size 1":
(https://github.com/bitcoin/bitcoin/pull/31096#discussion_r1808875791)
sure done

💬 instagibbs commented on pull request "Package validation: accept packages of size 1":
(https://github.com/bitcoin/bitcoin/pull/31096#discussion_r1808875865)
done

💬 instagibbs commented on pull request "Package validation: accept packages of size 1":
(https://github.com/bitcoin/bitcoin/pull/31096#issuecomment-2426763408)
@glozow we may want to consider relaxing `package-not-child-with-unconfirmed-parents` to allow people to submit just the cpfp alone? Should be done in a separate PR regardless.

🚀 fanquake merged a pull request: "validation: Improve input script check error reporting"
(https://github.com/bitcoin/bitcoin/pull/31097)

💬 TheCharlatan commented on pull request "[refactor] Cleanup BlockAssembler mempool usage":
(https://github.com/bitcoin/bitcoin/pull/28843#issuecomment-2426769421)
Updated 60a0f2ac88c57fdf4482dade2ce409ef2da65998 -> 192dac1d3370edd579db235d69c034726f37c8da ([blockAssemblerRemoveMempool_2](https://github.com/TheCharlatan/bitcoin/tree/blockAssemblerRemoveMempool_2) -> [blockAssemblerRemoveMempool_3](https://github.com/TheCharlatan/bitcoin/tree/blockAssemblerRemoveMempool_3), [compare](https://github.com/TheCharlatan/bitcoin/compare/blockAssemblerRemoveMempool_2..blockAssemblerRemoveMempool_3))

* Added @stickies-v's [patch](https://github.com/bitcoin/bitco
...

🚀 fanquake merged a pull request: "guix: Enable CET for `glibc` package"
(https://github.com/bitcoin/bitcoin/pull/31121)

🚀 fanquake merged a pull request: "Add Signet and testnet4 launch shortcuts for Windows"
(https://github.com/bitcoin/bitcoin/pull/26334)

💬 instagibbs commented on pull request "rpc: Add support to populate PSBT input utxos via rpc":
(https://github.com/bitcoin/bitcoin/pull/30886#discussion_r1808887976)
lots of ways things can go wrong, unsure what would be good to report personally

🤔 danielabrozzoni reviewed a pull request: "validation: Improve input script check error reporting"
(https://github.com/bitcoin/bitcoin/pull/31097#pullrequestreview-2382244315)
post merge tACK 86e2a6b749c7fecbd086b361806ac9f6e9426d79

💬 sipa commented on pull request "Improve parallel script validation error debug logging":
(https://github.com/bitcoin/bitcoin/pull/31112#issuecomment-2426831357)
Rebased after the merge of #31097.

💬 davidgumberg commented on pull request "coins: Add move operations to Coin and CCoinsCacheEntry":
(https://github.com/bitcoin/bitcoin/pull/30643#discussion_r1808928993)
Is the reason that all of these default constructors can be declared noexcept that all of `Coin`'s members' respective default constructors that get invoked are noexcept?