💬 tdb3 commented on pull request "rpc: add getorphantxs":
(https://github.com/bitcoin/bitcoin/pull/30793#issuecomment-2327705761)
Updated to include an experimental warning and make the RPC hidden.
Also added a convenience function for checking the orphanage in tests.

💬 wiz commented on issue "Testnet4 consensus failure due to timewarp related "softfork"":
(https://github.com/bitcoin/bitcoin/issues/30786#issuecomment-2327715298)
ok will do

💬 hashbender commented on issue "Testnet4 consensus failure due to timewarp related "softfork"":
(https://github.com/bitcoin/bitcoin/issues/30786#issuecomment-2327719259)
Here's my last chain tip in case you want to verify the correct chain. This is from `Bitcoin Core version v28.0rc1`

```
hashbender@macbook-pro-124: bitcoin-cli -testnet4 getchaintips
[
{
"height": 42375,
"hash": "00000000000000306de15dd9ee1e6af0461e5bdef12d6dc6be212ca7f5296fa1",
"branchlen": 0,
"status": "active"
}
]
```

💬 tdb3 commented on pull request "Feature: Use different datadirs for different signets":
(https://github.com/bitcoin/bitcoin/pull/29838#issuecomment-2327729423)
This is a great feature. Looks like the CI logs might be gone? Maybe this CI could be nudged to run again. Not sure if this CI failure is related to the one seen a few months ago related to macOS.

💬 russeree commented on issue "Testnet4 consensus failure due to timewarp related "softfork"":
(https://github.com/bitcoin/bitcoin/issues/30786#issuecomment-2327729867)
> Here's my last chain tip in case you want to verify the correct chain. This is from `Bitcoin Core version v28.0rc1`
>
> ```
> hashbender@macbook-pro-124: bitcoin-cli -testnet4 getchaintips
> [
> {
> "height": 42375,
> "hash": "00000000000000306de15dd9ee1e6af0461e5bdef12d6dc6be212ca7f5296fa1",
> "branchlen": 0,
> "status": "active"
> }
> ]
> ```

Got 500TH/s pointed toward T4 UASF

💬 luke-jr commented on pull request "Show transactions as not fully confirmed during background validation":
(https://github.com/bitcoin/bitcoin/pull/28616#discussion_r1742909675)
For example, an attacker might give a lot of people a UTXO set with one additional entry, controlled by his key. Then, he can at any point later send that UTXO to anyone who used his modified UTXO set.

💬 hebasto commented on pull request "build: Minor build system fixes and amendments":
(https://github.com/bitcoin/bitcoin/pull/30803#discussion_r1742912171)
Thanks! Done.

💬 kevkevinpal commented on pull request "[tests] New fuzz target wallet_rpc":
(https://github.com/bitcoin/bitcoin/pull/30570#discussion_r1742922167)
Thanks!

Updated in [2c8cb2b](https://github.com/bitcoin/bitcoin/pull/30570/commits/2c8cb2b7cf9b6aa60562feb6aad2c6d071ee184b)

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1742927650)
> nit in [a2317e2](https://github.com/bitcoin/bitcoin/commit/a2317e27b7fb86df4e32cd1674c06e09cb808248): Maybe add a comment that this can be removed after `cmake_minimum_required(VERSION 3.25)`?

It seems redundant to me. Since policies are tied to specific versions, it's generally understood that one should review every `if(CMAKE_VERSION...)` and `if(POLICY...)` statement in the code when updating the minimum required version.

> Alternatively, given that "The default installation of the l
...

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1742931121)
I'd rather not include Wine installation instructions in this build doc. It is not a trivial process and could create an additional maintenance burden in the future.

> it wasn't present previously with autotools.

Let's just remove it.

⚠️ hebasto opened an issue: "guix: Build fails for `x86_64-apple-darwin`"
(https://github.com/bitcoin/bitcoin/issues/30810)
### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current behaviour

Guix build for `x86_64-apple-darwin` fails.

### Expected behaviour

The build succeeds.

### Steps to reproduce

```
$ git checkout 94c307b3c0746a08c6135ff38d6f1ad1ed6693bb
$ env SDK_PATH=/home/hebasto HOSTS=x86_64-apple-darwin ./contrib/guix/guix-build
```

### Relevant log output

```
$ env SDK_PATH=/home/hebasto HOSTS=x86_64-apple-darwin ./contrib/guix/guix-build
Found macOS SDK a
...

💬 hebasto commented on pull request "build: Fix / improve coverage scripts":
(https://github.com/bitcoin/bitcoin/pull/30772#discussion_r1742980659)
You mean for the `lcov` command?

💬 romanz commented on pull request "http: set TCP_NODELAY when creating HTTP server":
(https://github.com/bitcoin/bitcoin/pull/30675#issuecomment-2327863260)
Many thanks!

💬 romanz commented on pull request "http: set TCP_NODELAY when creating HTTP server":
(https://github.com/bitcoin/bitcoin/pull/30675#issuecomment-2327863312)
Many thanks!

💬 davidgumberg commented on pull request "test: remove unused src_dir param from run_tests after CMake migration":
(https://github.com/bitcoin/bitcoin/pull/30733#issuecomment-2327921561)
ACK https://github.com/bitcoin/bitcoin/commit/76a28306f1e2c0828590eded0bf6b178f6b889da

💬 maflcko commented on pull request "build: Fix / improve coverage scripts":
(https://github.com/bitcoin/bitcoin/pull/30772#discussion_r1743085660)
I mean in the test_runner command

💬 maflcko commented on issue "guix: Build fails for `x86_64-apple-darwin`":
(https://github.com/bitcoin/bitcoin/issues/30810#issuecomment-2327944439)
Has this ever worked on your system? `guix shell: error` sounds like it is an error unrelated to Bitcoin Core?

Can you use guix and guix shell normally?

💬 maflcko commented on pull request "build: Minor build system fixes and amendments":
(https://github.com/bitcoin/bitcoin/pull/30803#issuecomment-2327952563)
review ACK dee36a6746f18a3db748ef7bf52bfebddb546307

CI output:

* Before: https://cirrus-ci.com/task/6415951824945152?logs=ci#L1057

```
C++ compiler flags .................... -Wno-error=documentation -O0 -ftrapv -O1 -g3 -g3 -std=c++20 -fPIC -fdebug-prefix-map=/ci_container_base=. -fmacro-prefix-map=/ci_container_base=. -Werror -Wall -Wextra -Wgnu -Wformat -Wformat-security -Wvla -Wshadow-field -Wthread-safety -Wloop-analysis -Wredundant-decls -Wunused-member-function -Wdate-time -Wcond
...

💬 hebasto commented on pull request "build: Fix / improve coverage scripts":
(https://github.com/bitcoin/bitcoin/pull/30772#discussion_r1743093952)
Thanks! Added.

💬 jadijadi commented on pull request "test: fixing failing system_tests/run_command under some Locales":
(https://github.com/bitcoin/bitcoin/pull/30788#issuecomment-2327990907)
> review ACK [8289373](https://github.com/bitcoin/bitcoin/commit/8289373ebf089d0719a8edecb8bfbd52c244f4ee)
>
> Please adjust the pull request description, now that the approach has changed: [#30788 (comment)](https://github.com/bitcoin/bitcoin/pull/30788#issue-2500949706)

Done. The PR description (https://github.com/bitcoin/bitcoin/pull/30788#issue-2500949706) is updated to reflect the changes in the commit message.

💬 maflcko commented on pull request "test: fixing failing system_tests/run_command under some Locales":
(https://github.com/bitcoin/bitcoin/pull/30788#issuecomment-2327996238)
Please update the pull request description properly. There is no need to include incorrect stuff (`echo success` isn't translated), or outdated stuff of a previous commit. Please focus on the important and correct details only.