💬 sstone commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#discussion_r1726456027)
done in https://github.com/bitcoin/bitcoin/pull/24539/commits/20b259332ff1d2e6ca6b291ffeda00b51497bbed

💬 sstone commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#discussion_r1726456158)
done in https://github.com/bitcoin/bitcoin/pull/24539/commits/20b259332ff1d2e6ca6b291ffeda00b51497bbed

💬 sstone commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#discussion_r1726456332)
done in https://github.com/bitcoin/bitcoin/pull/24539/commits/20b259332ff1d2e6ca6b291ffeda00b51497bbed

💬 sstone commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#discussion_r1726456688)
done in https://github.com/bitcoin/bitcoin/pull/24539/commits/20b259332ff1d2e6ca6b291ffeda00b51497bbed

💬 sstone commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#discussion_r1726457244)
done in https://github.com/bitcoin/bitcoin/pull/24539/commits/20b259332ff1d2e6ca6b291ffeda00b51497bbed

💬 sstone commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#discussion_r1726457390)
done in https://github.com/bitcoin/bitcoin/pull/24539/commits/20b259332ff1d2e6ca6b291ffeda00b51497bbed

💬 sstone commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#discussion_r1726459734)
done in https://github.com/bitcoin/bitcoin/pull/24539/commits/20b259332ff1d2e6ca6b291ffeda00b51497bbed

💬 sstone commented on pull request "Add a "tx output spender" index":
(https://github.com/bitcoin/bitcoin/pull/24539#discussion_r1726460114)
done in https://github.com/bitcoin/bitcoin/pull/24539/commits/20b259332ff1d2e6ca6b291ffeda00b51497bbed

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1725185420)
woops, fixed now

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1724970034)
done

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1725375345)
added tests for orphans with rejected parents

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1724970656)
done

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1725358054)
It makes them potentially larger transactions?

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1725187075)
> womp womp

Can you be a bit more specific :joy:

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1725359052)
done

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1725360295)
I thought they were all positive?

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1725361680)
added

💬 glozow commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1725374135)
should it? seems more complete if it handles all types, and we test them

💬 maflcko commented on issue "LevelDB read failure: Corruption: block checksum mismatch":
(https://github.com/bitcoin/bitcoin/issues/30159#issuecomment-2303933899)
> The very first machine I set up on AWS refused ssh access and had to be rebooted (fine so far after a reboot). Maybe all of this is just AWS hardware failures?

Another machine (or the same?) dropped dead, without SSH access anymore.



🤔 hodlinator reviewed a pull request: "test: [refactor] Use m_rng directly"
(https://github.com/bitcoin/bitcoin/pull/30571#pullrequestreview-2253654936)
Reviewed 38b03bc3af9fbf483b5a29a54a5ffb36c67b6b41 (still aiming to do some more testing).

> Thanks for checking the includes in the tests @hodlinator! I think I'll leave this as-is for now, because having leftover unused includes in tests should be harmless, apart from possibly being confusing, or needing more compile time. I have a follow-up to use iwyu (and enforce it), so that reviewers can use the re-review cycles to clean up includes for reviewing the code itself. However, this will be a
...

💬 hodlinator commented on pull request "test: [refactor] Use m_rng directly":
(https://github.com/bitcoin/bitcoin/pull/30571#discussion_r1726462944)
Could make `rand_seed` `const` to clarify usage (approved by clang-format-diff.py):
```diff
--- a/src/test/prevector_tests.cpp
+++ b/src/test/prevector_tests.cpp
@@ -27,7 +27,7 @@ class prevector_tester {

typedef typename pretype::size_type Size;
bool passed = true;
- uint256 rand_seed;
+ const uint256 rand_seed;


template <typename A, typename B>
@@ -207,8 +207,8 @@ public:
BOOST_CHECK_MESSAGE(passed, "insecure_rand: " + rand_seed.ToString());

...