💬 theStack commented on pull request "refactor: TxDownloadManager + fuzzing":
(https://github.com/bitcoin/bitcoin/pull/30110#discussion_r1715600184)
slightly-more-modern-nit (here and in `TxDownloadImpl::DisconnectedPeer` below):
```suggestion
if (m_peer_info.contains(nodeid)) return;
```

💬 Sjors commented on pull request "multiprocess: Add IPC wrapper for Mining interface":
(https://github.com/bitcoin/bitcoin/pull/30510#issuecomment-2286816238)
I rebased https://github.com/Sjors/bitcoin/pull/48 to take this PR and https://github.com/bitcoin/bitcoin/pull/30509 into account. Already looked at few commits, but got distracted by a bug on my end, so will continue later.

🤔 mzumsande reviewed a pull request: "validation: assumeutxo params mainnet"
(https://github.com/bitcoin/bitcoin/pull/28553#pullrequestreview-2236239890)
tested ACK 1610643c8b37a9f674b236cfa79abf8f8aaf1410

I re-created the snapshot at height 840k and verified that the file identical to the one I downloaded from the torrent.
I also successfully loaded the snapshot into a new node (though I didn't complete the sync).

💬 TheBlueMatt commented on pull request "Move maximum timewarp attack threshold back to 600s from 7200s":
(https://github.com/bitcoin/bitcoin/pull/30647#issuecomment-2286856946)
> Update the BIP first?

The BIP was originally 600, and then was updated to follow the code, so I figured I'd do the same :)

> I'm confused why is this touching ancient stuff related to every net?

Cause I was distracted and just blindly tracing constants back without thinking :sweat_smile:

💬 vasild commented on pull request "log: expand BCLog::LogFlags (categories) to 64 bits":
(https://github.com/bitcoin/bitcoin/pull/26619#issuecomment-2286883042)
Maybe `0b00000000'00000000'00000000'00001000` is a bit less horrific ;) The current is ok, no need to change it further.

📝 justinvforvendetta opened a pull request: "remove repetitive wording"
(https://github.com/bitcoin/bitcoin/pull/30649)
fixes some grammar

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or
...

💬 Sjors commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2286925458)
Fixed noise encryption regression, see https://github.com/bitcoin/bitcoin/pull/29346#issuecomment-2286722016

The current commit is tagged [sv2-tp-0.1.7](https://github.com/Sjors/bitcoin/releases/tag/sv2-tp-0.1.7), binaries coming soon.

✅ justinvforvendetta closed a pull request: "remove repetitive wording"
(https://github.com/bitcoin/bitcoin/pull/30649)

📝 justinvforvendetta opened a pull request: "removes repeated words, fix grammar"
(https://github.com/bitcoin/bitcoin/pull/30650)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 mzumsande commented on issue "Intermittent failures in interface_usdt_mempool.py":
(https://github.com/bitcoin/bitcoin/issues/27380#issuecomment-2286970765)
This is still really confusing to me.

I don't understand tracepoints in depth, but it looks like there is a race between bicoind continuing to run (and overwriting data after it goes out of scope), and the data-collecting program (bpftrace) reading data from the memory location the `c_str()` result points to. But if that was the case, it would be a very general problem with tracepoints, and I don't see how it would specifically lead to failures in this exact situation with the `mempool-rejec
...

✅ justinvforvendetta closed a pull request: "removes repeated words, fix grammar"
(https://github.com/bitcoin/bitcoin/pull/30650)

📝 fanquake locked a pull request: "remove repetitive wording"
(https://github.com/bitcoin/bitcoin/pull/30649)
fixes some grammar

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or
...

🤔 furszy reviewed a pull request: "Migrate legacy wallets that are not loaded"
(https://github.com/bitcoin-core/gui/pull/824#pullrequestreview-2236408618)
ACK 0240454120a88915396b0eb68d9b5bee73e52fed

💬 TheCharlatan commented on pull request "kernel: Introduce initial C header API":
(https://github.com/bitcoin/bitcoin/pull/30595#issuecomment-2286994610)
> I guess another thing I'd like to know is if this is the initial C API, and the implementation is around 3000 lines, and it doesn't handle "transactions, block headers, coins cache, utxo set, meta data, and the mempool", how much bigger do you think it will get if it does cover most of the things you would like it to cover? Like is this 20%, 30%, or 50% of the expected size?

I think a fair comparison would be comparing the amount of code "glue" required, e.g. the size of the `bitcoinkernel.
...

📝 justinvforvendetta opened a pull request: "remove repeated word in note"
(https://github.com/bitcoin/bitcoin/pull/30651)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

📝 fanquake locked a pull request: "removes repeated words, fix grammar"
(https://github.com/bitcoin/bitcoin/pull/30650)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 LarryRuane commented on pull request "log: expand BCLog::LogFlags (categories) to 64 bits":
(https://github.com/bitcoin/bitcoin/pull/26619#issuecomment-2287023896)
> I think would just write `CategoryMask{1}` everywhere instead of having a separate constant

I like that suggestion, I just force-pushed it, thanks!

📝 fjahr opened a pull request: "rpc: Set best header in reconsiderblock"
(https://github.com/bitcoin/bitcoin/pull/30652)
The `reconsiderblock` RPC resets the blocks flags and then calls `ActivateBestChain()`. But this doesn't set `m_best_header` which leaves us in an inconsistent state until something else triggers a change, like connecting a new block. But, until then, `getblockchaininfo`, for example, reports having less headers than blocks.

I found this while working on a more extensive tests for #29553.

💬 fanquake commented on pull request "rpc: Set best header in reconsiderblock":
(https://github.com/bitcoin/bitcoin/pull/30652#issuecomment-2287062693)
See also #26245.

💬 mzumsande commented on pull request "rpc: Set best header in reconsiderblock":
(https://github.com/bitcoin/bitcoin/pull/30652#issuecomment-2287068247)
It's a duplicate of #29913 (but see also my last comment there why the problem is harder than it seems)

👍 stickies-v approved a pull request: "Update translation source file for v28.0 string freeze"
(https://github.com/bitcoin-core/gui/pull/833#pullrequestreview-2236511012)
ACK 9edd8f300ca27cfabc310cbe015dc14160d24f1a