💬 ismaelsadeeq commented on pull request "BlockAssembler: return selected packages vsize and feerate":
(https://github.com/bitcoin/bitcoin/pull/30391#discussion_r1713369779)
That makes sense. I removed `findFeeRate` and explicitly checked the vector for the packages and verify the fee and size were as expected. I also took the opportunity to change the variables to be initialized uniformly.

👍 willcl-ark approved a pull request: "chainparams: Handle Testnet4 in GetNetworkForMagic"
(https://github.com/bitcoin/bitcoin/pull/30625#pullrequestreview-2232381658)
crACK b0ec8716bf27335686471e0ae4c6a34f9a08f33c

🚀 fanquake merged a pull request: "doc: Remove outdated nTx faking comment"
(https://github.com/bitcoin/bitcoin/pull/30624)

🚀 fanquake merged a pull request: "doc: rpc: Use "output script" consistently (2/2)"
(https://github.com/bitcoin/bitcoin/pull/30524)

💬 fanquake commented on pull request "Fixes for GCC 15 compatibility":
(https://github.com/bitcoin/bitcoin/pull/30612#discussion_r1713492439)
> You all can do whatever you want with my suggested fixes.

Thanks. We don't edit commits during merges, so I'll cherry-pick and fixup any nits in a new PR.

📝 fanquake opened a pull request: "Fixes for GCC 15 compatibility"
(https://github.com/bitcoin/bitcoin/pull/30633)
#30612 with changes made.

GCC 15 introduces three build failures:

* Two are related to missing includes. You can't use `uint16_t` et al. without including `<cstdint>`.

* The third is harder to understand but easy to fix. GCC changed something about the way templates are instantiated when checking type constraints, and now there is a dependency loop while checking `std::optional<CFeeRate>`. This manifests as the following compile-time mess:
```
In file included from /usr/lib/gc
...

✅ fanquake closed a pull request: "Fixes for GCC 15 compatibility"
(https://github.com/bitcoin/bitcoin/pull/30612)

💬 fanquake commented on pull request "Fixes for GCC 15 compatibility":
(https://github.com/bitcoin/bitcoin/pull/30612#issuecomment-2283597717)
See #30633.

💬 fanquake commented on pull request "Fixes for GCC 15 compatibility":
(https://github.com/bitcoin/bitcoin/pull/30612#discussion_r1713494639)
Done in #30633.

🚀 fanquake merged a pull request: "lint: Find function calls in default arguments"
(https://github.com/bitcoin/bitcoin/pull/30553)

🚀 fanquake merged a pull request: "doc: Drop no longer needed workaround for WSL"
(https://github.com/bitcoin/bitcoin/pull/30597)

🚀 fanquake merged a pull request: "chainparams: Handle Testnet4 in GetNetworkForMagic"
(https://github.com/bitcoin/bitcoin/pull/30625)

💬 fanquake commented on pull request "ci: Silent Homebrew's reinstall warnings":
(https://github.com/bitcoin/bitcoin/pull/30591#discussion_r1713500252)
Are these Qt workarounds still needed? Would be good if we could drop them, rather than adding more code to suppress warnings coming from workarounds that may no-longer be needed.

🤔 vasild reviewed a pull request: "log: expand BCLog::LogFlags (categories) to 64 bits"
(https://github.com/bitcoin/bitcoin/pull/26619#pullrequestreview-2232592770)
ACK 90c3d904bcbf294a6fcef8bc9ecb9445fd41c4bd

This probably needs a rebase. It is a trivial change.

10 new categories were added in the last 7 years. That is 1-2 per year. 32 extra should suffice for a few decades.

🚀 fanquake merged a pull request: "ci: Silent Homebrew's reinstall warnings"
(https://github.com/bitcoin/bitcoin/pull/30591)

👍 fanquake approved a pull request: "Revert "depends: Fetch miniupnpc sources from an alternative website""
(https://github.com/bitcoin/bitcoin/pull/30603#pullrequestreview-2232604323)
ACK 4c2cc63d84dc1c8bae1b620f34188b7c20b70019 - please don't @ mention anyone in your pull request descriptions, otherwise they are likely to just get spammed with notifications.

🚀 fanquake merged a pull request: "Revert "depends: Fetch miniupnpc sources from an alternative website""
(https://github.com/bitcoin/bitcoin/pull/30603)

📝 maflcko opened a pull request: "ci: Use clang-19 from apt.llvm.org"
(https://github.com/bitcoin/bitcoin/pull/30634)
A new clang version generally comes with bugfixes, new sanitizer features, as well as new features.

Upgrade the sanitizer tasks to use the new version.

A follow-up can explore if the tidy task, the msan tasks, or the valgrind tasks can also use a newer compiler version.

📝 fanquake locked a pull request: "Revert "depends: Fetch miniupnpc sources from an alternative website""
(https://github.com/bitcoin/bitcoin/pull/30602)
This reverts commit 21b8a14d37c19ce292d5529597e0d52338db48a9.

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
s
...

📝 fanquake locked a pull request: "get miniupnpc from ssl, this reverts commit 21b8a14d37c19ce292d5529597e0d52338db48a9"
(https://github.com/bitcoin/bitcoin/pull/30564)
the tuxfamily mirror is back up, revert back to an SSL source

🚀 fanquake merged a pull request: "doc: Add note about distro's `g++-mingw-w64-x86-64-posix` version"
(https://github.com/bitcoin/bitcoin/pull/30580)