💬 glozow commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1691152128)
Ah I didn't notice this yesterday - I think you may have swapped odd and even? Same in the commented mermaid diagram code just added.

💬 fanquake commented on pull request "Fee Estimation: change `estimatesmartfee` default mode to `economical`":
(https://github.com/bitcoin/bitcoin/pull/30275#issuecomment-2249911817)
Will need a release note.

✅ fanquake closed an issue: "Change estimate_mode default to "ECONOMICAL" in these RPC calls"
(https://github.com/bitcoin/bitcoin/issues/30009)

🚀 fanquake merged a pull request: "Fee Estimation: change `estimatesmartfee` default mode to `economical`"
(https://github.com/bitcoin/bitcoin/pull/30275)

💬 ismaelsadeeq commented on pull request "Fee Estimation: change `estimatesmartfee` default mode to `economical`":
(https://github.com/bitcoin/bitcoin/pull/30275#issuecomment-2249923172)
> Will need a release note.

Thanks, I will add it in the follow-up!

👍 hebasto approved a pull request: "ci: Add missing qttools5-dev install to Asan task"
(https://github.com/bitcoin/bitcoin/pull/30522#pullrequestreview-2198839834)
ACK faa359877270121b3cd442e1e5e865586ce7e530.

📝 hebasto opened a pull request: "doc: Rename build notes for MinGW-w64"
(https://github.com/bitcoin/bitcoin/pull/30523)
Broken out of https://github.com/bitcoin/bitcoin/pull/30454. Required because, after migration to CMake, the `doc/` subdirectory will contain notes for both MinGW-w64 and MSVC.

Addressed https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1690990701.

💬 hebasto commented on pull request "build: Introduce CMake-based build system":
(https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1691182478)
Done in https://github.com/bitcoin/bitcoin/pull/30523.

💬 fanquake commented on pull request "Detect and ignore transactions that were CPFP'd in the fee estimator":
(https://github.com/bitcoin/bitcoin/pull/25380#issuecomment-2249963225)
PIcked up in #30079.

💬 maflcko commented on issue "Intermittent issue in feature_proxy.py AssertionError: not(bytearray(b'node.noumenon') == b'fc00:1:2:3:4:5:6:7')":
(https://github.com/bitcoin/bitcoin/issues/29871#issuecomment-2249968557)
I wonder it it is due to

```
ci/test/00_setup_env_i686_multiprocess.sh:15:export TEST_RUNNER_EXTRA="--v2transport"

💬 maflcko commented on issue "Intermittent issue in feature_proxy.py AssertionError: not(bytearray(b'node.noumenon') == b'fc00:1:2:3:4:5:6:7')":
(https://github.com/bitcoin/bitcoin/issues/29871#issuecomment-2249970208)
Ah yes. Well, that was quick. Steps to reproduce on the first try:

```
$ while test/functional/feature_proxy.py --v2transport --valgrind ; do true ; done
2024-07-25T10:09:50.233000Z TestFramework (INFO): PRNG seed is: 4706088440128402104
2024-07-25T10:09:50.234000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin_func_test__c5c1wwl
2024-07-25T10:10:16.428000Z TestFramework (ERROR): Assertion failed

AssertionError: not(bytearray(b'node.noumenon') == b'fc00:1:2:3:4:5:6:7'
...

💬 hebasto commented on pull request "ci: add `_LIBCPP_REMOVE_TRANSITIVE_INCLUDES` to TSAN (libc++) job":
(https://github.com/bitcoin/bitcoin/pull/30519#issuecomment-2249975246)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/281.

💬 maflcko commented on pull request "doc: Rename build notes for MinGW-w64":
(https://github.com/bitcoin/bitcoin/pull/30523#discussion_r1691209371)
Isn't this one and `doc/README.md` about *native* builds? So probably better to link to the msvc, but that seems unrelated, so anything is fine here.

💬 maflcko commented on pull request "doc: Rename build notes for MinGW-w64":
(https://github.com/bitcoin/bitcoin/pull/30523#issuecomment-2249989163)
ACK 9930e73978e434e2efe6a0770728435b61ac6327

Rename makes sense either way, to clarify that this is about cross-compilation and not about a native build.

💬 hebasto commented on pull request "doc: Rename build notes for MinGW-w64":
(https://github.com/bitcoin/bitcoin/pull/30523#issuecomment-2249998520)
The CI lint task is green now. My apologies for multiples pushes.

💬 ryanofsky commented on pull request "contrib: fix check-deps.sh to check for weak symbols":
(https://github.com/bitcoin/bitcoin/pull/30415#issuecomment-2250005675)
If anyone else would like to review or test this, you can confirm that it works by just running `./contrib/devtools/check-deps.sh` in the source directory. The script will automatically call `make` to build the bitcoin libraries and should show `Success! No unexpected dependencies were detected.` if successful.

💬 hebasto commented on pull request "contrib: fix check-deps.sh to check for weak symbols":
(https://github.com/bitcoin/bitcoin/pull/30415#issuecomment-2250013650)
cc @m3dwards :)

💬 sipa commented on pull request "cluster mempool: cluster linearization algorithm":
(https://github.com/bitcoin/bitcoin/pull/30126#discussion_r1691238319)
@glozow I don't think so.

💬 fanquake commented on pull request "depends: Cleanup postprocess commands after switching to CMake":
(https://github.com/bitcoin/bitcoin/pull/30506#issuecomment-2250064713)
Looks good. Want to pull in the additional CMake cleanup here: https://github.com/fanquake/bitcoin/tree/30506_more_cleanup?

🚀 fanquake merged a pull request: "ci: Add missing qttools5-dev install to Asan task"
(https://github.com/bitcoin/bitcoin/pull/30522)

💬 sipa commented on issue "Unexpected behaviour when using `sortedmulti_a` descriptor":
(https://github.com/bitcoin/bitcoin/issues/30518#issuecomment-2250066455)
This apparent inconsistency is due to the fact that `multi_a` exists both as a top-level descriptor fragment and inside miniscript, but `sortedmulti_a` only as a top-level fragment.

We should probably add `sortedmulti_a` to miniscript too.