💬 hebasto commented on pull request "depends: remove `FORCE_USE_SYSTEM_CLANG`":
(https://github.com/bitcoin/bitcoin/pull/30201#issuecomment-2227218096)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "doc: use TRUC instead of v3 and add release note":
(https://github.com/bitcoin/bitcoin/pull/30272#issuecomment-2227218237)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "kernel: remove mempool_persist":
(https://github.com/bitcoin/bitcoin/pull/30344#issuecomment-2227218290)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "random: add benchmarks and drop unnecessary Shuffle function":
(https://github.com/bitcoin/bitcoin/pull/30396#issuecomment-2227218388)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "remove truc_policy from libbitcoin_common_a_SOURCES":
(https://github.com/bitcoin/bitcoin/pull/30427#issuecomment-2227218487)
Ported to the CMake-based build system in https://github.com/hebasto/bitcoin/pull/264.

💬 hebasto commented on pull request "build: Fix building `fuzz` binary on on SunOS / illumos":
(https://github.com/bitcoin/bitcoin/pull/30216#issuecomment-2227224103)
There is nothing to port to the CMake staging branch. Deleting the "Needs CMake port" label.

💬 hebasto commented on pull request "ci: move ASan job to GitHub Actions from Cirrus CI":
(https://github.com/bitcoin/bitcoin/pull/30193#issuecomment-2227224395)
There is nothing to port to the CMake staging branch. Deleting the "Needs CMake port" label.

💬 hebasto commented on pull request "build: Drop redundant `sys/sysctl.h` header check":
(https://github.com/bitcoin/bitcoin/pull/30327#issuecomment-2227224621)
There is nothing to port to the CMake staging branch. Deleting the "Needs CMake port" label.

💬 hebasto commented on pull request "Update libsecp256k1 subtree to latest master":
(https://github.com/bitcoin/bitcoin/pull/30334#issuecomment-2227224889)
There is nothing to port to the CMake staging branch. Deleting the "Needs CMake port" label.

💬 hebasto commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#issuecomment-2227303124)
> In the current implementation Qt uses '&' as a signal to underscore letter and use it as a hot-key, which is not expected for case of wallet name.

Does this hold for all [supported](https://github.com/bitcoin-core/gui/blob/master/doc/dependencies.md) Qt versions?

>
> The [comment in the code](https://github.com/bitcoin/bitcoin/pull/30446/files#diff-2ecf8cbf369cf3d2f3d2b1cf5cfe4c1a647d63e11e2885d2fd0ac11fb5f7a804L402-L404) is misleading, if you replace one & to double &&, the next & wil
...

💬 hebasto commented on pull request "Migrate legacy wallets that are not loaded":
(https://github.com/bitcoin-core/gui/pull/824#discussion_r1677109394)
https://github.com/bitcoin-core/gui/pull/828 can relevant to this code.

💬 hebasto commented on pull request "Migrate legacy wallets that are not loaded":
(https://github.com/bitcoin-core/gui/pull/824#discussion_r1677109570)
Mind following the Doxygen comment formatting above?

💬 hebasto commented on pull request "Migrate legacy wallets that are not loaded":
(https://github.com/bitcoin-core/gui/pull/824#discussion_r1677110013)
Why is this line needed?

💬 hebasto commented on pull request "Migrate legacy wallets that are not loaded":
(https://github.com/bitcoin-core/gui/pull/824#discussion_r1677105954)
Apparently, this code has been dead since introducing in https://github.com/bitcoin-core/gui/pull/738.

💬 hebasto commented on pull request "Migrate legacy wallets that are not loaded":
(https://github.com/bitcoin-core/gui/pull/824#issuecomment-2227310588)
> This PR changes that menu item into a menu list like Open Wallet and lets users migrate any legacy wallet in their wallet directory regardless of the wallets loaded.

Tested d45ac03a89cc500cd461f878f092cf8ec99e7760. The "Migrate Wallet" menu item is still disabled when no wallet is loaded.

💬 paplorinc commented on pull request "Don't empty dbcache on prune flushes: >30% faster IBD":
(https://github.com/bitcoin/bitcoin/pull/28280#issuecomment-2227314032)
> the first commit should probably be

The first commit was just unrelated refactor, was easier to use that as a 'before'.

> a warmup run is going to take a long time

Yeah, but this makes the measurements simpler (this way I don't need the `sync` and `drop_caches`), both runs start from the same (slightly warmed up) state. Plus I didn't want to test the *exact* same settings as you did :)

> wrap hyperfine with nohup ... &

was using `tmux` for that, the warmup and the first 2 itera
...

👍 hebasto approved a pull request: "Show maximum mempool size in information window"
(https://github.com/bitcoin-core/gui/pull/825#pullrequestreview-2176638161)
ACK 4a028cf54c0502bc9ba0804bf1ae413b20a007cb, tested on Ubuntu 24.04.

🚀 hebasto merged a pull request: "Show maximum mempool size in information window"
(https://github.com/bitcoin-core/gui/pull/825)

💬 paplorinc commented on pull request "optimization: Precalculate SipHash constant XOR with k0 and k1 in SaltedOutpointHasher":
(https://github.com/bitcoin/bitcoin/pull/30442#issuecomment-2227334986)
@andrewtoth, this is another tiny addition to the [coincache speedup](https://github.com/bitcoin/bitcoin/pull/28280), your review would be welcome.

💬 knst commented on pull request "fix: rendering an amp characters in the wallet name for QMenu":
(https://github.com/bitcoin-core/gui/pull/828#issuecomment-2227338378)
> I'm not certain about that, but the mentioned comment might have been correct for some earlier version of Qt.
I tested with 2 version: Qt 5.15.14 and Qt 5.15.11.

Doc for [qt 6](https://doc.qt.io/qt-6/qmenubar.html) says:
> The ampersand in the menu item's text sets Alt+F as a shortcut for this menu. (You can use "&&" to get a real ampersand in the menu bar.)

Doc for [qt 5](https://doc.qt.io/qt-5/qmenubar.html) says the same:
> The ampersand in the menu item's text sets Alt+F as a shor
...

⚠️ ErnestoLara opened an issue: "y"
(https://github.com/bitcoin/bitcoin/issues/30449)