💬 maflcko commented on pull request "rpc: Avoid getchaintxstats invalid results":
(https://github.com/bitcoin/bitcoin/pull/29720#issuecomment-2225104347)
See https://github.com/bitcoin/bitcoin/issues/29359

📝 hodlinator opened a pull request: "fix: Make TxidFromString() respect string_view length"
(https://github.com/bitcoin/bitcoin/pull/30436)
Prompted by comment in https://github.com/bitcoin/bitcoin/pull/30377#issuecomment-2208857200 (referring to https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1404437378).

💬 hodlinator commented on pull request "refactor: Make uint256S(const char*) consteval":
(https://github.com/bitcoin/bitcoin/pull/30377#issuecomment-2225154172)
> > **transaction_identifier.h** - Fixed dormant bug in `TxidFromString()` where the `string_view` length wasn't respected(!).
>
> This is known, see [#28922 (comment)](https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1404437378). Thanks for picking it up!
>
> Maybe submit the fix first?

PR up now: #30436

💬 maflcko commented on pull request "depends: bump boost to 1.85.0 and use new CMake buildsystem":
(https://github.com/bitcoin/bitcoin/pull/30434#issuecomment-2225163931)
The CI failure https://cirrus-ci.com/task/4950868422819840:

```
Extracting boost...
/ci_container_base/depends/sources/boost-1.85.0-cmake.tar.gz: OK
Preprocessing boost...
Configuring boost...
-- The CXX compiler identification is Clang 18.1.3
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/env - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Boost: using system layout: i
...

💬 fjahr commented on pull request "assumeutxo: Add dumptxoutset height param, remove shell scripts":
(https://github.com/bitcoin/bitcoin/pull/29553#discussion_r1675572668)
I added a small comment and also mention it now in the usage guide as well as the rpc help text.

🚀 fanquake merged a pull request: "util: Use SteadyClock in RandAddSeedPerfmon"
(https://github.com/bitcoin/bitcoin/pull/30372)

💬 maflcko commented on issue "ci: failure in `p2p_unrequested_blocks.py`":
(https://github.com/bitcoin/bitcoin/issues/30430#issuecomment-2225189511)
Dupe of https://github.com/bitcoin/bitcoin/issues/29897 ?

✅ fanquake closed an issue: "ci: failure in `p2p_unrequested_blocks.py`"
(https://github.com/bitcoin/bitcoin/issues/30430)

💬 fanquake commented on issue "ci: failure in `p2p_unrequested_blocks.py`":
(https://github.com/bitcoin/bitcoin/issues/30430#issuecomment-2225193937)
Yea looks like it. I grepped for p2p_unrequested_blocks but somehow did not find that.

💬 maflcko commented on issue "ci: failure in `p2p_unrequested_blocks.py`":
(https://github.com/bitcoin/bitcoin/issues/30430#issuecomment-2225196887)
Yeah, it is a github search bug. You'll have to search for `test.py` (with the `.py` suffix)

💬 m3dwards commented on pull request "net: Allow -proxy=[::1] on nodes with IPV6 lo only":
(https://github.com/bitcoin/bitcoin/pull/30245#discussion_r1675595527)
I think it's overkill. In all the examples and documentation I've read, `freeaddrinfo()` is only called when `getaddrinfo()` succeeds.

👍 hebasto approved a pull request: "init: change shutdown order of load block thread and scheduler"
(https://github.com/bitcoin/bitcoin/pull/30435#pullrequestreview-2174334468)
ACK e427fed82f7931ae6f09a4939e0fcd6cb235ef0d, the change looks correct and it indeed [fixes](https://github.com/bitcoin/bitcoin/issues/30424#issuecomment-2223971606) the issue.

💬 delta1 commented on pull request "refactor: Allow CScript construction from any std::input_iterator":
(https://github.com/bitcoin/bitcoin/pull/29369#issuecomment-2225223670)
reACK fa7b9b9

💬 glozow commented on pull request "MiniMiner: use FeeFrac in AncestorFeerateComparator":
(https://github.com/bitcoin/bitcoin/pull/30412#discussion_r1675637623)
I'll add an update to the comment if I retouch

💬 fjahr commented on pull request "assumeutxo: Add dumptxoutset height param, remove shell scripts":
(https://github.com/bitcoin/bitcoin/pull/29553#issuecomment-2225269474)
Rebased and addressed feedback from @ryanofsky and @maflcko, thank you! This now includes the check for undo data since this was made possible by merge of https://github.com/bitcoin/bitcoin/pull/29668.

💬 Fi3 commented on pull request "Stratum v2 Template Provider (take 3)":
(https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2225283367)
> I would then make another call to the interface to get those transactions, but by that that time the node has already forgotten the template it gave me and the mempool may have dropped some of the transactions it included.

Can you cache the tx data and keep them for the time that the template is valid. If you have more templates you save shared txs just one time.

📝 ryanofsky opened a pull request: "multiprocess: add bitcoin-mine test program "
(https://github.com/bitcoin/bitcoin/pull/30437)
Add [`bitcoin-mine`](https://github.com/ryanofsky/bitcoin/blob/pr/mine/src/bitcoin-mine.cpp#L19-L42) executable to test connecting to the `bitcoin-node` process over a unix socket and calling [`interface::Mining`](https://github.com/ryanofsky/bitcoin/blob/pr/mine/src/interfaces/mining.h) methods.

This could be useful as discussed in https://github.com/bitcoin/bitcoin/pull/29432#issuecomment-2222418506 to work on getting mining code working in an external process.

This PR is a draft, becaus
...

🤔 marcofleon reviewed a pull request: "fuzz: wallet: add target for `CreateTransaction`"
(https://github.com/bitcoin/bitcoin/pull/29936#pullrequestreview-2174428032)
Nice, coverage looks good now. The issue I'm seeing is the harness has really low stability. It's at 28% with the seed corpus I'm using. The only obvious source of randomness I'm seeing is in `CreateTransactionInternal`:
https://github.com/bitcoin/bitcoin/blob/4d6af61d879914a660e73db5c2f2e6c4d0aa8243/src/wallet/spend.cpp#L1164-L1166

Sometimes `changepos` isn't set so it does hit that line. Maybe there are other reasons for the low stability somewhere else?

💬 hebasto commented on pull request "depends: bump boost to 1.85.0 and use new CMake buildsystem":
(https://github.com/bitcoin/bitcoin/pull/30434#issuecomment-2225302383)
> The CI failure https://cirrus-ci.com/task/4950868422819840:

Maybe revert 3bee51427a05075150721f0a05ead8f92e1ba019?

FWIW, in the CMake staging branch, `set(CMAKE_PLATFORM_HAS_INSTALLNAME FALSE)` is used in between the `project()` and `enable_language(CXX)` calls to [workaround](https://github.com/hebasto/bitcoin/blob/292e7da439a732092e3823fadd2379bbb7d3ff2b/CMakeLists.txt#L45-L53) it:
```cmake
#=============================
# Language setup
#=============================
if(CMAKE_SYS
...

🤔 maflcko reviewed a pull request: "fix: Make TxidFromString() respect string_view length"
(https://github.com/bitcoin/bitcoin/pull/30436#pullrequestreview-2174408053)
left some comments

💬 maflcko commented on pull request "fix: Make TxidFromString() respect string_view length":
(https://github.com/bitcoin/bitcoin/pull/30436#discussion_r1675652818)
nit in a4ead4e51c04c75c7837fb53116062e79f502bbd (commit message): Could link directly to the discussion https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1404437378 ?