💬 fjahr commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#discussion_r1617976968)
Sounds good, but keeping this for a follow-up.

💬 luke-jr commented on pull request "rpc: net: follow-ups for #30062":
(https://github.com/bitcoin/bitcoin/pull/30183#discussion_r1617978145)
Last I checked, we require more than just a flag?

💬 fjahr commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2136251685)
I'm pouring one out for all the tACKs we've lost but the rebase was necessary.

I have addressed the comments from @Sjors and I think those were all that are in scope for this PR here. Mostly it's adding comments and a few


I think the chain replay idea from @TheBlueMatt is probably best tracked in a separate issue. Potentially there are already projects out there that can provide the necessary functionality, I am not aware of anything like that though.

👍 theStack approved a pull request: "functional test: ensure confirmed utxo being sourced for 2nd chain"
(https://github.com/bitcoin/bitcoin/pull/29998#pullrequestreview-2083992790)
ACK 07aba8dd215b23b06853b1a9fe04ac8b08f62932

💬 brunoerg commented on pull request "rpc: net: follow-ups for #30062":
(https://github.com/bitcoin/bitcoin/pull/30183#discussion_r1617990003)
Just need to set the flag with a valid asmap file.

💬 fjahr commented on pull request "Testnet4 including PoW difficulty adjustment fix":
(https://github.com/bitcoin/bitcoin/pull/29775#issuecomment-2136268587)
The CI failure doesn't seem related, somehow the test-each-commit job was instantly cancelled.

💬 marcofleon commented on pull request "fuzz: increase `txorphan` harness stability":
(https://github.com/bitcoin/bitcoin/pull/30186#issuecomment-2136280587)
Seems like CI still doesn't like it.

I tried this (no space after -i)
`sed -i'' 's/nNextSweep/m_next_sweep/g' $(git grep -l 'nNextSweep')`

and it didn't work on Mac. Adding the `-e` without `.bak` creates new `txorphanage` files with `-e` appended to the end of them. Something like `txorphanage.h-e`. Adding `.bak` prevented that but CI isn't accepting it.

💬 davidgumberg commented on pull request "ci: add markdown link check job":
(https://github.com/bitcoin/bitcoin/pull/30034#issuecomment-2136391365)
reACK https://github.com/bitcoin/bitcoin/commit/4b7d9842691046b01f0c08d69f924ddb62ccc4c6

Looks great!

Tested with the following diff:

```diff
diff --git a/test/lint/README.md b/test/lint/README.md
index 49ed8356c3..47ac472aa6 100644
--- a/test/lint/README.md
+++ b/test/lint/README.md
@@ -36,7 +36,7 @@ Then you can use:
| [`lint-shell.py`](/test/lint/lint-shell.py) | [ShellCheck](https://github.com/koalaman/shellcheck)
-| [`lint-spelling.py`](/test/lint/lint-spelling.py) | [codes
...

🤔 jonatack reviewed a pull request: "rpc: net: follow-ups for #30062"
(https://github.com/bitcoin/bitcoin/pull/30183#pullrequestreview-2084228631)
Concept ACK, perhaps take https://github.com/bitcoin/bitcoin/pull/30062#discussion_r1612276581 too if you agree. These could be one commit, i.e. `rpc: getrawaddrman "mapped_as" follow-ups`

💬 jonatack commented on pull request "rpc: net: follow-ups for #30062":
(https://github.com/bitcoin/bitcoin/pull/30183#discussion_r1618155192)
Perhaps use the -netinfo help doc (here and line 1157 below):

```
Mapped AS (Autonomous System) number in the BGP route to the peer, used for diversifying
peer selection (only displayed if the -asmap config option is set)
```

(the getpeerinfo help below is similar but the -netinfo one seems more complete)

```
The AS in the BGP route to the peer used for diversifying
peer selection (only available if the asmap config flag is set)
```

💬 ajtowns commented on pull request "contrib: add tool to convert compact-serialized UTXO set to SQLite database":
(https://github.com/bitcoin/bitcoin/pull/27432#issuecomment-2136522127)
utACK 0a89179d62a5b2c5ebc20b806122bb50fc199cba -- no deep review, but being able to mess around with the utxo set as an sqlite dump is handy, and adding a script to contrib seems low risk.

As at height 844861, the raw dump is ~12GB and the sqlite version is ~25GB, so having a bunch of free space is helpful if you want to try it out.

💬 maflcko commented on pull request "fuzz: increase `txorphan` harness stability":
(https://github.com/bitcoin/bitcoin/pull/30186#issuecomment-2136633794)
> and it didn't work on Mac.

You'll have to install and use gnu-sed on macos, or use Linux. If you don't want to test locally and want to know the syntax without testing, you can look at previous examples via `git log --grep='sed -i'`.

Though, I am not sure if a three line diff is worth a scripted diff, so an alternative would be to just squash everything down into a single commit.

💬 maflcko commented on pull request "fuzz: increase `txorphan` harness stability":
(https://github.com/bitcoin/bitcoin/pull/30186#discussion_r1618285437)
In any case, you are changing the code to leave the variable uninitialized. This is undefined behavior.

You can test this with valgrind, or msan.

🤔 glozow reviewed a pull request: "[25.x] windeploy: Renew certificate"
(https://github.com/bitcoin/bitcoin/pull/30184#pullrequestreview-2084528082)
ACK 7a4eff2c98eb41e304cfb03372bce401909bf3d0

💬 willcl-ark commented on pull request "[27.x] Backports and rc1":
(https://github.com/bitcoin/bitcoin/pull/30092#issuecomment-2136772471)
reACK 22701a43464ab27ea83c8b49e2732ee647909a10

on range-diff https://github.com/bitcoin/bitcoin/compare/f30e23e4b35b52728ebaa1a63ec9a6feac51ebb4..22701a43464ab27ea83c8b49e2732ee647909a10

👍 hebasto approved a pull request: "[27.x] Backports and rc1"
(https://github.com/bitcoin/bitcoin/pull/30092#pullrequestreview-2084595651)
re-ACK 22701a43464ab27ea83c8b49e2732ee647909a10.

💬 willcl-ark commented on pull request "Update manpage descriptions":
(https://github.com/bitcoin/bitcoin/pull/29686#discussion_r1618399698)
Re-worded in 4aff4ea92c96f4f66e0159329ad8d01d4cf7bce7

👍 TheCharlatan approved a pull request: "Encapsulate warnings in generalized node::Warnings and remove globals"
(https://github.com/bitcoin/bitcoin/pull/30058#pullrequestreview-2084610211)
Re-ACK 468cf536eb6473b0fbc1d0f9763c8d6caedeb849

📝 Sajjon opened a pull request: "Fix typos in 36 files | Almost only documentation"
(https://github.com/bitcoin/bitcoin/pull/30188)
<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->

<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:

* Any test improvements or new tests that improv
...

💬 Sajjon commented on pull request "Fix typos in 36 files | Almost only documentation":
(https://github.com/bitcoin/bitcoin/pull/30188#discussion_r1618407491)
`rg "ROWS_AVALIABLE_FOR_LIST"` shows empty, so all relevant references have been renamed.

💬 Sajjon commented on pull request "Fix typos in 36 files | Almost only documentation":
(https://github.com/bitcoin/bitcoin/pull/30188#discussion_r1618408697)
The config *is* named `FORMULA_TRANSPARENT` so this is purely a typo correction, no logic effect.