🤔 TheCharlatan reviewed a pull request: "rpc: Optimize serialization and enhance metadata of dumptxoutset output"
(https://github.com/bitcoin/bitcoin/pull/29612#pullrequestreview-2051206848)
Nice, just some small comments, will review again quickly once they are addressed.

💬 TheCharlatan commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1597449496)
In commit b2cf3f77b14bccf11ad5bc211db7f746ae5073fb:
Nit: Could just do `const auto regtest_msg = CChainParams::RegTest({})->MessageStart();` here and for the `signet_msg`.

💬 TheCharlatan commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1597450105)
In commit b2cf3f77b14bccf11ad5bc211db7f746ae5073fb:
Is this include from a prior iteration? It seems unused (also in the header file).

💬 TheCharlatan commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1597453382)
In commit b2cf3f77b14bccf11ad5bc211db7f746ae5073fb:
Nit: I think this should be moved to the first commit.

💬 TheCharlatan commented on pull request "rpc: Optimize serialization and enhance metadata of dumptxoutset output":
(https://github.com/bitcoin/bitcoin/pull/29612#discussion_r1597455340)
In commit b2cf3f77b14bccf11ad5bc211db7f746ae5073fb
Nit (clang-format-diff): Open braces on new line (here and the other new functions and methods below).

📝 luke-jr opened a pull request: "Bugfix: RPC/Mining: getblocktemplate: Delay updating nTransactionsUpdatedLast and time_start until after the new template is cached"
(https://github.com/bitcoin/bitcoin/pull/30088)
This is needed to avoid parallel calls from incorrectly using the stale cached template or (after an OOM) dereferencing a nullptr pblocktemplate

Considering memory overcommit, the worst case scenario likely never occurs, but that possibility is the clear bugfix here.

Aside from that, I wonder if using the stale cache in this race scenario (which is what could happen if this isn't fixed) is better than having N threads all making a new block (with this fix).

A middle ground (and perhaps
...

💬 Ridvan8899 commented on issue "Release Schedule for 28.0":
(https://github.com/bitcoin/bitcoin/issues/29891#issuecomment-2105927410)
[]()ننثخق

💬 Ridvan8899 commented on issue "upstream: GUIX closure contains too much unnecessary stuff":
(https://github.com/bitcoin/bitcoin/issues/30042#issuecomment-2105927573)
او وة

💬 Ridvan8899 commented on issue "upstream: GUIX closure contains too much unnecessary stuff":
(https://github.com/bitcoin/bitcoin/issues/30042#issuecomment-2105927703)
تااا

💬 Ridvan8899 commented on issue "~/.bitcoin (which is a softlink to a separate vmware virtual drive) dir is now almost 1tb":
(https://github.com/bitcoin/bitcoin/issues/29909#issuecomment-2105927747)
اةا

💬 Ridvan8899 commented on issue "utils: wallet_dump can create a `database` directory, cross-pollinating records":
(https://github.com/bitcoin/bitcoin/issues/29883#issuecomment-2105927772)
تالل

💬 BrandonOdiwuor commented on pull request "Wallet: (Refactor) GetBalance to calculate used balance":
(https://github.com/bitcoin/bitcoin/pull/29062#discussion_r1597469144)
@achow101 do the added comments make the PR easy to follow?

🤔 BrandonOdiwuor reviewed a pull request: "init: fixes file descriptor accounting"
(https://github.com/bitcoin/bitcoin/pull/30065#pullrequestreview-2051226362)
Concept ACK

📝 luke-jr opened a pull request: "GUI: Enable customisation of QR Code font"
(https://github.com/bitcoin-core/gui/pull/820)
May need the fixes in #506 to work cleanly in all cases, but should still be a net improvement on its own

💬 nolajohn commented on issue "[flatpak] - I cannot choose or change datadir when running from flatpak":
(https://github.com/bitcoin/bitcoin/issues/24612#issuecomment-2105945843)
This worked for me - Pop!_OS (Ubuntu 22.04 LTS) running bitcoincore installed via flatpak:

Get the flatpak ID:
```
> flatpak list | grep -i bitcoin
> Bitcoin Core org.bitcoincore.bitcoin-qt 26.1 stable user
```
Allow flatpak to use the new data folder:
```
> flatpak override --user --filesystem=/my/new/folder/for-btc-data org.bitcoincore.bitcoin-qt
```
Launch from the command line:
```
> flatpak run org.bitcoincore.bitcoin-qt --datadir=/my/new/folder/for-btc-data &
```
I have to
...

💬 theStack commented on pull request "test: fix MiniWallet script-path spend (missing parity bit in leaf version)":
(https://github.com/bitcoin/bitcoin/pull/30076#issuecomment-2105953269)
Thanks for the review @rkrux! Addressed your comment https://github.com/bitcoin/bitcoin/pull/30076#discussion_r1596687155; the single taproot leaf is now accessed directly rather than by name, so there is no magic string involved anymore. Note that the leaf name (second parameter to `taproot_construct`) still had to be changed from `None` to some string, as otherwise no entry in the `taproot_info.leaves` dictionary would be created.

💬 luke-jr commented on pull request "Add option dbfilesize to control LevelDB target ("max") file size":
(https://github.com/bitcoin/bitcoin/pull/30059#discussion_r1597483759)
LevelDB itself enforces it. Would it make sense to check it redundantly on our end to control error behaviour? (But then we have to remember to keep it in sync with LevelDB... but maybe just having the docs necessitates that)

💬 hebasto commented on pull request "kernel: Streamline util library":
(https://github.com/bitcoin/bitcoin/pull/29015#issuecomment-2105975730)
> I also added a [script](https://github.com/ryanofsky/bitcoin/blob/pr/rmutil/test/util/check-deps.sh) which turned up a few other other unexpected dependencies (not related to util), which could be addressed separately.

It would be great to have such a tool at our disposal.

👍 hebasto approved a pull request: "debugwindow: update session ID tooltip"
(https://github.com/bitcoin-core/gui/pull/788#pullrequestreview-2051240925)
ACK 3bf00e13609eefa6ddb11353519bb1aec2342513.

🚀 hebasto merged a pull request: "debugwindow: update session ID tooltip"
(https://github.com/bitcoin-core/gui/pull/788)

👍 hebasto approved a pull request: "Don't permit port in proxy IP option"
(https://github.com/bitcoin-core/gui/pull/813#pullrequestreview-2051243691)
ACK 10c5275ba4532fb1bf54057d2f61fc35b51f1e85, tested on Ubuntu 24.04.